Skip to main content
J
jnv93729390
Known Participant
July 22, 2019
Answered

Create a loop to move layers into a specific layer set, depending of the name of the layer

  • July 22, 2019
  • 3 replies
  • 2300 views

Hello all,

I need to sort the layers into a layer set, in order to treat them with a second script.

Here is the main problematic :

Layers got differents names, such as "01", "01 copy", "10", "101535", "Text" ... I only need to move layers named with numbers from 1 to 30, and rename them from "01" to "1" (without the zero).

To resolve it, I did as follow :

  1. I managed to use a LEFT() and RIGHT() function to isolate the two first characters of the layer name (ex : 10 copy -> 10; 01 copy -> 01 then 01 -> 1 ...)
  2. I tried to write a loop with the following conditions : "for every layers of the active document, if the name of the layer is comprised between 1 and 30, move the layer to the layer Set "Puce". "

The loop is only half correct, because it move half of the layers (one in two).

I'm aware the method is a bit brutal, but I couldn't find the best way to write a conditionning rule without the "If" ...I'm a beginner in Javascript for PSD so I probably did a mistake in the loop too

Many thanks in advance to whomever's gonna help !

Here's the script :

  1. var doc = app.activeDocument;
  4. // Set the Left() function
  5. String.prototype.left = function(n) {
  6.     return this.substring(0, n);
  7. }
  8. // Set the Right() function
  9. String.prototype.right = function(n) {
  10.     return this.substring(1, n);
  11. }
  18. // Sort layers into "PUCES"
  21. // Create the Layer set "PUCES"
  22. var newLayerSet = doc.layerSets.add();
  23. newLayerSet.name = 'PUCES';
  26. //move the layers into the layerset "PUCES"         
  27. var j = 0
  28. for (var i =0; i+1<doc.artLayers.length; i++) 
  29. {
  30. //Management of the active Layer Name
  31. var dotLayer = doc.artLayers[1]
  32. var dotLayerName = dotLayer.name
  33. var dotLayerNameShort = dotLayerName.left(2);
  34. //remove the 0 from the prime numbers (right fonction)
  35. if(dotLayerNameShort < 10){
  36. var dotLayerNameShort = dotLayerName.right(2);
  37. }
  38. j++
  39. // Check if the layer is a dot
  40. if(dotLayerNameShort === '1'){
  41. dotLayer.move(newLayerSet, ElementPlacement.INSIDE);
  42. } else {
  43. if(dotLayerNameShort === '2'){
  44. dotLayer.move(newLayerSet, ElementPlacement.INSIDE);
  45. } else {
  46. if(dotLayerNameShort === "3"){
  47. dotLayer.move(newLayerSet, ElementPlacement.INSIDE);
  48. } else {
  49. if(dotLayerNameShort === "4"){
  50. dotLayer.move(newLayerSet, ElementPlacement.INSIDE);
  51. } else {
  52. if(dotLayerNameShort === "5"){
  53. dotLayer.move(newLayerSet, ElementPlacement.INSIDE);
  54. } else {
  55. if(dotLayerNameShort === "6"){
  56. dotLayer.move(newLayerSet, ElementPlacement.INSIDE);
  57. } else {
  58. if(dotLayerNameShort === "7"){
  59. dotLayer.move(newLayerSet, ElementPlacement.INSIDE);
  60. } else {
  61. if(dotLayerNameShort === "8"){
  62. dotLayer.move(newLayerSet, ElementPlacement.INSIDE);
  63. } else {
  64. if(dotLayerNameShort === '9'){
  65. dotLayer.move(newLayerSet, ElementPlacement.INSIDE);
  66. } else {
  67. if(dotLayerNameShort === "10"){
  68. dotLayer.move(newLayerSet, ElementPlacement.INSIDE);
  69. } else {
  70. if(dotLayerNameShort === "11"){
  71. dotLayer.move(newLayerSet, ElementPlacement.INSIDE);
  72. } else {
  73. if(dotLayerNameShort === "12"){
  74. dotLayer.move(newLayerSet, ElementPlacement.INSIDE);
  75. } else {
  76. if(dotLayerNameShort === "13"){
  77. dotLayer.move(newLayerSet, ElementPlacement.INSIDE);
  78. } else {
  79. if(dotLayerNameShort === "14"){
  80. dotLayer.move(newLayerSet, ElementPlacement.INSIDE);
  81. } else {
  82. if(dotLayerNameShort === "15"){
  83. dotLayer.move(newLayerSet, ElementPlacement.INSIDE);
  84. } else {
  85. if(dotLayerNameShort === "16"){
  86. dotLayer.move(newLayerSet, ElementPlacement.INSIDE);
  87. } else {
  88. if(dotLayerNameShort === "17"){
  89. dotLayer.move(newLayerSet, ElementPlacement.INSIDE);
  90. } else {
  91. if(dotLayerNameShort === "18"){
  92. dotLayer.move(newLayerSet, ElementPlacement.INSIDE);
  93. } else {
  94. if(dotLayerNameShort === "19"){
  95. dotLayer.move(newLayerSet, ElementPlacement.INSIDE);
  96. } else {
  97. if(dotLayerNameShort === "20"){
  98. dotLayer.move(newLayerSet, ElementPlacement.INSIDE);
  99. } else {
  100. if(dotLayerNameShort === "21"){
  101. dotLayer.move(newLayerSet, ElementPlacement.INSIDE);
  102. } else {
  103. if(dotLayerNameShort === "22"){
  104. dotLayer.move(newLayerSet, ElementPlacement.INSIDE);
  105. } else {
  106. if(dotLayerNameShort === "23"){
  107. dotLayer.move(newLayerSet, ElementPlacement.INSIDE);
  108. } else {
  109. if(dotLayerNameShort === "24"){
  110. dotLayer.move(newLayerSet, ElementPlacement.INSIDE);
  111. } else {
  112. if(dotLayerNameShort === "25"){
  113. dotLayer.move(newLayerSet, ElementPlacement.INSIDE);
  114. } else {
  115. if(dotLayerNameShort === "26"){
  116. dotLayer.move(newLayerSet, ElementPlacement.INSIDE);
  117. } else {
  118. if(dotLayerNameShort === "27"){
  119. dotLayer.move(newLayerSet, ElementPlacement.INSIDE);
  120. } else {
  121. if(dotLayerNameShort === "28"){
  122. dotLayer.move(newLayerSet, ElementPlacement.INSIDE);
  123. } else {
  124. if(dotLayerNameShort === "29"){
  125. dotLayer.move(newLayerSet, ElementPlacement.INSIDE);
  126. } else {
  127. if(dotLayerNameShort === "30"){
  128. dotLayer.move(newLayerSet, ElementPlacement.INSIDE);
  129. }
  130. }}}}}}}}}}}}}}}}}}}}}}}}}}}}}}
This topic has been closed for replies.
Correct answer r-bin

Very strange non-optimal script.
Why do you define the variable "j"?

To make it work, change this line.

for (var i =0; i+1<doc.artLayers.length; i++)

on this ones

var artLayers = new Array();
for (var i =0; i<doc.artLayers.length; i++) artLayers.push(doc.artLayers);
for (var i =0; i+1<artLayers.length; i++)

3 replies

Chuck Uebele
Community Expert
Chuck UebeleCommunity Expert
Community Expert
July 22, 2019

You can add an if statement to check if the layer is not a text layer:

if(doc.activeLayer.kind != LayerKind.TEXT){//code here
    }
J
jnv93729390Author
Known Participant
July 23, 2019

Thank you, I struggled to find where to add it but it finaly worked

Chuck Uebele
Community Expert
Chuck UebeleCommunity Expert
Community Expert
July 22, 2019

Try this:

#target photoshop
var doc = activeDocument;
var newLayerSet = doc.layerSets.add();
var tempLayer = newLayerSet.artLayers.add();
var layA = new Array()
for (var i=0;i<doc.layers.length;i++){
    var layName = Number(doc.layers.name.replace(/\s/g, ""));
    if( !isNaN (layName) && layName<31){
        layA.push(doc.layers);
        }//end if
    }//end for loop
for(var i=0;i<layA.length;i++){
    layA.move(tempLayer, ElementPlacement.PLACEBEFORE);
    layA.name = Number(layA.name);
    }
tempLayer.remove();
R
r-binCorrect answer
Legend
July 22, 2019

Very strange non-optimal script.
Why do you define the variable "j"?

To make it work, change this line.

for (var i =0; i+1<doc.artLayers.length; i++)

on this ones

var artLayers = new Array();
for (var i =0; i<doc.artLayers.length; i++) artLayers.push(doc.artLayers);
for (var i =0; i+1<artLayers.length; i++)
J
jnv93729390Author
Known Participant
July 22, 2019

My mistake ... the variable j was originally used for the line

var dotLayer = doc.artLayers;

And I know the code isn't optimal, I've start learning javascript last monday ... ^^

Terms & ConditionsAccessibility statement
Using the community Terms of use Privacy Cookie preferences Do not sell or share my personal information ad choicesAdChoices