The company I work for has a 'creative cloud all apps' plan and also a 'photography plan' and there's crossover with the apps that are included in the plans - doI have to have the photography plan to have photoshop,if its also within the creative cloud plan?
the all-apps plan includes everything that's in the photography plan and much, much more. so no, you do not need (and have nothing to gain with) the photography plan if you're going to get the all-apps plan.
If you decide to cancel the photography plan, though, make sure that you've downloaded all your files from the cloud to your own system(s). Also check the time remaining on the subscription. If there's more than 6 months left, you're better off waiting until the final month to cancel since otherwise you're paying a penalty.