How do I eliminate a warning popup?

[wwagner1]

I have created a calculated field for figuring margin percentage.  (x-y)/x = GM%

Because I don't want the "x" or "y" fields to have any numbers in them when I first open the form, I get a Javascript Warning Popup that states: "the value entered does not match the format of the field [ GMRow3 ]"

In this example, GMRow3 is the calculated field which is zero because there is no data in "x" or "y" when you initially open the form.  My formula works and works well, and it is formatted for return a percentage.

How can I get rid of the popup? 

[George_Johnson]

The problem is when the x field is blank, the field value is evaluated as zero, and dividing by zero results in something that cannot be formatted as a percentage. The  fix is to use a custom calculation script the check the value of x, and if it's zero, sets the calculated value to an empty string. Otherwise it calculates the value according to the formula. You may want to also check that the value of y and only perform the calculation if both x and are are not blank.

[wwagner1]

Hi George, this is all new to me - writing scripts like this that is.  Is what you're describing something that is written in the same format as an "IF" calculation in Excel?  I would ditch the formula I created in the simplified field notation and write a new formula in the custom calculation script?

I apologize if this is elementary.

[George_Johnson]

Here's a custom calculation script that only performs the calculation if both of the input fields are not blank and the x value is not zero:

// Custom calculation script for text field

(function () {

    // Get the field values, as strings

    var sX = getField("x").valueAsString;

    var sY = getField("y").valueAsString;

    // Convert the string values to numbers

    var nX = +sX;

    var nY = +sY;

    if (sX && sY && nX !== 0) {

        event.value = 1 - nY / nX;

    } else {

        event.value = "";

    }

})();

[wwagner1]

I'm sorry George, but I don't understand this at all, though I really appreciate your effort in trying to educate me.  Does it help you help me if you look at the below screen shot of what I'm trying to do?  The calculated field is GMRow1.  To calculate the margin percentage I am using the following formula: (TSP1-TC1)/TSP1 

Please note that TSP1 and TC1 are calculated fields.

[George_Johnson]

I was assuming your field names were "x" and "y". Now that I can see the form, it wold be best to convert the code to a document-level function and place it in a document-level JavaScript, so it can be easily called by all of the GM% fields. The function could be:

// Function in a document-level JavaScript

function calcGM_Percent() {

    // Get the name of the field that triggered this script

    var sFN = event.target.name;

    // Determine the row number based on the field name

    var nRow = sFN.match(/\d+$/)[0];

    // Get the field values, as strings

    var sV1 = getField("TSP" + nRow).valueAsString;

    var sV2 = getField("TC" + nRow).valueAsString;

    // Convert the string values to numbers

    var nV1 = +sV1;

    var nV2 = +sV2;

    if (sV1 && sV2 && nV1 !== 0) {

        event.value = 1 - nV2 / nV1;

    } else {

        event.value = "";

    }

}

And the custom calculation script of each GM% field would simply be:

// Custom calculation script

calcGM_Percent();

If you don't know how to create a document-level JavaScript and add a function to it, post again.

[wwagner1]

I do not know how to do so. 

[George_Johnson]

OK, which version of Acrobat are you using? In Acrobat DC, you'd select:

Tools > JavaScript

and then in the new toolbar that appears, select: Document JavaScripts

When the "Document JavaScript" window appears, add a Script Name, something like "calculate" and click the Add... button.

A new window will open and you will see an empty function, which you should delete. Then copy & paste the "calcGM_Percent" function that I showed above. Close the code window and then press the Close button if the Document JavaScript window. You've now added a document-level JavaScript with the function that can be called by each of the MC% fields as mentioned previously.

[wwagner1]

I'm using Acrobat XI. 

In regards to the formula from earlier, is it as simple as a copy and paste?

[George_Johnson]

In Acrobat 11 you'd start by selecting: Tools > JavaScript > Document JavaScripts

It could be that you don't see "JavaScript" listed in the Tools panel, in which case you'll have to select that small button in the upper-right of the Tools panel and make sure JavaScript is checked in the list of options. The rest of the instructions I provided above are the same.

Regarding the function, yes, you can copy and paste. Here it is again for clarity:

// Function in a document-level JavaScript

function calcGM_Percent() {

    // Get the name of the field that triggered this script

    var sFN = event.target.name;

    // Determine the row number based on the field name

    var nRow = sFN.match(/\d+$/)[0];

    // Get the field values, as strings

    var sV1 = getField("TSP" + nRow).valueAsString;

    var sV2 = getField("TC" + nRow).valueAsString;

    // Convert the string values to numbers

    var nV1 = +sV1;

    var nV2 = +sV2;

    if (sV1 && sV2 && nV1 !== 0) {

        event.value = 1 - nV2 / nV1;

    } else {

        event.value = "";

    }

}

[wwagner1]

I'm afraid that I don't see what you have described once I add Javascript to the tools menu.  My screen shows "Set Document Actions" and when I click on it it shows the below screen.  I really appreciate your time and I hate to keep going back and forth on this.  If I'm not doing something correctly I won't be surprised and I may just change my calculation from GM% to GM dollars and use a simple subtraction formula.

[George_Johnson · Accepted solution]

Are you using Acrobat Standard or Acrobat Pro? Acrobat Standard doesn't allow you to add document-level JavaScripts, unfortunately.

[wwagner1]

It is standard, thus the problem.  Thank you for your assistance.

[George_Johnson]

There is an alternative. With Standard you can set up a Page Open JavaScript that executes when the initial page is opened. The script can be:

// Page Open script

if (typeof this.calcGM_Percent === "undefined") {

this.calcGM_Percent = function {

    // Get the name of the field that triggered this script

    var sFN = event.target.name;

    // Determine the row number based on the field name

    var nRow = sFN.match(/\d+$/)[0];

    // Get the field values, as strings

    var sV1 = getField("TSP" + nRow).valueAsString;

    var sV2 = getField("TC" + nRow).valueAsString;

    // Convert the string values to numbers

    var nV1 = +sV1;

    var nV2 = +sV2;

    if (sV1 && sV2 && nV1 !== 0) {

        event.value = 1 - nV2 / nV1;

    } else {

        event.value = "";

    }

}

and you can call this function in the calculate events of the percent fields as shown before.

To add a page open script, first open the Pages panel on the left, right-click the initial page, select Page Properties, and then select the Actions tab. Add a new Page Open JavaScript that's what's shown above.