I am surprised when you say that this code causes you no issues in production. It has errors, some of which are serious.
To start with, group and indent your code for easy maintenance. Then correct it for the following:
in the main page:
1) the initial if-then-else block, which is incorrect. It goes like this: if...elseif...elseif...endif...else.
2) the abundant and unnecessary use of the # symbol.
3) an 'and' operator is possible in your code, without a 'where' clause.
4) the abundant and unnecessary use of <cfoutput>. For example, at the point where you include serviceseditform.cfm you actually enclose code within 3 cfoutput tags. For, the main page is enclosed by the tag. Plus, the cfinclude tag is also enclosed by the tag. Plus, the code in serviceseditform.cfm is enclosed in cfoutput. Just one cfoutput tag would have been enough.
5) lines of code within the cfAjaxImport tag. Remove them.
6) the if-then-else check for form.CalledMe is incorrect.
7) the if-else check for getserv.COPIED is incorrect.
8) a set of tags, <Cfelse>, </CFIF>, after the loop, with no corresponding <cfif>.
9) avoid double use of cfajaximport in the main page as well as in the included page.
serviceseditform.cfm:
10) delete redundant 'else' statements.
After correction, you should have something like
main page:
<cfajaximport tags="CFINPUT-DATEFIELD, CFAJAXPROXY, CFINPUT-AUTOSUGGEST, CFPOD, CFTOOLTIP, CFSPRYDATASET-JSON,
CFTEXTAREA, CFDIV, CFLAYOUT-TAB, CFFORM ">
<cfprocessingdirective suppresswhitespace="yes">
<cfif isdefined("form.LTCProgram") and getplan.Program_Area eq form.LTCProgram>
<CFQUERY NAME="getServiceGroup" DATASOURCE="#this.datasource#">
SELECT *
FROM Type1
<cfif getplan.specialprogramcode NEQ "">
Where Type1.specialprogramcode like '%#getplan.specialprogramcode#%'
and Active = '1'
<cfelseif form.LTCProgram NEQ "">
Where Type1.specialprogramcode like '%#form.LTCProgram#%'
and Active = '1'
</cfif>
order by servicedescription asc
</CFQUERY>
<cfelseif isdefined("form.LTCProgram") and getplan.Program_Area neq form.LTCProgram>
<CFQUERY NAME="getServiceGroup" DATASOURCE="#this.datasource#">
SELECT *
FROM Type1
<cfif getplan.specialprogramcode NEQ "">
Where Type1.specialprogramcode like '%#getplan.specialprogramcode#%'
and Active = '1'
<cfelseif form.LTCProgram NEQ "">
Where Type1.specialprogramcode like '%#form.LTCProgram#%'
and Active = '1'
</cfif>
order by servicedescription asc
</CFQUERY>
<cfelseif NOT isdefined("form.LTCProgram")>
<cfparam name="form.LTCProgram" default="0">
<CFQUERY NAME="getServiceGroup" DATASOURCE="#this.datasource#">
SELECT *
FROM Type1
<cfif getplan.specialprogramcode NEQ "">
Where Type1.specialprogramcode like '%#getplan.specialprogramcode#%'
and Active = '1'
</cfif>
order by servicedescription asc
</CFQUERY>
<cfelseif form.LTCProgram EQ "">
You have an error ARea
<cfabort>
</cfif>
<CFQUERY NAME="getserv" DATASOURCE="#this.datasource#">
SELECT *
FROM serv
WHERE (unique_index = '#Session.ULTC1002.ID#'
AND EVENT_NUMBER = '#Session.ULTC1002.evt#'
and HCBSBENID = '#form.HCBSBenID#')
</CFQUERY>
<CFQUERY NAME="getSPHCBSNumber" DATASOURCE="#this.datasource#">
SELECT MAX(HCBSBENID) as maxEventNumber
FROM serv
WHERE (unique_index = '#Session.ULTC1002.ID#'
AND EVENT_NUMBER = '#Session.ULTC1002.evt#')
</CFQUERY>
<cfif isNumeric(getSPHCBSNumber.maxEventNumber) and getSPHCBSNumber.maxEventNumber GTE 0>
<cfset ServiceHCBSID = getSPHCBSNumber.maxEventNumber + 1>
<cfelse>
<cfset ServiceHCBSID = 1>
</cfif>
<CFIF getserv.RecordCount NEQ 0>
<cfloop QUERY="getserv">
<CFSET Columns="UNIQUE_INDEX">
<CFSET Values="'"& Session.Ultc1002.ID & "'">
<CFSET Columns=LISTAPPEND(Columns, "HCBSBenID")>
<CFSET Values=LISTAPPEND(Values, "'" & ServiceHCBSID & "'")>
<CFSET Columns=LISTAPPEND(Columns, "Event_Number")>
<CFSET Values=LISTAPPEND(Values, Session.ULTC1002.evt)>
<CFIF getserv.HCBSSERVICEID neq "">
<CFSET Columns=LISTAPPEND(Columns,"HCBSSERVICEID")>
<CFSET Values=LISTAPPEND(Values, "'" & getserv.HCBSSERVICEID & "'")>
</CFIF>
<CFIF getserv.HCBSPROVIDERAVAILABLE neq "">
<CFSET Columns=LISTAPPEND(Columns,"HCBSPROVIDERAVAILABLE")>
<CFSET Values=LISTAPPEND(Values, "'" & getserv.HCBSPROVIDERAVAILABLE & "'")>
</CFIF>
<CFIF getserv.NewProviderRequested neq "">
<CFSET Columns=LISTAPPEND(Columns,"NewProviderRequested")>
<CFSET Values=LISTAPPEND(Values, "'" & getserv.NewProviderRequested & "'")>
</CFIF>
<CFIF getserv.PROVIDER neq "">
<CFSET Columns=LISTAPPEND(Columns,"PROVIDER")>
<CFSET Values=LISTAPPEND(Values, "'" & getserv.PROVIDER & "'")>
</CFIF>
<CFIF getserv.HCBSSERVICESTARTDATE neq "">
<CFSET Columns=LISTAPPEND(Columns,"HCBSSERVICESTARTDATE")>
<CFSET Values=LISTAPPEND(Values, "'" & DATEFORMAT(getserv.HCBSSERVICESTARTDATE, "mm/dd/yyyy") & "'")>
</CFIF>
<CFIF getserv.HCBSSERVICEENDDATE neq "">
<CFSET Columns=LISTAPPEND(Columns,"HCBSSERVICEENDDATE")>
<CFSET Values=LISTAPPEND(Values, "'" & DATEFORMAT(getserv.HCBSSERVICEENDDATE, "mm/dd/yyyy") & "'")>
</CFIF>
<CFIF getserv.Row1Value1 neq "">
<CFSET Columns=LISTAPPEND(Columns,"Row1Value1")>
<CFSET Values=LISTAPPEND(Values, "'" & getserv.Row1Value1# & "'")>
</CFIF>
<CFIF getserv.Row1Description1 neq "">
<CFSET Columns=LISTAPPEND(Columns,"Row1Description1")>
<CFSET Values=LISTAPPEND(Values, "'" & getserv.Row1Description1 & "'")>
</CFIF>
<CFIF getserv.Row1Value2 neq "">
<CFSET Columns=LISTAPPEND(Columns,"Row1Value2")>
<CFSET Values=LISTAPPEND(Values, "'" & getserv.Row1Value2 & "'")>
</CFIF>
<CFIF getserv.Row1Description2 neq "">
<CFSET Columns=LISTAPPEND(Columns,"Row1Description2")>
<CFSET Values=LISTAPPEND(Values, "'" & getserv.Row1Description2 & "'")>
</CFIF>
<CFIF getserv.Row1Value3 neq "">
<CFSET Columns=LISTAPPEND(Columns,"Row1Value3")>
<CFSET Values=LISTAPPEND(Values, "'" & getserv.Row1Value3 & "'")>
</CFIF>
<CFIF getserv.Row1Description3 neq "">
<CFSET Columns=LISTAPPEND(Columns,"Row1Description3")>
<CFSET Values=LISTAPPEND(Values, "'" & getserv.Row1Description3 & "'")>
</CFIF>
<CFIF getserv.Row2Value1 neq "">
<CFSET Columns=LISTAPPEND(Columns,"Row2Value1")>
<CFSET Values=LISTAPPEND(Values, "'" & getserv.Row2Value1 & "'")>
</CFIF>
<CFIF getserv.Row2Description1 neq "">
<CFSET Columns=LISTAPPEND(Columns,"Row2Description1")>
<CFSET Values=LISTAPPEND(Values, "'" & getserv.Row2Description1 & "'")>
</CFIF>
<CFIF getserv.Row2Value2 neq "">
<CFSET Columns=LISTAPPEND(Columns,"Row2Value2")>
<CFSET Values=LISTAPPEND(Values, "'" & getserv.Row2Value2 & "'")>
</CFIF>
<CFIF getserv.Row2Description2 neq "">
<CFSET Columns=LISTAPPEND(Columns,"Row2Description2")>
<CFSET Values=LISTAPPEND(Values, "'" & getserv.Row2Description2 & "'")>
</CFIF>
<CFIF getserv.Row3Value1 neq "">
<CFSET Columns=LISTAPPEND(Columns,"Row3Value1")>
<CFSET Values=LISTAPPEND(Values, "'" & getserv.Row3Value1 & "'")>
</CFIF>
<CFIF getserv.Row3Description1 neq "">
<CFSET Columns=LISTAPPEND(Columns,"Row3Description1")>
<CFSET Values=LISTAPPEND(Values, "'" & getserv.Row3Description1 & "'")>
</CFIF>
<CFIF getserv.Row3Value2 neq "">
<CFSET Columns=LISTAPPEND(Columns,"Row3Value2")>
<CFSET Values=LISTAPPEND(Values, "'" & getserv.Row3Value2 & "'")>
</CFIF>
<CFIF getserv.Row3Description2 neq "">
<CFSET Columns=LISTAPPEND(Columns,"Row3Description2")>
<CFSET Values=LISTAPPEND(Values, "'" & getserv.Row3Description2 & "'")>
</CFIF>
<CFIF getserv.Row4Value1 neq "">
<CFSET Columns=LISTAPPEND(Columns,"Row4Value1")>
<CFSET Values=LISTAPPEND(Values, "'" & getserv.Row4Value1 & "'")>
</CFIF>
<CFIF getserv.Row4Description1 neq "">
<CFSET Columns=LISTAPPEND(Columns,"Row4Description1")>
<CFSET Values=LISTAPPEND(Values, "'" & getserv.Row4Description1 & "'")>
</CFIF>
<CFIF getserv.TotalCost neq "">
<CFSET Columns=LISTAPPEND(Columns,"TotalCost")>
<CFSET Values=LISTAPPEND(Values, "'" & getserv.TotalCost & "'")>
</CFIF>
<CFIF getserv.TOTALUNITSCALCULATED neq "">
<CFSET Columns=LISTAPPEND(Columns,"TOTALUNITSCALCULATED")>
<CFSET Values=LISTAPPEND(Values, "'" & getserv.TOTALUNITSCALCULATED & "'")>
</CFIF>
<CFIF getserv.HCBSSERVICEGOAL neq "">
<CFSET Columns=LISTAPPEND(Columns,"HCBSSERVICEGOAL")>
<CFSET Values=LISTAPPEND(Values, "'" & Replace(getserv.HCBSSERVICEGOAL, "'", "`", "ALL") & "'")>
</CFIF>
<CFIF getserv.HCBSSERVICEGOALTYPE neq "">
<CFSET Columns=LISTAPPEND(Columns,"HCBSSERVICEGOALTYPE")>
<CFSET Values=LISTAPPEND(Values, "'" & getserv.HCBSSERVICEGOALTYPE & "'")>
</CFIF>
<CFIF getserv.CALCULATEDROW neq "">
<CFSET Columns=LISTAPPEND(Columns,"CALCULATEDROW")>
<CFSET Values=LISTAPPEND(Values, "'" & getserv.CALCULATEDROW & "'")>
</CFIF>
<CFIF getserv.HCBSPROVIDERNOTAVAILABLEREASON neq "">
<CFSET Columns=LISTAPPEND(Columns,"HCBSPROVIDERNOTAVAILABLEREASON")>
<CFSET Values=LISTAPPEND(Values, "'" & getserv.HCBSPROVIDERNOTAVAILABLEREASON & "'")>
</CFIF>
<CFIF getserv.ITEMDESCRIPTION neq "">
<CFSET Columns=LISTAPPEND(Columns,"ITEMDESCRIPTION")>
<CFSET Values=LISTAPPEND(Values, "'" & getserv.ITEMDESCRIPTION & "'")>
</CFIF>
<CFIF getserv.COPIED eq "">
<CFSET Columns=LISTAPPEND(Columns,"COPIED")>
<CFSET Values=LISTAPPEND(Values,"COPIED = Null")>
</CFIF>
<cfif Trim(getplan.event_type) eq 'REV' OR Trim(getplan.event_type) eq '6Mon' OR Trim
(getplan.event_type) eq 'DI' OR Trim(getplan.event_type) eq 'UNAS'>
<CFIF getserv.RevReason neq "">
<CFSET Columns=LISTAPPEND(Columns,"RevReason")>
<CFSET Values=LISTAPPEND(Values, "'" & getserv.RevReason & "'")>
</CFIF>
<CFIF getserv.RevDate neq "">
<CFSET Columns=LISTAPPEND(Columns,"RevDate")>
<CFSET Values=LISTAPPEND(Values, "'" & DateFormat(getserv.RevDate,"mm/dd/yyyy") & "'")>
</CFIF>
<CFELSEif Trim(getplan.event_type) eq 'REV' OR Trim(getplan.event_type) eq '6Mon' OR Trim
(getplan.event_type) eq 'DI' OR Trim(getplan.event_type) eq 'UNAS'>
<CFIF getserv.RevReason neq "">
<CFSET Columns=LISTAPPEND(Columns,"RevReason")>
<CFSET Values=LISTAPPEND(Values,"RevReason = Null")>
</CFIF>
<CFIF getserv.RevDate neq "">
<CFSET Columns=LISTAPPEND(Columns,"RevDate")>
<CFSET Values=LISTAPPEND(Values,"RevDate = Null")>
</CFIF>
</CFIF>
<CFIF Values neq "">
<CFQUERY NAME="AddHCBSServices" DATASOURCE="#this.datasource#">
Insert into serv
(#Columns#)
Values (#Preservesinglequotes(values)#)
</CFQUERY>
<CFQUERY NAME="UpdateHCBSServices" DATASOURCE="#this.datasource#">
Update serv
Set Revised = '1'
WHERE (unique_index = '#Session.ULTC1002.ID#'
AND EVENT_NUMBER = '#Session.ULTC1002.evt#'
AND HCBSBENID = '#ServiceHCBSID#')
</CFQUERY>
<cfset form.HCBSBenID = '#ServiceHCBSID#'>
<CFQUERY NAME="getserv" DATASOURCE="#this.datasource#">
SELECT *
FROM serv
WHERE (unique_index = '#Session.ULTC1002.ID#'
AND EVENT_NUMBER = '#Session.ULTC1002.evt#'
and HCBSBENID = '#form.HCBSBenID#')
</CFQUERY>
</CFIF>
</CFLOOP>
</CFIF>
<CFQUERY NAME="getServiceGoalType" DATASOURCE="#this.datasource#">
SELECT *
FROM SERVICELISTS
WHERE Group_Name = 'ServiceGoalTypeHCBS'
</CFQUERY>
<CFQUERY NAME="getCL" DATASOURCE="#this.datasource#">
Select * from CL
where unique_index = '#Session.Ultc1002.ID#'
</CFQUERY>
<!---Checks for the CL record. If no CL record sends to CL search--->
<CFIF getCL.RecordCount eq 0>
<cf_errorMessage SentMessage="The record was not found." GoToFile="../CLSearch.cfm">
<CFABORT>
</CFIF>
<cfif isdefined("form.CalledMe") neq '' form.CalledMe eq 'Delete'>
<CFQUERY NAME="getserv" DATASOURCE="#this.datasource#">
DELETE
FROM serv
WHERE (unique_index = '#Session.ULTC1002.ID#'
AND EVENT_NUMBER = '#Session.ULTC1002.evt#'
AND HCBSBENID = '#form.HCBSBenID#')
</CFQUERY>
<cflocation url="spltcservicesgridchange.cfm?calledme=Edit">
</cfif>
<cfset Session.ULTC1002.SPHCBSServiceID = form.HCBSBenID>
<cflayout type="tab" height="650" name="HCBSServicesEdit" tabPosition="top" tabStrip="true" width="750" >
<cflayoutarea bindonload="true"
closable="false"
disabled="false"
inithide="false"
name="LTCServiceNameEdit"
overflow = "auto"
selected="true"
tabTip="text"
title="Service Selection"
align="left" >
<H6>Service</H6>
<cfinclude template="serviceseditform.cfm">
</cflayoutarea>
<cflayoutarea bindonload="false"
closable="false"
disabled="false"
inithide="false"
name="HCBSProviderEdit"
overflow = "auto"
selected="false"
title="Provider"
align="left">
<H6>Provider Information</H6>
<cfparam name="form.HCBSNotAvailableReason" default="0" >
<cfparam name="form.HCBSProviderAvailable" default=" " >
<cfdiv name="myProvider"
value = "#getserv.HCBSProviderAvailable#"
bind="url:sphcbsserviceseditprovider.cfm?myProvider={HCBSProviderAvailable@change}"
bindonload="yes">
</cflayoutarea>
<cflayoutarea bindonload="true"
closable="false"
disabled="false"
inithide="false"
name="HCBSServiceFrequencyEdit"
overflow = "auto"
selected="false"
title="Service Frequency Scope Duration">
<cfdiv bind="url:bindsourceHCBSEdit.cfm?myEdit={LTCService}" bindonload="true">
</cflayoutarea>
</cflayout>
<CFFORM method="post" action="spltcservicesgridchange.cfm?calledme=edit">
<p align="left"><CFINPUT TYPE="Submit" NAME="btnSaveAndContinue" VALUE=" Return to HCBS Services display. ">
</CFFORM>
</cfprocessingdirective>
serviceseditform.cfm:
<cfform name="frmServiceProgEdit" id="frmServiceProgEdit" ACTION="SPltcServicesformeditaction.cfm"
METHOD="post">
<P>Service:<cfinput name="HCBSBenefitEntryID" id="HCBSBenefitEntryID" value="#Session.ULTC1002.SPHCBSServiceID#"
type="hidden">
<CFSELECT NAME="LTCService"
id="LTCService"
required="yes"
selected="#getserv.HCBSServiceID#"
message="Selection Required">
<option>- Select One -</option>
<cfoutput>
<cfloop query="GetServiceGroup">
<cfif getserv.Revised eq '1'>
<cfif GetServiceGroup.ServiceTypeID eq getserv.HCBSServiceID>
<OPTION VALUE="#GetServiceGroup.ServiceTypeID#" selected>
<cfelse>
<OPTION VALUE="#GetServiceGroup.ServiceTypeID#">
</cfif>
#GetServiceGroup.ServiceDescription# - #GetServiceGroup.ProcedureCode#
<cfif GetServiceGroup.Modifier NEQ ''>
, #GetServiceGroup.Modifier#
</cfif>
</option>
<cfelse>
<cfif GetServiceGroup.ServiceTypeID eq getserv.HCBSServiceID>
<OPTION VALUE="#GetServiceGroup.ServiceTypeID#" selected></OPTION>
<cfelse>
<OPTION VALUE="#GetServiceGroup.ServiceTypeID#"></OPTION>
</cfif>
#GetServiceGroup.ServiceDescription# - #GetServiceGroup.ProcedureCode#
<cfif GetServiceGroup.Modifier NEQ ''>
,#GetServiceGroup.Modifier#
</cfif>
</option>
</cfif>
</cfloop>
</cfoutput>
</CFSELECT>
<p>Service Goal Type:<font color="##990000">*</font>
<cfselect name="ServiceGoalType"
id="ServiceGoalType"
required="yes"
message="Required">
<option value="">- Select One -</option>
<cfloop query="getServiceGoalType">
<cfoutput><OPTION VALUE="#getServiceGoalType.ItemValue#" <cfif getServiceGoalType.ItemValue eq getserv.HCBSServiceGoalType>selected</cfif>> #getServiceGoalType.ItemDisplay# </option></cfoutput>
</cfloop>
</CFSELECT>
<P>HCBS service provider available: <font color="##990000">*</font>
<cfparam name="HCBSProviderAvailable" default=" ">
<cfif getserv.HCBSProviderAvailable eq '1'>
<CFINPUT name="HCBSProviderAvailable"
TYPE="radio"
value="#getserv.HCBSProviderAvailable#"
required="yes"
bindonload="no"
bind="url:sphcbsserviceseditprovider.cfm?myProvider={HCBSProviderAvailable@keyup}"
message="Available Required"
checked>Yes
<CFINPUT name="HCBSProviderAvailable"
TYPE="radio"
value="0"
required="yes"
bindonload="no"
bind="url:sphcbsserviceseditprovider.cfm?myProvider={HCBSProviderAvailable@keyup}"
message="Available Required" >No
<cfelseif getserv.HCBSProviderAvailable eq '0'>
<CFINPUT name="HCBSProviderAvailable"
TYPE="radio"
value="1"
required="yes"
bindonload="no"
bind="url:sphcbsserviceseditprovider.cfm?myProvider={HCBSProviderAvailable@keyup}"
message="Provider Available Required">Yes
<CFINPUT name="HCBSProviderAvailable"
TYPE="radio"
value="#getserv.HCBSProviderAvailable#"
required="yes"
bindonload="no"
bind="url:sphcbsserviceseditprovider.cfm?myProvider={HCBSProviderAvailable@keyup}"
message="Available Required"
checked>
</cfif>
<P>Service Goal:
<CFTEXTAREA NAME="Service_Goal" ROWS="20" COLS="80" required="yes" maxlength="5000" message="Goal
Required"><cfoutput>#getserv.HCBSServiceGoal#</cfoutput></CFTEXTAREA>
<P align="center">
<cfinput type="submit" name="Save" value="Save">
</cfform>
13
Replies
AdChoices