I've been able to avoid a lot of similar issues that i used to have by avoiding try/catch blocks actually.. From my perspective, it seems that things in the try block can mess with the application even if they don't cause a runtime error at that moment.. then some or all of the catch block will execute and then down the line the script will attempt to access some object that was corrupted during the try block. Some data will get dumped or lost resulting in an MRAP error when illustrator tries to read the properties of an object.
So what i've done is written some helper functions to replace the getByName() method which in my humble opinion, is a pile of hot garbage. There's no safeguards built into it at all. normal usage of built in methods should never cause runtime errors. ever. but that's what you get from getByName() if the name doesn't exist. So I take advantage of the fact that when working with illustrator documents, the numbers of layers/swatches/graphic styles or even just pageItems on a given layer are typically small enough that we can trade off some speed/efficiency for reliability and predictability.
So, to avoid using try/catch and getByName() all together, i've replaced getByName with something like this:
function findSpecificGraphicStyle(doc,name)
{
var result;
for(var x=0;x<doc.graphicStyles.length && !result;x++)
{
if(doc.graphicStyles[x].name === name)
{
result = doc.graphicStyles[x]
}
}
return result;
}
This is guaranteed to give me either a graphic style object or undefined. No runtime errors. No headaches. I have different functions for different stuff based on my day to day needs, but basically the formula is this:
function findSomething(parentObject,searchTerm,criteria)
{
var result;
for each item/layer in parentObject while result is undefined
if criteria == "match" && item/layer.name === searchTerm
result = item/layer
else if criteria == "imatch" && item/layer.name.toLowerCase() === searchTerm.toLowerCase()
result = item/layer
else if criteria == "any" && item.layer.name.toLowerCase().indexOf(searchTerm.toLowerCase())
result = item/layer
return result
}
I use something like this for every kind of object i might want to find and i just keep the functions in a centralized utilities container script that gets included with all of my other scripts.
I can't say for certain that this is in any way related to the MRAP errors you're getting, but i can say that when i stopped using try/catch to identify layers/objects/swatches... a lot of my issues went away. That certainly didn't happen in a vacuum and there's no way to control for all variables, but i think it's worth thinking about anyway.
11
Replies
AdChoices