Hi Malcolm,
I'll give a brief overview for context before adressing your points more specifically. The aforementiond function is part of a CEP panel that allows the end user to selectively "flatten" any style within the document (or more importantly, many at once). In short this is handled by building an array host side of all the styles, and passing it to the client to in turn populate a series of ul's with checkboxes. The client side array is updated anytime a checkbox is clicked to reflect the checked value, and is passed back to the host when a "flatten" button is clicked so that the host can replace the original array with the new client one and use it to determine which styles are to be removed.
When a flatten button is clicked it triggers a parent function host side and passes it the client array, and a reference for which button was clicked (there are 3 different flatten buttons - preserve checked, flatten checked, and flatten all), and a refernce to which general style type is being requested for deletion (e.g object styles, or paragraph styles).
That parent function contains two functions, one to remove styles, and then this one to remove groups once that has completed.
Like I say, this all works beautifully for everything except character styles, and if I put that alert in just before the remove() groups method it does appear to be working for character styles up until that last group (in the instance of flattening all).
1)The doc object is the active document. I'm using bracket notation so that I can pass variables as properties. The removeGroups function is intended to be reused for all style groups, so doc[stylesgroups] is referencing a variable that is just a string for the property. That variable is defined by a switch statement that evaluates the passed value of the general style type (see below).
2. I've always written recursive functions like that, never really questioned it! My logic being that it's only relevant to that function and so nested there rather than globally.
3. Yes, it is relying on scoping. Maybe the full parent function below will make that more obvious. Not sure it's a problem though?
I've tried a try/catch in various places in the function to no avail, although combined with ID freezing up and requiring a restart make me think that as far as ID is concerned it never meets that catch condition, it's getting stuck in an endless loop somehow?
What baffles me is that it works beautifully for all other styles. It also works for character styles if it is not deleting the last folder - e.g. it finds a group folder that still has style children; not if I change the loop to stop before the last element. It'll error on whatever the last empty folder is regardless of the index.
Here's that parent function in full:
//removes document styles and style folders based on clientList sent back from panel
function styleRemove(clientList, btnId, itemType)
{
newList = JSON.parse(clientList);
//switch recieves id of styleBtn clicked to define document styles to be worked with. e.g paragraph, character, etc
switch(itemType)
{
case "object":
//x defines which top level array to use in later loop
var x = 0;
//defines which doc properties being used
styles = "allObjectStyles";
styleGroups = "objectStyleGroups";
break;
case "table":
//x defines which top level array to use in later loop
var x = 1;
//defines which doc properties being used
styles = "allTableStyles";
styleGroups = "tableStyleGroups";
break;
case "cell":
//x defines which top level array to use in later loop
var x = 2;
//defines which doc properties being used
styles = "allCellStyles";
styleGroups = "cellStyleGroups";
break;
case "paragraph":
//x defines which top level array to use in later loop
var x = 3;
//defines which doc properties being used
styles = "allParagraphStyles";
styleGroups = "paragraphStyleGroups";
break;
case "character":
//x defines which top level array to use in later loop
var x = 4;
//defines which doc properties being used
styles = "allCharacterStyles";
styleGroups = "characterStyleGroups";
break;
};
//switch evalutes btnID to define what style type to work with, then loops through clientList delivered from client and evaluates each checked value, removing host style as appropriate
switch(btnId)
{
case "preserve":
var check = false;
removeStyles(check, newList, styles);
break;
case "flatten":
var check = true;
removeStyles(check, newList, styles);
break;
};
function removeStyles(check, newList, styles)
{
for(i=doc[styles].length-1;i>=0;i--)
{
var clientItem = newList[x].arr[i];
var hostItem = doc[styles][i];
try
{
if(clientItem.checked === check)
{
hostItem.remove();
}
}
catch(e)
{
}
}
removeGroups();
};
function removeGroups()
{
var styleGroup;
for (var p=doc[styleGroups].length-1; p>=1; p--)
{
checkForGroups(doc[styleGroups][p]);
}
function checkForGroups(styleGroup)
{
if (styleGroup[styles].length == 0)
{
try
{
styleGroup.remove();
}
catch (e)
{
alert("errored on: " + p + g);
}
}
else if (styleGroup[styleGroups].length > 0)
{
for (var g=styleGroup[styleGroups].length-1; g>=0; g--)
{
checkForGroups(styleGroup[styleGroups][g]);
}
}
}
}
}
1 Correct answer
14
Replies
AdChoices