Undo/Redo affecting too many steps after applying settings via SDK "ModalDialog"

[C.Cella]

Steps to Reproduce
Change the attached script bugUndo from .txt to .lua

0. Go in Develop Module
1. Run the attached scrip and in the dialog :

2. Click "Exposure -4" or "Exposure +4"

3. Wait till the step appears in history.

4.Click "Exposure -4" or "Exposure +4"

5. Wait till the step appears in history.
6. Click the "Undo"

OR after step 5 close the dialog and "Undo"

Both history steps are undone but only one should be undone.
Sometimes when all the history steps are undone the setting changed is not actually undone.
See video.

I definitely wrote something wrong in the UI but I don't know what exactly...feeling very stupid.
Any help would be appreciated.

.

[Sameer K]

Hey, @C.Cella. Thanks for the detailed post. I've looped in @ johnrellis ‎to help speed this up. I'll raise to the team.

Thanks!
Sameer K

[C.Cella]

@Sameer K 

I have written an equivalent but using photo:applyDevelopSettings() to set Exposure
Same issue: Undo/Redo affect all setting applied when the UI was drawn.

• Definitely is my mistake here, but I really don't understand where.
Knowing myself is probably all right under my nose.

.

[drtonyb]

@C.Cella 

This looks like a bug to me.

If you use the script to do +4 Exposure, then -4 Exposure, then close the dialog, using a single Undo from the keyboard or Edit menu to undo the last step actually removes both steps from History.

If you use the script to do +4 Exposure, then close the dialog, then run the script again, do -4 Exposure and close the dialog, then Undo removes only the -4 Exposure step.

For the Adobe Team: Why does using the LrDevelopController.setValue() function take so long for the adjustment to appear in History?

[C.Cella]

@drtonyb LrDevelopController has a default 2 seconds delay before changes (of the same setting) are written in history.

It can be set to a shorter delay by using  LrDevelopController.setTrackingDelay() 

See video.
In the video as well I end up undoing all stpes and even if the step highlighted is the "Reset Settings" the Exposure is still set to -4

Choosing an earlier step and going back to step "Reset Settings" clears the wrong setting.

@johnrellis using the built in "Undo and Redo" in your "Adjust Crop"  modal window I can "Undo" no issues.
So I think I wrote the Ui wrong.

[C.Cella]

After weeks still no reply from the team.