Really annoying bug. I spend 10 minutes going through my list of fonts in Photoshop, clicking the star next to fonts I want to remember as "favorites". Many of these fonts are installed via fonts.adobe.com.
But Photoshop keeps turning off the "favorite" star for many (but not all) of my font selections. I think I've figured out the cause: If I start Photoshop shortly after logging in, before the Adobe Creative Cloud magic has had time to activate all my fonts, the fonts that are not yet activated don't exist yet (as far as Photoshop is concerned), and they lose their "favorite" star.
Once the star is turned off by this bug, it stays off until I go back into Photoshop (after the fonts have all been loaded) and turn the star back on again.