script to make layer visible + prompt not working

[Andrea_B42]

hey everyone,

really new to scripting, I'm running into an issue I can't really understand.

I have a fairly simple script to be ran when saving an image, it basically just makes an adjustment layer visible then asks for a prompt to continue.

The problem I'm running into is that I can see the script working through all the steps correctly, but the prompt pops up without the adjustment layer actually being visible on screen (even though I can see it has been checked properly as visible). If I stop the script then the layer is turned on as per the script.

What am I doing wrong? I tried to add an 'app.refresh()' in between and it seems to be working as intended, but it slows down the whole thing way too much.

function saveChecks() {

app.activeDocument.layerSets["HELP"].layers["Solar Curves"].visible = true;

app.runMenuItem(app.charIDToTypeID("FtOn"));

saveState = confirm ('all good to go?');
}

Thanks in advance

[Stephen_A_Marsh]

---

@Andrea_B42 wrote:

The problem I'm running into is that I can see the script working through all the steps correctly, but the prompt pops up without the adjustment layer actually being visible on screen (even though I can see it has been checked properly as visible). If I stop the script then the layer is turned on as per the script.

This appears to work as expected and as you describe in my test. If the named layer set's adjustment layer view was off/invisible, then the layer is made visible.

[Andrea_B42]

yes sorry, maybe I didn't explain myself super well.

The script is doind what is supposed to, however the UI doesn't refresh to reflect the applied curve when the prompt pops up.

adding app.refresh() somewhat solves it, but it makes it way too slow to respond so it's not really a viable solution.

I did find the WaitForRedraw() 'hack' while looking around but even that one is a little slower than I would like, so I was wondering if there's something else I could try.

Thanks for your input!

[jazz-y · Accepted solution]

function saveChecks() {
app.activeDocument.layerSets["HELP"].layers["Solar Curves"].visible = true;
app.runMenuItem(app.charIDToTypeID("FtOn"));
app.refresh();
saveState = confirm ('all good to go?');
}

[Andrea_B42]

Thanks!

I did try that but it makes the script way too slow to respond, so I was wondering if there was anything quicker I could try.

I also found the handy WaitForRedraw() snippet which is somewhat better but even there, I'd like something slightly faster, I'm just not sure it's possible!

Thanks anyway 🙂

[Stephen_A_Marsh]

---

@Andrea_B42 wrote:

yes sorry, maybe I didn't explain myself super well.

---

GIGO...

How does this compare?

saveChecks();

function saveChecks() {
    app.activeDocument.layerSets["HELP"].layers["Solar Curves"].visible = true;
    app.runMenuItem(app.charIDToTypeID("FtOn"));
    app.activeDocument.activeLayer = app.activeDocument.layers[0];
    makeFill(255, 255, 255);
    activeDocument.activeLayer.remove();
    saveState = confirm('all good to go?');
}

    function makeFill(red, Grn, blue) {
        var c2t = function (s) {
            return app.charIDToTypeID(s);
        };

        var s2t = function (s) {
            return app.stringIDToTypeID(s);
        };
        var descriptor = new ActionDescriptor();
        var descriptor2 = new ActionDescriptor();
        var descriptor3 = new ActionDescriptor();
        var descriptor4 = new ActionDescriptor();
        var reference = new ActionReference();
        reference.putClass(s2t("contentLayer"));
        descriptor.putReference(c2t("null"), reference);
        descriptor4.putDouble(s2t("red"), red);
        descriptor4.putDouble(c2t("Grn "), Grn);
        descriptor4.putDouble(s2t("blue"), blue);
        descriptor3.putObject(s2t("color"), s2t("RGBColor"), descriptor4);
        descriptor2.putObject(s2t("type"), s2t("solidColorLayer"), descriptor3);
        descriptor.putObject(s2t("using"), s2t("contentLayer"), descriptor2);
        executeAction(s2t("make"), descriptor, DialogModes.NO);
    }

[r-bin]

Can not reproduce. But try the Step-by-Step mode ...