That appears to have worked. Thank you both. femkeblanco, I was moving each item one at a time as I came across them for a color check. When I had the issue deleting the layers I thought it was a timing issue, first thought was if I could move all items at once then remove layers may help with the timing. So I collected all pageItems by color into an array, grouped them, then moved them to the layer created. Code, its messy right now but it works with the backwards iteration. If you all know of a way to do this efficently please let me know. //@include "../utils/json2.jsx"
doc = app.activeDocument
drillBoxes()
function drillBoxes(){
allPageItems = filterPageItems()
seps = seprateItems(allPageItems)
moveToLayer(seps)
removeEmptyLayers(doc.layers)
}
function addToGroup(arr){
groupCollect = doc.groupItems.add()
for(i=0; i<arr.length; i++){
arr[i].move(groupCollect, ElementPlacement.PLACEATBEGINNING)
}
return groupCollect
}
function moveToLayer(sepObj, callback){
for(y=0; y < sepObj.colors; y++){
nGroup = addToGroup(seps[seps.colornames[y]])
nGroup.move(doc.layers[seps.colornames[y]], ElementPlacement.PLACEATBEGINNING)
}
}
function seprateItems(allPageItems){
//Move all items at once?
createdLayers = {}
createdLayers['colors'] = 0
createdLayers['colornames'] = []
len = allPageItems.length
for(z=0; z < len; z++){
j = allPageItems[z].length - 1
while(j >= 0){
currItem = allPageItems[z][j]
if(currItem.typename === 'CompoundPathItem'){
if(currItem.pathItems.length){
if(currItem.pathItems[0].filled){
currColor = currItem.pathItems[0].fillColor
}else{
currColor = currItem.pathItems[0].strokeColor
}
if(currColor.constructor.name === 'SpotColor'){
if(currColor.spot.name === '[Registration]'){
currItem.remove()
j--
continue
}
if(createdLayers[currColor.spot.name + 'color']){
createdLayers[currColor.spot.name].push(currItem)
}else{
addLayer(currColor.spot.name, [50, 50, 50])
doc.layers[currColor.spot.name].zOrder(ZOrderMethod.SENDTOBACK)
createdLayers[currColor.spot.name] = []
createdLayers[currColor.spot.name].push(currItem)
createdLayers['colors'] += 1
createdLayers['colornames'].push(currColor.spot.name)
createdLayers[currColor.spot.name + 'color'] = true
}
}else{
currItem.remove()
}
}else{
curItem.remove()
j--
continue
}
}else{
if(currItem.fillColor.constructor.name === 'SpotColor' || currItem.strokeColor.constructor.name === 'SpotColor'){
if(currItem.filled){
currColor = currItem.fillColor
}else{
currColor = currItem.strokeColor
}
if(currColor.spot.name === '[Registration]'){
currItem.remove()
j--
continue
}
if(createdLayers[currColor.spot.name + 'color']){
createdLayers[currColor.spot.name].push(currItem)
}else{
addLayer(currColor.spot.name, [50, 50, 50])
doc.layers[currColor.spot.name].zOrder(ZOrderMethod.SENDTOBACK)
createdLayers[currColor.spot.name] = []
createdLayers[currColor.spot.name].push(currItem)
createdLayers['colors'] += 1
createdLayers['colornames'].push(currColor.spot.name)
createdLayers[currColor.spot.name + 'color'] = true
}
}else{
currItem.remove()
}
}
j--
}
}
return createdLayers
callback()
}
function filterPageItems(){
collect = []
docLayers = doc.layers
for(i=0; i < docLayers.length; i++){
currLayer = docLayers[i]
returnArr = []
collectedPageItems = pageItemCustomRecursive(currLayer, returnArr)
collect.push(collectedPageItems)
}
// cleanCollect = twoDeArraytoOneDe(collect)
return collect
}
function pageItemCustomRecursive(parent, returnItems){
if(parent.typename == "Layer" && parent.layers.length > 0){
var layers = parent.layers
for( var i = 0; i < layers.length; i++ ) {
var subLayer = layers[i]
pageItemRecursive(subLayer, returnItems)
}
}
var items = parent.pageItems
for( var j = 0; j < items.length; j++ ){
var curItem = items[j]
if(curItem.typename == "GroupItem"){
pageItemRecursive(curItem, returnItems)
}else if(curItem.typename == "MeshItem" || "PlacedItem" || "SymbolItem" || "RasterItem" || "NonNativeItem" || "PluginItem" || "PathItem" || "CompoundPathItem"){
returnItems.push(curItem)
}
}
return returnItems
}
function removeEmptyLayers(arr){
$.writeln(arr)
app.redraw()
for(i=arr.length-1; i >= 0; i--){
$.writeln(arr[i])
if(arr[i].pageItems.length === 0){
arr[i].remove()
}else{
$.writeln(arr[i])
continue
}
}
} function addLayer(name, rgbColors){
if (rgbColors === undefined){rgbColors = [255, 0, 255]}
var cont = true;
function change() {
cont = !cont;
}
for(i = 0; i < app.activeDocument.layers.length; i++){
if(app.activeDocument.layers[i].name == name){
change();
}
}
if (cont == true) {
var newColor = new RGBColor();
newColor.red = rgbColors[0];
newColor.green = rgbColors[1];
newColor.blue = rgbColors[2];
var newLayer = app.activeDocument.layers.add();
newLayer.name = name;
newLayer.color = newColor;
}
app.activeDocument.layers[name].visibile = true
app.activeDocument.layers[name].locked = false
app.activeDocument.activeLayer = app.activeDocument.layers.getByName(name);
} Also using this function from another file
... View more
AdChoices