Making Tetris, Need help with code
I've been working on making Tetris with AS3 by following a tutorial (https://www.emanueleferonato.com/2011/05/02/creation-of-a-complete-flash-tetris-game/). I have all of the code completed, and it is filled with bugs and i don't know how to fix them. I labeled the lines that the Debug menu said there were problems with "//problem here".
Here is the code i have now:
package {
import flash.display.Sprite;
import flash.utils.Timer;
import flash.events.TimerEvent;
import flash.events.KeyboardEvent;
public class Main extends Sprite {
private const TS: uint = 24;
private var fieldArray: Array;
private var fieldSprite: Sprite;
private var tetrominoes: Array = new Array();
private var colors: Array = new Array();
private var tetromino: Sprite;
private var currentTetromino: uint;
private var nextTetromino: uint;
private var side: uint;
private var tRow: int;
private var tCol: int;
private var timeCount: Timer = new Timer(500);
private var gameOver: Boolean = false;
private var FIELD_WIDTH: int = 10;
private var FIELD_HEIGHT: int = 20;
public function Main() {
generateField();
initTetrominoes();
nextTetromino = Math.floor(Math.random() * 7);
generateTetromino();
stage.addEventListener(KeyboardEvent.KEY_DOWN, onKDown);
}
private function generateField(): void {
var colors: Array = new Array("0x0003B8", "0x0003D0");
fieldArray = new Array;
var fieldSprite: Sprite = new Sprite;
addChild(fieldSprite);
fieldSprite.graphics.lineStyle(0, 0x000000);
for (var i: uint = 0; i < FIELD_HEIGHT; i++) {
fieldArray = new Array;
for (var j: uint = 0; j < FIELD_WIDTH; j++) {
fieldArray
fieldSprite.graphics.beginFill(colors[(j % 2 + i % 2) % 2]);
fieldSprite.graphics.drawRect(TS * j, TS * i, TS, TS);
fieldSprite.graphics.endFill();
}
}
}
private function initTetrominoes(): void {
// I
tetrominoes[0] = [
[
[0, 0, 0, 0],
[1, 1, 1, 1],
[0, 0, 0, 0],
[0, 0, 0, 0]
],
[
[0, 1, 0, 0],
[0, 1, 0, 0],
[0, 1, 0, 0],
[0, 1, 0, 0]
]
];
colors[0] = 0x00FFFF;
// T
tetrominoes[1] = [
[
[0, 0, 0, 0],
[1, 1, 1, 0],
[0, 1, 0, 0],
[0, 0, 0, 0]
],
[
[0, 1, 0, 0],
[1, 1, 0, 0],
[0, 1, 0, 0],
[0, 0, 0, 0]
],
[
[0, 1, 0, 0],
[1, 1, 1, 0],
[0, 0, 0, 0],
[0, 0, 0, 0]
],
[
[0, 1, 0, 0],
[0, 1, 1, 0],
[0, 1, 0, 0],
[0, 0, 0, 0]
]
];
colors[1] = 0xAA00FF;
// L
tetrominoes[2] = [
[
[0, 0, 0, 0],
[1, 1, 1, 0],
[1, 0, 0, 0],
[0, 0, 0, 0]
],
[
[1, 1, 0, 0],
[0, 1, 0, 0],
[0, 1, 0, 0],
[0, 0, 0, 0]
],
[
[0, 0, 1, 0],
[1, 1, 1, 0],
[0, 0, 0, 0],
[0, 0, 0, 0]
],
[
[0, 1, 0, 0],
[0, 1, 0, 0],
[0, 1, 1, 0],
[0, 0, 0, 0]
]
];
colors[2] = 0xFFA500;
// J
tetrominoes[3] = [
[
[1, 0, 0, 0],
[1, 1, 1, 0],
[0, 0, 0, 0],
[0, 0, 0, 0]
],
[
[0, 1, 1, 0],
[0, 1, 0, 0],
[0, 1, 0, 0],
[0, 0, 0, 0]
],
[
[0, 0, 0, 0],
[1, 1, 1, 0],
[0, 0, 1, 0],
[0, 0, 0, 0]
],
[
[0, 1, 0, 0],
[0, 1, 0, 0],
[1, 1, 0, 0],
[0, 0, 0, 0]
]
];
colors[3] = 0x0000FF;
// Z
tetrominoes[4] = [
[
[0, 0, 0, 0],
[1, 1, 0, 0],
[0, 1, 1, 0],
[0, 0, 0, 0]
],
[
[0, 0, 1, 0],
[0, 1, 1, 0],
[0, 1, 0, 0],
[0, 0, 0, 0]
]
];
colors[4] = 0xFF0000;
// S
tetrominoes[5] = [
[
[0, 0, 0, 0],
[0, 1, 1, 0],
[1, 1, 0, 0],
[0, 0, 0, 0]
],
[
[0, 1, 0, 0],
[0, 1, 1, 0],
[0, 0, 1, 0],
[0, 0, 0, 0]
]
];
colors[5] = 0x00FF00;
// O
tetrominoes[6] = [
[
[0, 1, 1, 0],
[0, 1, 1, 0],
[0, 0, 0, 0],
[0, 0, 0, 0]
]
];
colors[6] = 0xFFFF00;
}
private function generateTetromino(): void {
if (!gameOver) {
currentTetromino = nextTetromino;
nextTetromino = Math.floor(Math.random() * 7);
drawNext();
tRow = 0;
if (tetrominoes[currentTetromino][0][0].indexOf(1) == -1) {
tRow = -1;
}
tCol = 3;
drawTetromino(); //problem here
if (canFit(tRow, tCol, side)) { //problem here
timeCount.addEventListener(TimerEvent.TIMER, onTime);
timeCount.start();
} else {
gameOver = true;
}
}
}
private function drawTetromino(): void {
var ct: uint = currentTetromino;
tetromino = new Sprite;
addChild(tetromino);
tetromino.graphics.lineStyle(0, 0x000000);
for (var i: int = 0; i < tetrominoes[ct][side].length; i++) { //problem here
for (var j: int = 0; j < tetrominoes[ct][side].length; j++) {
if (tetrominoes[ct][side]
tetromino.graphics.beginFill(colors[ct]);
tetromino.graphics.drawRect(TS * j, TS * i, TS, TS);
tetromino.graphics.endFill();
}
}
}
placeTetromino();
}
private function placeTetromino(): void {
tetromino.x = tCol * TS;
tetromino.y = tRow * TS;
}
private function onKDown(e: KeyboardEvent): void {
if (!gameOver) {
switch (e.keyCode) {
case 37:
if (canFit(tRow, tCol - 1, side)) { //problem here
tCol--;
placeTetromino();
}
break;
case 38:
var ct: uint = side;
var rot: uint = ct + 1 % tetrominoes[currentTetromino].length;
if (canFit(tRow, tCol, rot)) { //problem here
side = rot;
removeChild(tetromino);
drawTetromino();
placeTetromino();
}
break;
case 39:
if (canFit(tRow, tCol + 1, side)) { //problem here
tCol++;
placeTetromino();
}
break;
case 40:
if (canFit(tRow + 1, tCol, side)) { //problem here
tRow++;
placeTetromino();
} else {
landTetromino();
generateTetromino(); //problem here
}
break;
}
}
}
private function canFit(row: int, col: int, side: uint): Boolean {
var ct: uint = currentTetromino;
for (var i: int = 0; i < tetrominoes[ct][side].length; i++) { //problem here
for (var j: int = 0; j < tetrominoes[ct][side].length; j++) {
if (tetrominoes[ct][side]
// out of left boundary
if (col + j < 0) {
return false;
}
// out of right boundary
if (col + j > 9) {
return false;
}
// out of bottom boundary
if (row + i > 19) {
return false;
}
// over another tetromino
if (fieldArray[row + i][col + j] == 1) { //problem here
return false;
}
}
}
}
return true;
}
private function landTetromino(): void {
var ct: uint = currentTetromino;
var landed: Sprite;
for (var i: int = 0; i < tetrominoes[ct][side].length; i++) {
for (var j: int = 0; j < tetrominoes[ct][side].length; j++) {
if (tetrominoes[ct][side]
landed = new Sprite;
addChild(landed);
landed.graphics.lineStyle(0, 0x000000);
landed.graphics.beginFill(colors[currentTetromino]);
landed.graphics.drawRect(TS * tCol + j, TS * tRow + i, TS, TS);
landed.graphics.endFill();
landed.name = "r" + tRow + i + "c" + tCol + j;
fieldArray[tRow + i][tCol + j] = 1;
}
}
}
removeChild(tetromino);
timeCount.removeEventListener(TimerEvent.TIMER, onTime);
timeCount.stop();
checkForLines();
}
private function checkForLines(): void {
for (var i: int = 0; i < FIELD_HEIGHT; i++) {
if (fieldArray.indexOf(0) == -1) {
for (var j: int = 0; j < FIELD_WIDTH; j++) {
fieldArray
removeChild(getChildByName("r" + i + "c" + j));
}
for (j = i; j >= 0; j--) {
for (var k: int = 0; k < 10; k++) {
if (fieldArray
fieldArray
fieldArray[j + 1]
getChildByName("r" + j + "c" + k).y += TS;
getChildByName("r" + j + "c" + k).name = "r" + j + 1 + "c" + k;
}
}
}
}
}
}
private function onTime(e: TimerEvent): void {
if (canFit(tRow + 1, tCol, side)) {
tRow++;
placeTetromino();
} else {
landTetromino();
generateTetromino(); //problem here
}
}
private function drawNext(): void {
if (getChildByName("next") != null) {
removeChild(getChildByName("next"));
}
var next_t: Sprite = new Sprite;
next_t.x = 300;
next_t.name = "next";
addChild(next_t);
next_t.graphics.lineStyle(0, 0x000000);
for (var i: int = 0; i < tetrominoes[nextTetromino][0].length; i++) {
for (var j: int = 0; j < tetrominoes[nextTetromino][0].length; j++) {
if (tetrominoes[nextTetromino][0]
next_t.graphics.beginFill(colors[nextTetromino]);
next_t.graphics.drawRect(TS * j, TS * i, TS, TS);
next_t.graphics.endFill();
}
}
}
}
}
}
AdChoices