A

Anonymous

Answered

Avoid Evaluate in this case?

10 replies
870 views
Translate

I am invoking a webservice that returns Java entry arrays for ldap user information.

To display the name from each entry i have this code:

<cfloop index="intIndex" from="0" to="#arraylen(topOfOrg.getEntryArray().getEntry())-1#">
<cfoutput>#directReports.getEntryArray().getEntry(evaluate(intIndex)).getName()#</cfoutput>
</cfloop>

Should i avoid using evaluate in this case? And how could I if it is an option?

Thanks for any thoughts/ideas.

Advanced techniques

This topic is closed to new replies. Start a new post to keep the conversation going.

Correct answer

quote:

Use JavaCast ("int", intIndex) instead of evaluate(intIndex).

Thanks MikerRoo that worked and feels faster.

KC

N

Newsgroup_User

Inspiring

> Use JavaCast ("int", intIndex) instead of evaluate(intIndex).

I'm missing something. Why do you need *either* of those options, instead
of just using intIndex directly? <cfloop> indexes are already Java ints,
aren't they?

--
Adam

Translate

A

Anonymous

quote:

Originally posted by: Newsgroup User
> Use JavaCast ("int", intIndex) instead of evaluate(intIndex).

I'm missing something. Why do you need *either* of those options, instead
of just using intIndex directly? <cfloop> indexes are already Java ints,
aren't they?

--
Adam

First, I give KC the benefit of the doubt -- that he would not use evaluate if he didn't need it.

Second, CF7 to Java seems to do a poor job of reliably passing anything but strings to Java. I've had to cast ints to ints a few times myself -- for no good reason.

Third, the member function getEntry() may be overloaded. Then Javacast is needed so that CF can pick the right function.

Fourth, I heard (but have not tested) that functions with defaulted parameters, like getEntry(), need Javacast!

Finally, JavaCast costs nothing measurable, in the way of performance, to use. If our code looks more complex we get paid more, right? ;-P

Translate

A

Anonymous

Thanks all for the feedback/discussion.

I'm not an expert yet... just graduated with a bachelors in business adminstation with a CIS focus in december. That means i had about 3 programming classes and one web design class that had about 4 weeks on coldfusion. But ever since i was exposed to coldfusion i have enjoyed it. Landed a job after graduation as a web master of a site with coldfusion 5.0 applications.

I recommened a new server and upgrade to coldfusion mx 7. And started redesigning our site and applications. Its been fun and challenging.

This week i had the idea to make a dynamic org chart. Our corporation has a active directoy lookup web service, so I set out to consume it in coldfusion. Took some trial and error but i got consumption to work....

I don't know java well, but the web service documentation said returns java entry array objects. Took some trial and error again to get the data out of the objects once they were returned. But got that working, then i expanded my querie to return multiple arrays within the object so i had to loop over it (i assume this is a resonably efficient way to get at each array).

My original logical line of code was to use:
<cfloop index="intIndex" from="0" to="#arraylen(directReports.getEntryArray().getEntry())-1#">
<cfoutput>#directReports.getEntryArray().getEntry(intIndex).getName()#</cfoutput>
</cfloop>
This code returns this error: "The selected method getEntry was not found."
coldfusion.runtime.java.MethodSelectionException: The selected method getEntry was not found.

In response to that i set evaluate around the intIndex and it worked, but i had read evaulate was a costly operation, so i asked for help here. And got the excellent javacast alternative.

The webservice return variable is directreports, a java object i believe, and it has a method to get to the result set of EntryArray and then each array in the result set has methods to reveal my data. Like name, work phone, job title, etc.

Its a simple application, but everyone loves it so far. Thanks all!

Translate

A

Anonymous

Use JavaCast ("int", intIndex) instead of evaluate(intIndex).

Translate

A

Anonymous

Correct answer

quote:

Use JavaCast ("int", intIndex) instead of evaluate(intIndex).

Thanks MikerRoo that worked and feels faster.

KC

Translate

A

Anonymous

If speed is an issue, you should precompute the loop condition outside of the cfloop (almost always a good idea anyway).

That is...
<CFSET iNumbOfEntries = arraylen (topOfOrg.getEntryArray().getEntry()) - 1>
<cfloop index="intIndex" from="0" to="#iNumbOfEntries#">
...

Translate

D

Dan_Bracuk

Inspiring

I'll assume your cfinvoke tag has a returnvariable attribute. Let's call it myArray.

<cfoutput>
<cfloop index = "ii" from = "0"
to = arraylen(myArray)>
#myArray[ii]#
etc

Translate

Sign up

To post, reply, or follow discussions, please sign in with your Adobe ID.

Sign in to Adobe Community

To post, reply, or follow discussions, please sign in with your Adobe ID.