Known Participant

Answered

<CFIF> Structure not working? What am I doing wrong?

Forum|Forum|16 years ago
February 17, 2010
3 replies
1266 views

Back at it. Hope I can figure this out today. Thanks again. There is one persnickety problem though. I have the DB set to a yes/no on certain items in a <cfif> structure. However, when the structure is processed it does not recognize the structure and continues to return the <cfelse> instead. I have tried changing the 1 to '1' and "1". I have also attempted using the isDefined('doubles'), but that did not work.

The previous page sends the URL.tName to this page.

As I said the DB fields for these below are set to yes/no, which is either 1 or 0. Obviously I am doing something wrong, but what is it? The <cfif> structure is not being ignored because it returns the last item <cfelse>. The statements are either true or false. At present it is as though the statements are all being read as false and the only thing that is true is the <cfelse>. Should I be scoping the <cfif> with the query? Any ideas out there. I am not a rocket scientist programmer, but know enough to get by.

SELECT *

FROM tournamentFeatures

WHERE tName = '#URL.tName#'

</cfquery>

<!--- #URL.tname# must have '#" signs around it because it is comparing the database "tname" to the URL.tname.

Aslo, the 'doubles' variable needs to be defined with tick marks because you are calling the valur from the

database.--->

<div class="redTextNORM">This is a Doubles Tournament. Please fill in the required information for the other team member.

</div>

<br />

<div class="redTextNORM">This tournament consists of a three person team. Please fill in the required information for the other team members.

</div>

<br />

<div class="redTextNORM">This tournament consists of a four person team. Please fill in the required information for the other team members.

</div>

<br />

<div class="redTextNORM">This tournament consists of a five person team. Please fill in the required information for the other team members.

</div>

<br />

<div class="redTextNORM">This is a Singles Tournament</div>

</cfif>

When a button is clicked on this page: http://www.renobowls.com/tournaments.cfm (Super No-Tap) which is set as a "doubles" tournament in the DB.

It goes to this template (http://www.renobowls.com/forms/T-Register.cfm?tName=Super%20No-Tap&tDate=12/13/09). The query should recognize it as a 'doubles' tournament, yet the template identifies it as a 'singles' tournament. The process should return two extra fields where the registrant adds the other bowlers name and member card number. Like I said, the process is not recognizing the <cfif> structure and only returns one thing.

When I change the first instance to this:

It works. But it seems backwards. In the database the tournament (Super No-Tap) is set to "1" or yes. The <cfif> rule is is the tournament is not "yes" or "1" then it should bypass it to the next group (cfif). I know its early but I feel a bit bonkers at this point.

This topic has been closed for replies.

Correct answer BuddWright

First and foremost, properly scope your variables! With so many variables floating around in your code using the same name, ColdFusion is likely to get mixed up and provide unexpected results. By scoping your variables as a rule of thumb, you eliminate that possibility completely, and make your code a lot more readable.

Second, when dealing with database bit/boolean (yes/no) fields that cannot be null, ColdFusion will allow you to test them as such, rather than testing them as numeric values or "yes/no" string values... i.e., "<cfif isDoubles>" will evaluate properly, as will "<cfif isDoubles EQ 1>". I prefer the former, because it eliminates guessing on whether I need to test for "1", "yes", or "true" for a true boolean value.

So, instead of this:

I would recommend doing this:

As long as the "doubles" field can't be null in your database, that'll work just fine.

A

Anonymous

Hi there,

I think you are a bit muddled when it comes to when to use hashes and quotes etc. Have a read over the help doc again.

In the meantime try your cfif statement as:

I dont understand why you have this logic "tName EQ #URL.tname#" you have already established this using your WHERE clause in the SQL statement. You should get rid of the hashes around url.tname as well.

Cheers

D

dcjones

Inspiring

Have you tried changing <cfif tName EQ #URL.tname# AND 'doubles' EQ 1> to <cfif #GetTournaments.tName# EQ #URL.tname# AND #GetTournaments.doubles# EQ 1> - before, it looks like you were checking to see if the exact text "tName" (not the variable by that name) equaled a URL variable, and the exact text "doubles" was 1. Of course, I could be wrong....

Dan

B

BuddWrightCorrect answer

Participating Frequently

First and foremost, properly scope your variables! With so many variables floating around in your code using the same name, ColdFusion is likely to get mixed up and provide unexpected results. By scoping your variables as a rule of thumb, you eliminate that possibility completely, and make your code a lot more readable.

Second, when dealing with database bit/boolean (yes/no) fields that cannot be null, ColdFusion will allow you to test them as such, rather than testing them as numeric values or "yes/no" string values... i.e., "<cfif isDoubles>" will evaluate properly, as will "<cfif isDoubles EQ 1>". I prefer the former, because it eliminates guessing on whether I need to test for "1", "yes", or "true" for a true boolean value.

So, instead of this:

I would recommend doing this:

As long as the "doubles" field can't be null in your database, that'll work just fine.

U

USN-WDAuthor

Known Participant

Budd Wright YOU ARE AWESOME DUDE!!!! I changed it to what you suggested and works like a swiss watch. THANK YOU!

Sign up

To post, reply, or follow discussions, please sign in with your Adobe ID.

Sign in to Adobe Community

To post, reply, or follow discussions, please sign in with your Adobe ID.

Scanning file for viruses.

This file cannot be downloaded