Need help with db select

Ok I've now got it working as suggested so that's a big improvement, thanks but it's not quite what I was after. What I want is for all records to be retrieved by default when there is no url suffix and not require ?websitetype=ALL

For the URL parameter the query is filtering the item. What you can do is tell php to query everything IF the URL parameter equals a certain value, like ALL. Or else your can tell php to filter based off the entered value like 1 or 2 or 3 or whatever.

Try something like this for your query:

// run the query if the URL parameter for websitetype is set. // for example: portfolio.php?websitetype=1 or portfolio.php?websitetype=ALL if (isset($_GET['websitetype'])) {           // start condition to run query if ALL types are to be shown.           if ($_GET['websitetype'] == 'ALL') {                     $query_portfolio = "SELECT *                     FROM portfoliodb                     ORDER BY portfoliodb.portfolio_id DESC";                // else run a query to filter only selected types                // based off value of URL parameter                } else {                     $query_portfolio = "SELECT *                     FROM portfoliodb                     WHERE portfoliodb.websitetype='". $_GET['websitetype'] ."'                      AND portfoliodb.visible = 1                     ORDER BY portfoliodb.portfolio_id DESC";           // end the condition whether the URL parameter           // was for ALL types or a certain type.           } // end if the URL parameter for websitetype is set. }

Then use /portfolio.php?websitetype=ALL to show ALL records or /portfolio.php?websitetype=1 to show records where type equals 1.

bikeman01 wrote: As usual I have been stuck for a while on what is probably a very simple solution so perhaps someone can help me, thanks. I have a portfolio page to which I post a url to filter the portfolio type (0, 1 or 2) and display the results. It works ok except that I can't get the url right to show all records. I have tried things like /portfolio.php?websitetype=1&2 and /portfolio.php?websitetype=* /portfolio.php?websitetype>0 Perhaps I need to change my select? $query_portfolio = "SELECT * FROM portfoliodb WHERE portfoliodb.websitetype='". $_GET['websitetype'] ."'  AND portfoliodb.visible = 1 ORDER BY portfoliodb.portfolio_id DESC";

First address ?websitetype=1&2 is like saying $_GET['websitetype']=1 and 2=nothing, so that address won't work.  Neither will address 2 or 3.  What is "*" and what is >0?.  The websitetype variable should equal a number.  Simple as that.  If the portfoliotype is equal to 1, is the visible field also set to 1?  If so, can we see the loop you are running to print all records because that is more likely where your problem lies.