Skip to main content
V
viatropos
Known Participant
October 8, 2009
Question

Fixed lots of Effect Bugs

  • October 8, 2009
  • 1 reply
  • 1101 views

Hey,

I have done a lot in my sandbox to fix Effect bugs, and add things that weren't in general working properly.  These include:

1) Added/removed Effects.

- Now all components, spark and halo, can have added/removed effects.

2) Popup Effects.

- Added/removed effects did not work correctly with popups, even in the old implementation.  Now, even with PopUpAnchor, you can run added/removed effects on the popup.  Move effects work correctly too, taking into consideration the popup position before animating.

3) EffectManager was modified for handling these changes, as was PopUpAnchor, PopUpManager, SystemManager, and ChildManager.  Nothing that would break anything, as I have run the tests and everything works fine.

Please pull my sandbox changes when you get a chance.  Thanks!

This topic has been closed for replies.

1 reply

matt_chotin
matt_chotin
Inspiring
October 8, 2009

Hey Lance,

I'm hoping the team will be able to take a look. i haven't checked it

out but based on what you describe it might be that the scope is

pretty large for evaluation for Flex 4 inclusion, but we'll see!

Matt

V
viatroposAuthor
Known Participant
October 8, 2009

Thanks a lot Matt.

My goal in creating my own sandbox was to fix all the little things I find as I go, optimize things here and there, and refactor the code if I need to (without modifying the API) to make it easier to do things.

These Effect fixes just made it so you could do what you expect, b/c it was doing strange things before .

It would be very helpful if there was a workflow for merging these sandboxes changes into the main branch so I could use the Framework "swz", unless there is a way, or you're planning on creating a way, to create my own.

Thanks,

Lance

matt_chotin
matt_chotin
Inspiring
October 8, 2009

Understood that we want these to go in if possible especially if we

evaluate and consider the fixes valid. But our process is to fix

things via specific bugs and not take wholesale changes, otherwise

it's difficult to track what happened at a particular time and why.

So Chet will try to take a look, but it will be a few weeks.

Matt

Terms & ConditionsAccessibility statement
Using the community Terms of use Privacy Cookie preferences Do not sell or share my personal information ad choicesAdChoices