Patches that come in chunks

Question

This is more of a process question about how patches are built and submitted.  In other large complicated open source projects (such as the Linux kernel)   it's fairly common for things to be added in stages, so for instance the   first patch on an issue might address the problem in (some) common cases, and   later patches will integrate feedback from testers and address more and more   edge cases.    I've had a patch rejected because it didn't cover all the edge cases (which is   fair enough, I hadn't though of them !) but going forward what do the   Adobeians feel about this area ?   Are patches that only address a subset of the issues OK ? Or would you prefer   one (larger, more invasive) patch that covered the whole bug surface ?

matt_chotin · Answer

I think we probably prefer a larger more invasive patch that covers the edge cases that we can think of. It's one thing if no one thinks of stuff, but in general we want to try to check in stuff that feels "complete." Of course, if the patch gets larger and larger to cover edge cases, the question will come up as to whether those edge cases fit the 80/20 rule, would it be better to be garbage-in/garbage-out, etc. Main point is, I think we're not looking for patches where it's known that there will have to be follow-on work, especially when it comes to bug fixes.

Matt

Sign up

To post, reply, or follow discussions, please sign in with your Adobe ID.

Sign in to Adobe Community

To post, reply, or follow discussions, please sign in with your Adobe ID.

Scanning file for viruses.

This file cannot be downloaded