Skip to main content
Adobe Employee
September 3, 2009
Question

[svn:fx-trunk] 10006: Initial checkin of the "More styles for Spark skins" feature.

  • September 3, 2009
  • 0 replies
  • 650 views

Revision: 10006

Author: gruehle@adobe.com

Date: 2009-09-03 15:04:47 -0700 (Thu, 03 Sep 2009)

Log Message:

***********

Initial checkin of the "More styles for Spark skins" feature. Details here:

http://opensource.adobe.com/wiki/display/flexsdk/MoreStylesforSparkSkins

There are some known issues:

  • Panel bottom corners not rounded correctly when the panel has a control bar

  • cornerRadius on Tab and DateChooser non functional

  • cornerRadius values > 4 have drawing artifacts in the "down" state of Button and button-like components

  • TextInput/TextArea incorrectly list lineBreak and verticalAlign as valid styles

This checkin also includes a couple minor unrelated bug fixes:

  • Remove MiniDebugTarget. This is a logging target that used MiniDebug, which hasn't worked since Flex 1.5

  • Fix RTEs when setting focusSkin to null

  • Optimization: don't measure skins if the host component has explicit sizes

QE notes: Yes, many baseline images will need to be regenerated

Doc notes: New ASDoc comments should be scrubbed

Bugs: SDK-22931, SDK-22798, SDK-22217, SDK-19358

Reviewer: Jason

Tests run: checkintests, cyclone

Is noteworthy for integration: Yes

Ticket Links:

************

http://bugs.adobe.com/jira/browse/SDK-22931

http://bugs.adobe.com/jira/browse/SDK-22798

http://bugs.adobe.com/jira/browse/SDK-22217

http://bugs.adobe.com/jira/browse/SDK-19358

Modified Paths:

**************

flex/sdk/trunk/frameworks/halo-manifest.xml

flex/sdk/trunk/frameworks/mxml-manifest.xml

flex/sdk/trunk/frameworks/projects/airframework/defaults.css

flex/sdk/trunk/frameworks/projects/airframework/src/spark/components/Window.as

flex/sdk/trunk/frameworks/projects/airframework/src/spark/components/WindowedApplication.as

flex/sdk/trunk/frameworks/projects/airframework/src/spark/skins/spark/SparkChromeWindowedApplicationSkin.mxml

flex/sdk/trunk/frameworks/projects/airframework/src/spark/skins/spark/WindowedApplicationSkin.mxml

flex/sdk/trunk/frameworks/projects/framework/defaults.css

flex/sdk/trunk/frameworks/projects/framework/src/mx/controls/ComboBase.as

flex/sdk/trunk/frameworks/projects/framework/src/mx/controls/DateChooser.as

flex/sdk/trunk/frameworks/projects/framework/src/mx/controls/NumericStepper.as

flex/sdk/trunk/frameworks/projects/framework/src/mx/controls/TextInput.as

flex/sdk/trunk/frameworks/projects/framework/src/mx/core/Container.as

flex/sdk/trunk/frameworks/projects/framework/src/mx/core/IDeferredContentOwner.as

flex/sdk/trunk/frameworks/projects/framework/src/mx/core/INavigatorContent.as

flex/sdk/trunk/frameworks/projects/framework/src/mx/core/ScrollControlBase.as

flex/sdk/trunk/frameworks/projects/framework/src/mx/core/UIComponent.as

flex/sdk/trunk/frameworks/projects/framework/src/mx/styles/metadata/BorderStyles.as

flex/sdk/trunk/frameworks/projects/spark/defaults.css

flex/sdk/trunk/frameworks/projects/spark/src/spark/components/Application.as

flex/sdk/trunk/frameworks/projects/spark/src/spark/components/DropDownList.as

flex/sdk/trunk/frameworks/projects/spark/src/spark/components/List.as

flex/sdk/trunk/frameworks/projects/spark/src/spark/components/NumericStepper.as

flex/sdk/trunk/frameworks/projects/spark/src/spark/components/Panel.as

flex/sdk/trunk/frameworks/projects/spark/src/spark/components/Scroller.as

flex/sdk/trunk/frameworks/projects/spark/src/spark/components/SkinnableContainer.as

flex/sdk/trunk/frameworks/projects/spark/src/spark/components/Spinner.as

flex/sdk/trunk/frameworks/projects/spark/src/spark/components/supportClasses/ButtonBase.as

flex/sdk/trunk/frameworks/projects/spark/src/spark/components/supportClasses/GroupBase.as

flex/sdk/trunk/frameworks/projects/spark/src/spark/components/supportClasses/Skin.as

flex/sdk/trunk/frameworks/projects/spark/src/spark/components/supportClasses/SkinnableComponent.as

flex/sdk/trunk/frameworks/projects/spark/src/spark/components/supportClasses/SkinnableTextBase.as

flex/sdk/trunk/frameworks/projects/spark/src/spark/components/supportClasses/Slider.as

flex/sdk/trunk/frameworks/projects/spark/src/spark/primitives/RectangularDropShadow.as

flex/sdk/trunk/frameworks/projects/spark/src/spark/skins/SparkSkin.as

flex/sdk/trunk/frameworks/projects/spark/src/spark/skins/spark/ApplicationSkin.mxml

flex/sdk/trunk/frameworks/projects/spark/src/spark/skins/spark/ButtonBarFirstButtonSkin.mxml

flex/sdk/trunk/frameworks/projects/spark/src/spark/skins/spark/ButtonBarLastButtonSkin.mxml

flex/sdk/trunk/frameworks/projects/spark/src/spark/skins/spark/ButtonSkin.mxml

flex/sdk/trunk/frameworks/projects/spark/src/spark/skins/spark/DefaultButtonSkin.mxml

flex/sdk/trunk/frameworks/projects/spark/src/spark/skins/spark/DropDownListButtonSkin.mxml

flex/sdk/trunk/frameworks/projects/spark/src/spark/skins/spark/DropDownListSkin.mxml

flex/sdk/trunk/frameworks/projects/spark/src/spark/skins/spark/FocusSkin.as

flex/sdk/trunk/frameworks/projects/spark/src/spark/skins/spark/ListSkin.mxml

flex/sdk/trunk/frameworks/projects/spark/src/spark/skins/spark/NumericStepperTextInputSkin.mxml

flex/sdk/trunk/frameworks/projects/spark/src/spark/skins/spark/PanelSkin.mxml

flex/sdk/trunk/frameworks/projects/spark/src/spark/skins/spark/SpinnerDecrementButtonSkin.mxml

flex/sdk/trunk/frameworks/projects/spark/src/spark/skins/spark/SpinnerIncrementButtonSkin.mxml

flex/sdk/trunk/frameworks/projects/spark/src/spark/skins/spark/TextAreaSkin.mxml

flex/sdk/trunk/frameworks/projects/spark/src/spark/skins/spark/TextInputSkin.mxml

flex/sdk/trunk/frameworks/projects/spark/src/spark/skins/spark/ToggleButtonSkin.mxml

flex/sdk/trunk/frameworks/projects/sparkskins/src/mx/skins/spark/BorderSkin.mxml

flex/sdk/trunk/frameworks/projects/sparkskins/src/mx/skins/spark/ButtonBarFirstButtonSkin.mxml

flex/sdk/trunk/frameworks/projects/sparkskins/src/mx/skins/spark/ButtonBarLastButtonSkin.mxml

flex/sdk/trunk/frameworks/projects/sparkskins/src/mx/skins/spark/ButtonSkin.mxml

flex/sdk/trunk/frameworks/projects/sparkskins/src/mx/skins/spark/ComboBoxSkin.mxml

flex/sdk/trunk/frameworks/projects/sparkskins/src/mx/skins/spark/DefaultButtonSkin.mxml

flex/sdk/trunk/frameworks/projects/sparkskins/src/mx/skins/spark/EditableComboBoxSkin.mxml

flex/sdk/trunk/frameworks/projects/sparkskins/src/mx/skins/spark/PanelBorderSkin.mxml

flex/sdk/trunk/frameworks/projects/sparkskins/src/mx/skins/spark/PopUpButtonSkin.mxml

flex/sdk/trunk/frameworks/projects/sparkskins/src/mx/skins/spark/SparkSkinForHalo.as

flex/sdk/trunk/frameworks/projects/sparkskins/src/mx/skins/spark/StepperDecrButtonSkin.mxml

flex/sdk/trunk/frameworks/projects/sparkskins/src/mx/skins/spark/StepperIncrButtonSkin.mxml

flex/sdk/trunk/frameworks/projects/sparkskins/src/mx/skins/spark/TextInputBorderSkin.mxml

flex/sdk/trunk/frameworks/projects/wireframe/src/spark/skins/wireframe/ApplicationSkin.mxml

flex/sdk/trunk/frameworks/tests/basicTests/BasicTests.css

flex/sdk/trunk/frameworks/tests/basicTests/spark/scripts/BorderTestScript.mxml

Removed Paths:

*************

flex/sdk/trunk/frameworks/projects/framework/src/mx/logging/targets/MiniDebugTarget.as

This topic has been closed for replies.