Skip to main content
rechmbrs
rechmbrs
Inspiring
February 23, 2020
Answered

Need help with onClick in new ExtendScript for PS.

  • February 23, 2020
  • 2 replies
  • 3698 views

The enclosed script was coded in ESTK for use in Photoshop.  It is part of a specialized calculator to be used in PS but I can't get this starter version to work correctly.  It is based on an HTML/CSS/JS version I wrote some time ago and it works correctly.

 

The problem I'm seeing is that the onClick code is being executed during the build but does nothing when the buttons are pressed after the dialog.show statement.  You can see from the commented code that I once tried moving the onClick lines to a separate function but didn't help me.

 

I've tested in both ESTK and PS with the same results.  I left in some alert code that shows what is happening during the build phase.  It is doing what I want then not when the button is clicked.

 

I apprecaite any help you can supply.

 

Thanks,

RONC

 

 

 

//#script sciCALC.jsx
//#target photoshop

/**
* @@@BUILDINFO@@@ sciCalc.jsx !Version! Sat Feb 22 2020 17:24:06 GMT-0600
*/

var scriptName = "sciCALC_for_Photoshop_by_RONC ©2020";
var scriptVerNum = "0.03";
var scriptVerNumHelp = "v1";
var scriptVerDate = "22Feb2020";
var scriptVersion = scriptVerNum + " - " + scriptVerDate;
var scriptHeader = "sciCALC " + scriptVersion + " by RONC";
var scriptAuthor = ""; //"Ron Chambers";
var scriptAbstract = "sC - See Abstract and Copyright information in the HELP file: ";

var decimal = 10;

var noErr;

var slotNum, rowNum;
var dialog, dialogGraphics;
var colorBG, colorFG;
var displayArea;
var numRows = 8, numSlots = 35;
var row = [numRows], slot = [numSlots];
var keyCLEAR, keyCOPY, keyBACK, keyENTER;
var keyESC, keyESCtext, keyESCtextColor, keyESCtextGraphics;

var uiDone = 0;

doBuild();
function doBuild()
{
// dialog for calculator
dialog = new Window("dialog", " " + scriptHeader);
dialog.alignment = "center";
dialog.spacing = 1;
dialog.margins = 1;

dialogGraphics = dialog.graphics;
colorBG = [0.1, 0.1, 0.1, 1.0];
colorFG = [1.0, 1.0, 1.0, 1.0];
dialogGraphics.font = ScriptUI.newFont("ARIAL", ScriptUI.FontStyle.BOLD, 16);
dialogGraphics.backgroundColor = dialogGraphics.newBrush(dialogGraphics.BrushType.SOLID_COLOR, colorBG, 0);
dialogGraphics.foregroundColor = dialogGraphics.newPen(dialogGraphics.PenType.SOLID_COLOR, colorFG, lineWidth = 2);

// equation display area
dialog.openPnl = dialog.add("panel", undefined, scriptAuthor);
rowNum = 0;
row[rowNum] = dialog.openPnl.add("group");
row[rowNum].orientation = "row";
row[rowNum].alignment = "center";
row[rowNum].spacing = 1;
row[rowNum].margins = 1;
displayArea = row[rowNum].add('edittext {justify: "right", properties: {name: "displayArea", characters: 25}}');
displayArea.active = true;
displayArea.bounds = [0, 0, 300, 20];
displayArea.enabled = true;
displayArea.text = "0";

// calculator key area by row
rowNum++;
row[rowNum] = dialog.openPnl.add("group");
row[rowNum].orientation = "row";
row[rowNum].alignment = "center";
row[rowNum].spacing = 1;
row[rowNum].margins = 1;
row[rowNum].borderStyle='black';

slotNum = 0;
slot[slotNum] = row[rowNum].add("button");
slot[slotNum].bounds = [0, 0, 60, 20];
slot[slotNum].text = "1";
slot[slotNum].onClick = addchar("1");
slotNum++;

slot[slotNum] = row[rowNum].add("button");
slot[slotNum].bounds = [0, 0, 60, 20];
slot[slotNum].text = "2";
slot[slotNum].onClick = addchar("2");
slotNum++;

slot[slotNum] = row[rowNum].add("button");
slot[slotNum].bounds = [0, 0, 60, 20];
slot[slotNum].text = "3";
slot[slotNum].onClick = addchar("3");
slotNum++;

rowNum++;
row[rowNum] = dialog.openPnl.add("group");
row[rowNum].orientation = "row";
row[rowNum].alignment = "center";
row[rowNum].spacing = 1;
row[rowNum].margins = 1;

// operation buttons
slot[slotNum] = row[rowNum].add("button");
slot[slotNum].bounds = [0, 0, 60, 20];
slot[slotNum].text = "CLEAR";
keyCLEAR = slot[slotNum];
slotNum++;

slot[slotNum] = row[rowNum].add("button");
slot[slotNum].bounds = [0, 0, 60, 20];
slot[slotNum].text = "BACK";
keyBACK = slot[slotNum];
slotNum++;

slot[slotNum] = row[rowNum].add("button");
slot[slotNum].bounds = [0, 0, 60, 20];
slot[slotNum].text = "COPY";
keyCOPY = slot[slotNum];
slotNum++;

slot[slotNum] = row[rowNum].add("button");
slot[slotNum].bounds = [0, 0, 120, 20];
slot[slotNum].text = "ENTER";
keyENTER = slot[slotNum];
slotNum++;

// ESC key to close
keyESC = dialog.openPnl.add("group");
keyESC.orientation = "row";
keyESC.alignment = "center";
keyESC.spacing = 1;
keyESC.margins = 1;
keyESCtext = keyESC.add("statictext", undefined, "(ESC cancels script in PS)");
keyESCtextColor = [1.0, 1.0, 0.0, 1];
keyESCtextGraphics = keyESCtext.graphics;
keyESCtextGraphics.font = ScriptUI.newFont("ARIAL", ScriptUI.FontStyle.REGULAR, 10);
keyESCtextGraphics.foregroundColor = keyESCtextGraphics.newPen(keyESCtextGraphics.PenType.SOLID_COLOR, keyESCtextColor, lineWidth = 1);
}

doRun();
function doRun()
{
/*slotNum = 0;
slot[slotNum].onClick = addchar("1");
slotNum++;
slot[slotNum].onClick = addchar("2");
slotNum++;
slot[slotNum].onClick = addchar("3");*/

//keyCLEAR.onClick = clear();
//keyBACK.onClick = deletechar();
//keyCOPY.onClick = copy();
//keyENTER.onClick = checkValidCompute();
//dialog.cancelElement = null;
//dialog.defaultElement = null;
dialog.show();
}
function doDone()
{
alert(displayArea.text, "OK");
dialog.close();
}

function addchar(charIn)// add char
{
alert(displayArea.text + " " + charIn, "addc1");

if (displayArea.text === "" || displayArea.text === "0")
displayArea.text = charIn;
else
displayArea.text += charIn;

alert(displayArea.text + " " + charIn, "addc2");
}

//
//============================== sciCALC =====================
//
function sciCALC()
{
sciCALC.main = function ()
{
if (uiDone !== 0)
{
alert("ABORTING due to ERROR", "sciCALC ERROR");
}
else
{
sciCALC();
}

sciCALC.main();
};
}

"sciCALC.jsx";
// EOF

This topic has been closed for replies.
Correct answer r-bin

What does addchar ("1") function return???

 

Right - undefined.


Therefore slot [slotNum] .onClick is equally undefined when you write
slot [slotNum] .onClick = addchar ("1");

Nothing will work.

slot [slotNum] .onClick you need to assign a function (function name == function reference), for example
slot [slotNum] .onClick = addchar;

But since you also want to pass the argument, you need to create another function, for example

slot [slotNum] .onClick = function () {addchar ("1"); }

or

function xxxx () {addchar ("1"); }
slot [slotNum] .onClick = xxxx;

2 replies

R
r-bin
Legend
February 23, 2020
To understand what is going on there, need the source code of the script.
 
 
rechmbrs
rechmbrsAuthor
Inspiring
February 24, 2020

Source at top shows the problem but aren't as many rows.  I can send source of the latest but it is much longer and more complicated.

What's the problem?  Solution?

 

Is there a way to place the buttons in one panel and tightly bunched?

 

Thanks,

RONC

R
r-bin
Legend
February 24, 2020
Maybe I misunderstood.
Here is the code
 

 

var d = new Window("dialog");

d.margins = 0;
d.spacing = 0;

var n = 1;

d.b = new Array();

with (d.add("group")) 
    { 
    orientation = "column";
    margins = 0;
    spacing = 0;

    for (var i = 0; i < 4; i++)
        {
        with (add("group")) 
            { 
            orientation = "row";
            margins = 0;
            spacing = 0;

            for (var x = 0; x < 4; x++)
                {
                d.b[n] = add("button", undefined, n);
                d.b[n].preferredSize = [60,20];
                ++n;
                }
            }
        }
    }

d.show();

 

 
Here is a view
 
    R
    r-binCorrect answer
    Legend
    February 23, 2020

    What does addchar ("1") function return???

     

    Right - undefined.


    Therefore slot [slotNum] .onClick is equally undefined when you write
    slot [slotNum] .onClick = addchar ("1");

    Nothing will work.

    slot [slotNum] .onClick you need to assign a function (function name == function reference), for example
    slot [slotNum] .onClick = addchar;

    But since you also want to pass the argument, you need to create another function, for example

    slot [slotNum] .onClick = function () {addchar ("1"); }

    or

    function xxxx () {addchar ("1"); }
    slot [slotNum] .onClick = xxxx;

      rechmbrs
      rechmbrsAuthor
      Inspiring
      February 23, 2020

      r-bin,

       

      Thanks a ton. 

       

      But I'm totally clueless on:   

         slot [slotNum] .onClick you need to assign a function (function name == function reference), for example
         slot [slotNum] .onClick = addchar;

       

      If I place a return  0; inside addchar, that doesn't work.  What is the function () {}; doing?

       

      addchar is already a function.

       

      I didn't have to do that in the html/js code.  Does html include the function () {}; without me knowing it?

       

      I really appreciate your help as making the changes makes it work.

       

      RONC

      rechmbrs
      rechmbrsAuthor
      Inspiring
      February 23, 2020

      I think I understand in that in Extendscript, one cannot pass an argument to a function when passing the function to onClick.  If I would have used a global for the passing the "1" etc. instead of using an argument it would have worked and I wouldn't know about this.

       

      Thanks again,

      RONC

      Terms & ConditionsAccessibility statement
      Using the community Terms of use Privacy Cookie preferences Do not sell or share my personal information ad choicesAdChoices