Need script to batch import images into PSD layer

Hello.

I've tried to adapt this script I to  update a sprite sheet.

The sprite sheet contains 6 smart objects, which where created by importing PSD containing 1 transparent rasterized layer, converting to SmartObjects, then repositioning and scaling.

The script has two faults. Either it runs and replaces the images, but moves them about vertically.

Or it simply throws an "General Photoshop Error. This method may not be.. etc" error and highlights this line :

executeAction( idplacedLayerEditContents, desc2, DialogModes.NO );


I'm still getting to grips with the completely bonkers API, looking at what looks like assembly language bubbling up through the "baretail" application.

Any tips as to why it's erroring out or coming in in the wrong places vertically (looks OK horizontally) most appreciate.

It's the bizarre intermittent error that bugs me most, sometimes it runs and does it wrong, sometimes I just get a bing  noise.

Script is here :

http://www.charlescrammond.co.uk/downloads/ReplaceContentsOfSmartObjects.jsx

Sample PSDs I'm using are  here :

http://www.charlescrammond.co.uk/downloads/spritesheet.zip

any help much appreciated! meanwhile, I guess back to the UI and manually doing it

Charles

/// Script to automate replacing contents of smart layers with selected psds
/// Sometimes it just about works, and replaces the images fine but moves them down vertically.
/// Sometimes it throws an error at :
///  executeAction( idplacedLayerEditContents, desc2, DialogModes.NO );

#target photoshop

if (app.documents.length > 0)
{
   var myDocument = app.activeDocument;
   var thePath = myDocument.path;

   var pngopts = new PNGSaveOptions();
   pngopts.interlace = false;

function swapImages()
{
      // select files;
      if ($.os.search(/windows/i) != -1)
      {
         var theFiles = File.openDialog ("please select files", "*.psd;*.psb", true)
      }
      else
      {
         var theFiles = File.openDialog ("please select files", getFiles, true);
      };

      if (theFiles)
      {
         // work through the array;
         for (var m = 0; m < theFiles.length; m++)
         {
            // open smart object; in active document
            var getLayerToChange = app.activeDocument.artLayers;
            app.activeDocument.activeLayer = getLayerToChange;
            var smartObject = openSmartObject (getLayerToChange);
                 
            // get a reference to the layer within
            var theLayer2 = smartObject.activeLayer;
            // replace smart object;
            if (theLayer2.kind == "LayerKind.SMARTOBJECT")
            {
               replaceContents (theFiles);
               // This closes the current image source file.
               smartObject.close(SaveOptions.SAVECHANGES);  
               // not  sure this is needed but what the hell
               delete smartObject;
            };
         //save png;
         $.writeln("Saving a PNG");
         myDocument.saveAs((new File(thePath+"/"+"spritesheet.png")),pngopts,true);
         };     
      };
   };
};

////// get psds and psb  from files //////
function getFiles (theFile)
{
   if (theFile.name.match(/\.(psd|psb)$/i))
   {
      return true
   };
};

////// replace contents //////
function replaceContents (newFile)
{
   var idplacedLayerReplaceContents = stringIDToTypeID( "placedLayerReplaceContents" );
   var desc3 = new ActionDescriptor();
   var idnull = charIDToTypeID( "null" );
   desc3.putPath( idnull, new File( newFile ) );
   var idPgNm = charIDToTypeID( "PgNm" );
   desc3.putInteger( idPgNm, 1 );
   executeAction( idplacedLayerReplaceContents, desc3, DialogModes.NO );
   //
   return app.activeDocument.activeLayer
};

////// open smart object //////
function openSmartObject (theLayer)
{
   if (theLayer.kind == "LayerKind.SMARTOBJECT")
   {
      var idplacedLayerEditContents = stringIDToTypeID( "placedLayerEditContents" );
      var desc2 = new ActionDescriptor();
      // why does this line here throw errors sometimes, and sometimes not.
      executeAction( idplacedLayerEditContents, desc2, DialogModes.NO );

   };
   return app.activeDocument
};


// Call main function
swapImages();

Do all the pdfs have one page or are they multi-paged ones, too?

Could you post screenshots of the receiving File’s Layer-structure and what you want the result to be?

Are the layered files to be saved, too, or discarded and only the jpgs saved?

Where should the jpg reide relative to the receiving file?