Photoshop thumbnails and CS4

Based on the registry setting, it looks like psicon.dll implements IExtractImage.

IExtractImage::GetLocation is passed a name to a file. The shell doesn't open the file, nor does it close it.

There is most likely a disagreement about the lifetime of the IExtractImage object and when the file should be opened or closed.

The simple workaround is to grab the thumbnail in GetLocation and close the file, or use a lazy load and open/close the file in IExtractImage::Extract. You would only need to open the file for a miniscule amount of time and close it right away.

When I implemented IThumbnailProvider for DNG, I used similar logic in my implementation of IInitializeWithFile -- request late and release early -- to avoid issues like this. This doesn't give you the flexibility of IInitializeWithStream, but it does give you total control of the lifetime of the file handle.

<crossing fingers>

We don't have a contact on the explorer team itself, we have corporate liasons between our companies.

According to our status of bugs filed with Microsoft: the explorer extension "leaving files open" bug still is not fixed, but the bug report has not been updated in years. (which is part of why we gave up hope that it would ever be fixed)

Someone will be in touch.

Appropriate introduction?

I will take care of this: What type of beer do you drink?

See, that was easy. :)

On to the next part.

I've the feeling, it's gonna be this: ... And if not, at least we know who proposed marriage ...

Hey Chris,

Who is your contact for the Explorer team? Our platform program manager, David Washington, is probably the best person to talk to. If you (or the approriate person on your side) would like to get in touch with him, you can drop me an e-mail any time and I'll make the appropriate introduction. You can reach me at Brandon.Paddock@microsoft.com

As for your past experiences dealing with the Windows team I really can't comment especially without knowing what channel you'd gone through or who was around back then. All I can do is try to help with any problems you're hitting *now* and connect you with the best people to address any problems you run into.

Our team is extremely aggressive about fixing any issues that block adoption of our platform from ISVs, and large ones like Adobe in particular. If there really is a bug preventing you guys from implementing format handlers, I don't believe it would be hard for us to ensure it is fixed in Windows 7, and if at all possible I'm sure we'd do everything we can to get the fix available downlevel (ie. service pack, etc).

That said, the sheer number of thumbnail handlers that currently work on Vista without problems, and the in-depth test coverage we have in this area, makes me quite certain we could help you get this working without any changes to the OS at all.

You have my e-mail, so if you would like to try and get this feature working for a future Adobe release, please drop me a line at your convenience.

Thanks,
Brandon

>I've just been looking for an excuse to post the gif...

stolen! MUWAHAHAHAHA! :)

Somebody give me my PSD Exlporer thumbnails back!!



Umm, actually, I have them. I hacked the Registry a long time ago to restore them to CS/CS2. I've just been looking for an excuse to post the gif... :)

> I'm sorry, but I have to add my two cents. Reading this current exchange, It seems that we have a Microsoft team member who is willing to help (almost bend over backwards) and the Adobe team member who seems to be very resistant. I would hope that isn't the pervasive philosophy within the Adobe team.

> Thank you Brandon for joining in.

Got the same impression. Couldn't have said it any better!

At the moment we got this (Adobe left, MS right):

Let's hope it will end like this:

And not like this (MS left, Adobe right):

Brandon - I'll have to follow up with our Microsoft liason. We've got a long list of bugs still open with MS and I don't know the specific issue number for that bug.

Paul - we would help if the API worked, but as far as we know it still doesn't work. Somewhere Microsoft may have failed to communicate a bug fix status to Adobe, and maybe Adobe isn't regressing every one of the hundreds of bugs we have open with Microsoft with every build of the OS. Both parties want to do the right thing, but somewhere communication broke down. You could also view this discussion as: Adobe tested this, found crippling bugs, reported the bugs to Microsoft, Microsoft didn't fix the bugs and Microsoft now claims the bugs don't exist. It depends on the viewpoint and what information you have available.