Script debug - what's wrong with this picture?

Question

I wrote a script a while back which shrinks and saves out images in png format. Nothing fancy. It works fine. I am happy. However yesterday, I discovered that it baulked at a certain file. Initally I thought it was a problem with the script (and that may be the case - i'm still new to scripting) but it worked with every other image I've thrown at it. Ergo it must be something wrong with the image.

Now here's the thing: I also noticed that adding a new layer underneath the existing single layer and then merging down allowed the script to work fine. So what is wrong with the inital image before it's had a new layer added and merged? Or what does adding and merging do to an image do to fix as I can't see any visual difference?

Here is the bare bones of the script:

// Set filePath and fileName to source path
filePath = "C:\\temp" + "/" + 'debugme' + '.png';

// save out the image
var pngFile = new File(filePath);
pngSaveOptions = new PNGSaveOptions();
pngSaveOptions.embedColorProfile = true;
pngSaveOptions.formatOptions = FormatOptions.STANDARDBASELINE;
pngSaveOptions.matte = MatteType.NONE;
pngSaveOptions.quality = 1;
pngSaveOptions.PNG8 = false;
pngSaveOptions.transparency = true;

activeDocument.saveAs(pngFile, pngSaveOptions, false, Extension.LOWERCASE);

I would include the two psds (one that works and the one that doesn't) only this forum doesn''t seem to allow .psd files - and saving them out in another format is the whole problem.

Muppet_Mark-QAl63s · Accepted Answer

Well you have me stumped with that one and I think it could be a possible bug? There would appear to be NO layer styling to either of those documents… However if I navigate to Menubar/Layers/Layer Style in your document 'fileworks.psd' there is NO option to clear layer style on the other hand in file 'filefails.psd' there is an option to clear even though it appears to have none and if I do so the file saves just fine. I think you could use a scriptlistener bit of code to do this as a matter of course. But it does look like something is left over in file when you flatten the style?

A quick test and this resolved the issue for me…

#target photoshop 

filePath = '~/Desktop/Testing.png';
 
// save out the image
var pngFile = new File(filePath);
pngSaveOptions = new PNGSaveOptions();
pngSaveOptions.embedColorProfile = true;
pngSaveOptions.formatOptions = FormatOptions.STANDARDBASELINE;
pngSaveOptions.matte = MatteType.NONE;
pngSaveOptions.quality = 1;
pngSaveOptions.PNG8 = false;
pngSaveOptions.transparency = true;

clearLayerStyle();

activeDocument.saveAs(pngFile, pngSaveOptions, false, Extension.LOWERCASE);

function clearLayerStyle() {
     function cTID(s) { return app.charIDToTypeID(s); };
     function sTID(s) { return app.stringIDToTypeID(s); };
          var desc01 = new ActionDescriptor();
          var ref01 = new ActionReference();
          ref01.putEnumerated( cTID('Lyr '), cTID('Ordn'), cTID('Trgt') );
          desc01.putReference( cTID('null'), ref01 );
     executeAction( sTID('disableLayerStyle'), desc01, DialogModes.NO );
}

Ghoulfool · Answer

Wow, thanks Muppet Mark! I had a feeling it would be something obscure, like the layer styles not clearing properly or a residual bit of information that needed to be cleared.

Sign up

To post, reply, or follow discussions, please sign in with your Adobe ID.

Sign in to Adobe Community

To post, reply, or follow discussions, please sign in with your Adobe ID.

Scanning file for viruses.

This file cannot be downloaded