karpiyon wrote
After opening the file, if I (A) hide the adjustment layer, convert to srgb the colors are preserved correctly. When I (B) unhide the adjustment layers and do the same the colors are washed out. When I try to flatten the image before converting or play around with the settings, the colors suddenly appear correctly. If I then undo try (B) again, suddenly the colors show up correctly. |
This is not a bug. It is in fact expected and normal behavior.
Adjustments are numerical. A profile conversion changes the numbers. So it follows that all numerical adjustments are color space specific. The same adjustment will produce different effects in different color spaces. Again, this is how it has to be, and this is why Photoshop asks you if you want to flatten before conversion.
I was about to say "try it for yourself" - but that's just what you did...you just misinterpreted the result.
---
BTW, there is no particular advantage in ProPhoto for luminosity masks. A luminosity mask is lifted from a (slightly modified) Lab L channel, and the mask is identical whatever the document color space.
There are many myths surrounding ProPhoto. One of the most persistent is that it's the "best" color space. It isn't - it's just the largest. But that comes at a price. Increased risk of banding is one, severely compressed shadow values is another. The latter makes subtle shadow adjustments very difficult, because small numerical changes have large effects. It's difficult to use the histogram to spot and correct shadow color casts.
Routinely using ProPhoto increases the risk of unwanted gamut clipping, because you are forced to deal with it all in one go, at the output stage. Clipping is much easier to control early on. The main use of ProPhoto is to catch and contain raw processor artifacts until you can get them under control, without premature clipping.
Oh, and BTW - there is no reason whatsoever to "match" Lightroom and Photoshop (or to "synchronize" color settings). These are color managed applications, and any profile, regardless what it is, will be correctly handled. That's the whole point of color management in the first place. That's what it does.