Skip to main content
T
tomhock
Inspiring
April 3, 2019
Answered

What happened to the "Okay" button on adjustment layers

  • April 3, 2019
  • 6 replies
  • 2117 views

How am I supposed to set an adjustment, clear an adjustment, or abandon an adjustment without a button on the dialog?  Why does the history now include all the steps I make in the dialog?  This isn't Illustrator, which I hate, right?

    This topic has been closed for replies.
    Correct answer c.pfaffenbichler

    I read them.  Except for yours, they were more concerned with slamming me for the Illustrator comment than reading my question.  Otherwise, they would have acknowledged my premise like you did -- that PS has very recently changed these dialogs.  Indeed, the other responders essentially denied this. 

    Unfortunately, I am stupid and do not understand your reponse.  How is the old panel still available and what do you mean "via script?"

    I don't necessarily need the old panel back; I've just never seen any dialog work like these adjustment layer dialogs do now.  So you just make your adjustment and then close the panel?  And if you decide halfway through to abandon the adjustment, you then have to undo or delete the layer?  When did this change (it hasn't been that long since I did a curves layer)?


    that PS has very recently changed these dialogs.

    The Adjustments Panel was introduced with CS4 (released 2008) and later changed into/combined with the Properties Panel.

    How is the old panel still available and what do you mean "via script?"

    The below JavaScript code (saved as a txt-file with the extension »jsx« and placed in the Presets/Scripts-Folder) will when invokes via File > Scripts > … raise the modal dialog for the active/selected Adjustment Layer and can be assigned a keyboard shortcut.

    One can also use similar code for the creation of the Adjustment Layers, but that effectively needs one Script per Adjustment Layer kind one wishes to create thusly.

    »modal« here means that the dialog takes »focus«, so one cannot (for example) hide a Layer in the Layers Panel while the dialog is visible whereas working in the Properties Panel does not prevent such operations.

    //opens the modal dialog for editing selected adjustment layers of some types, not all though; based on john nack’s panel;

    // use it at your own risk;

    #target photoshop;

    if (app.documents.length > 0) {

    var myDocument = app.activeDocument;

    var checksOut = true;

    switch (myDocument.activeLayer.kind) {

      case LayerKind.CURVES:

      theVars365 = 1131574899;

      break;

      case LayerKind.HUESATURATION:

      theVars365 = 1213428850;

      break;

      case LayerKind.SELECTIVECOLOR:

      theVars365 = 1399612227;

      break;

      case LayerKind.LEVELS:

      theVars365 = 1282829427;

      break;

      case LayerKind.BLACKANDWHITE:

      theVars365 = 1113681495;

      break;

      case LayerKind.POSTERIZE:

      theVars365 = 1349743730;

      break;

      case LayerKind.GRADIENTMAP:

      theVars365 = 1197755760;

      break;

      case LayerKind.CHANNELMIXER:

      theVars365 = 1130917453;

      break;

      case LayerKind.THRESHOLD:

      theVars365 = 1416131187;

      break;

      case LayerKind.COLORBALANCE:

      theVars365 = 1131180610;

      break;

      case LayerKind.VIBRANCE:

      theVars365 = stringIDToTypeID( "vibrance" );

      break;

      case LayerKind.EXPOSURE:

      theVars365 = 1165521011;

      break;

      default:

      checksOut = false;

      };

    // adjustment layers;

    if (checksOut == true){

      var id365 = theVars365;

      theModalDialogue (theVars365);

      }

    else {

    // else check for solid fill layer;

      if (myDocument.activeLayer.kind == "LayerKind.SOLIDFILL" || myDocument.activeLayer.kind == "LayerKind.PATTERNFILL" || myDocument.activeLayer.kind == "LayerKind.GRADIENTFILL") {

      try {

      layerContentOptions()

      }

      catch (e) {}

      }

      else {

      alert("selected layer is neither curves–, hue/saturation-, selective color-, levels-, black and white-, posterize-, gradient map- or threshold-adjustment layer nor a solidfill-, gradient- or pattern-layer")

      }

      }

    };

    ////// modal editing //////

    function theModalDialogue (theVars365) {

    ErrStrs = {};

    ErrStrs.USER_CANCELLED=localize("$$$/ScriptingSupport/Error/UserCancelled=User cancelled the operation");

    try {

      var id359 = charIDToTypeID( "setd" );

      var desc77 = new ActionDescriptor();

      var id360 = charIDToTypeID( "null" );

      var ref48 = new ActionReference();

      var id361 = stringIDToTypeID( "contentLayer" );

      var id362 = charIDToTypeID( "Ordn" );

      var id363 = charIDToTypeID( "Trgt" );

      ref48.putEnumerated( id361, id362, id363 );

      desc77.putReference( id360, ref48 );

      var id364 = charIDToTypeID( "T   " );

      desc77.putClass( id364, id365 );

      executeAction( id359, desc77, DialogModes.ALL );

      }

    catch(e){

      if (e.toString().indexOf(ErrStrs.USER_CANCELLED)!=-1) {;

      }

      else{

      alert("$$$/ScriptingSupport/Error/CommandNotAvailable=The command is currently not available");

      }

      }

    };

    ////// edit solid fill //////

    function layerContentOptions () {

    var id450 = charIDToTypeID( "slct" );

    var desc90 = new ActionDescriptor();

    var id451 = charIDToTypeID( "null" );

    var ref61 = new ActionReference();

    var id452 = charIDToTypeID( "Mn  " );

    var id453 = charIDToTypeID( "MnIt" );

    var id454 = charIDToTypeID( "AdjO" );

    ref61.putEnumerated( id452, id453, id454 );

    desc90.putReference( id451, ref61 );

    executeAction( id450, desc90, DialogModes.ALL )

    };

    6 replies

    T
    tomhockAuthor
    Inspiring
    April 4, 2019

    "Adjustment layers have never had an OK button."

    Uh . . . yes they have, at least the dialogs used to "adjust" them did.  The curves dialog used to look exactly the same whether it was being used to create an adjument layer or to "destructively" adjust an image.  Now it doesn't.  It doesn't work the same as it did, and neither does the history, which did NOT used to record all the actions taken within the curves dialog.  it recorded the overall curves adjustment period.  I see now that the "destructive" curves dialog has changed too.  Where are the load and save buttons on it?  I thought I had turned off auto updates, but I guess I didn't.  Thanks again Adobe.

    And yes, I know this isn't Illustrator, and I know that Illustrator doesn't have a history panel, which is one of the things I hate about it (and please don't start giving me the party line on why it doesn't need one).

    c.pfaffenbichler
    Community Expert
    c.pfaffenbichlerCommunity Expert
    Community Expert
    April 4, 2019
    Now it doesn't.

    I didn’t bother reading your whole post, after all you hadn’t bothered reading the posts here, either, apparently.

    I already explained that the modal Adjustment Dialog windows are still available but that the default is the Appearance Panel now. 

      T
      tomhockAuthor
      Inspiring
      April 4, 2019

      I read them.  Except for yours, they were more concerned with slamming me for the Illustrator comment than reading my question.  Otherwise, they would have acknowledged my premise like you did -- that PS has very recently changed these dialogs.  Indeed, the other responders essentially denied this. 

      Unfortunately, I am stupid and do not understand your reponse.  How is the old panel still available and what do you mean "via script?"

      I don't necessarily need the old panel back; I've just never seen any dialog work like these adjustment layer dialogs do now.  So you just make your adjustment and then close the panel?  And if you decide halfway through to abandon the adjustment, you then have to undo or delete the layer?  When did this change (it hasn't been that long since I did a curves layer)?

      c.pfaffenbichler
      Community Expert
      c.pfaffenbichlerCommunity Expert
      Community Expert
      April 4, 2019

      Like mentioned earlier the dialog can still be raised via Script.

      Not sure how long that will continue to be the case but I myself prefer it, so I’m hoping a while yet …

      c.pfaffenbichler
      Community Expert
      c.pfaffenbichlerCommunity Expert
      Community Expert
      April 4, 2019

      Could it be you have not used a current Photoshop version since the introduction of the Adjustments/Properties Panel until now?

      The modal Dialog (while still available via Script for example) has effectively been replaced by a non-modal Panel. (edited)

      If this and the other responses don’t clear things up please post screenshots to illustrate what you mean.

      davescm
      Community Expert
      davescmCommunity Expert
      Community Expert
      April 4, 2019

      tomhock  wrote

      How am I supposed to set an adjustment, clear an adjustment, or abandon an adjustment without a button on the dialog?  Why does the history now include all the steps I make in the dialog?  This isn't Illustrator, which I hate, right?

      No this is not Illustrator it is Photoshop

      Adjustment layers have never had an OK button.   On an adjustment layer you can reset the adjustment to where you opened the adjustment layer by clicking once where circled below, clicking twice will revert to the default for the adjustments

      The button to the left of that allows you to toggle the preview of your latest change (hold it down to see the preview without the latest change)

      History is designed to record changes - so it is doing its job by adding a "modify xxxxx layer" after you make an adjustment.

      Dave

        jane-e
        Community Expert
        jane-eCommunity Expert
        Community Expert
        April 4, 2019

        tomhock  wrote

        How am I supposed to set an adjustment, clear an adjustment, or abandon an adjustment without a button on the dialog?  Why does the history now include all the steps I make in the dialog?  This isn't Illustrator, which I hate, right?

        Hi Tom,

        Illustrator does not have either Adjustment Layers or History, so the answer is no, Photoshop isn't Illustrator.

        • If you make adjustments destructively with a dialog box (Image menu), you will get an Okay button.
        • If you make adjustments non-destructively with the Adjustments panel, you will not.

        ~ Jane

        JJMack
        Community Expert
        JJMackCommunity Expert
        Community Expert
        April 3, 2019

        Try adjusting the properties panel when the adjustment layer is the current target.   The OK button is in Adjustment Dialog when they are being applied destructively to  a layer like a level adjustment.   That Adjustment actually changes the raster layer being adjusted.   Adjustment Layer are adjusted in the Properties Palette. I know nothing about Adobe other applications Photoshop is all I care to handle. History should record all the things you do in Photoshop that changes the state of you document.

        If you think too much is being recorded you should post some screen captures that shows the history palette and other panels and describe what you did that was recorded you think should not have been recorded in history.

        To adbandon an adjustment layer delete it or turn off its visibility.

        JJMack
        Terms & ConditionsAccessibility statement
        Using the community Terms of use Privacy Cookie preferences Do not sell or share my personal information ad choicesAdChoices