Skip to main content
Hosun
Inspiring
June 25, 2019
Answered

hamburger memu

  • June 25, 2019
  • 1 reply
  • 983 views

Hi,

Long ago, I got scripts.js from osgood_ for Roar Cycles 4. 

I applied the same js to Hosuns Portfolio 4 with the change in line 5.

But it doesn't work.

Would you help me?

Roar Cycles 4

Hosuns Portfolio 4

Hosun Kang

In the beginning, I wrote.

$('.menu-toggle').click(function(){

            $('.site-nav').toggleClass('site-nav--open');

            $(this).toggleClass('open');

})

But osgood's version makes the menu spread out more smoothly.

Message was edited by: Ben Pleysier to call out osgood_

This topic has been closed for replies.
Correct answer osgood_

In your 500px media query.

Change this:

.site-nav {

background-color: darksalmon;

width: 100%;

height: 0px;

overflow: hidden;

}

To this:

.site-nav {

background-color: darksalmon;

width: 100%;

display: none;

}

1 reply

osgood_Correct answer
Legend
June 25, 2019

In your 500px media query.

Change this:

.site-nav {

background-color: darksalmon;

width: 100%;

height: 0px;

overflow: hidden;

}

To this:

.site-nav {

background-color: darksalmon;

width: 100%;

display: none;

}

Hosun
HosunAuthor
Inspiring
June 25, 2019

A larger image to the previous question.

Hosun Kang

Jon Fritz
Community Expert
Community Expert
June 25, 2019

I agree with Osgood here, "Best" is pretty subjective. I find it "best" to use a:link, a:visited and a:hover in my projects.

As long as the ones you decide to use are in the correct order...

a:link

a:visited

a:hover

a:active

If any of these are in the wrong order, you'll get unexpected results on your site.

a:focus is not part of the "must be in the right order" group, but can be a helpful tool if you need to cater more to keyboard navigation.