I don't have time to go about testing it. but i have some quick recommendations just from taking a look.
clean out your for loop. the only things that should happen in a for loop should be things pertaining to that exact loop iteration. You have an include directive and a call to app.loadAction() inside the loop. since there's nothing unique about those lines, it's best to pull them outside the loop to increase efficiency and use less memory.
wrap your script in a container function to help avoid creating persistent global variables.
when you're writing your for loops, use 'var' when declaring the loop variable, otherwise you create a global variable that could be altered elsewhere and mess up the continuity of your loop. there's a decent chance this is where your infinite loop is happening. In fact, i just looked back at the function that you include, and that function also contains a for loop that redefines your global "i" variable at the beginning of the loop. your two for loops are stepping on each other, that's why you're getting an infinite loop.
try this out.
function container()
{
var sourceFolder = Folder.selectDialog();
// filesToProcess = sourceFolder.getFiles("*.ai");
var TypeList = prompt("Enter file types to act on","ai,eps,pdf,jpg,png","File Types");
var reg = new RegExp("\.(" + TypeList.replace(/,/g, '|') + ")$", 'i');
var filesToProcess = sourceFolder.getFiles(reg);
var x = 400;
var y = 300;
var w = 800;
var h = 600;
var userDesktop = Folder.desktop;
var f = new File(userDesktop+'/Satz 2.aia'); // make a file object first, using a string
function fitObjectToArtboardBounds()
{
var idoc = app.activeDocument;
var layers = idoc.layers;
var scriptID = "Random Select v0.2";
var selec = idoc.selection;
////
//always be careful looping elements at
//the document scope. this can lead to
//lots of problems
////
// if (idoc.selection.length == 0)
// {
// for (var i = 0; i < idoc.pageItems.length; i++)
// {
// idoc.pageItems.selected = true;
// }
// }
//try this for a little more reliability
for(var x=0,len=layers.length;x<len;x++)
{
layers.hasSelectedArtwork = true;
}
selec = idoc.selection;
if (selec.length == 1)
{
// get document bounds
var docw = idoc.width;
var doch = idoc.height;
var activeAB = idoc.artboards[idoc.artboards.getActiveArtboardIndex()]; // get active AB
docLeft = activeAB.artboardRect[0];
docTop = activeAB.artboardRect[1];
// get selection bounds
var sel = idoc.selection[0];
var selVB = sel.visibleBounds;
var selVw = selVB[2] - selVB[0];
var selVh = selVB[1] - selVB[3];
var selGB = sel.geometricBounds;
var selGw = selGB[2] - selGB[0];
var selGh = selGB[1] - selGB[3];
// get the difference between Visible & Geometric Bounds
var deltaX = selVw - selGw;
var deltaY = selVh - selGh;
if (sel.width > sel.height)
{
var newHeight = doch - deltaY;
var ratio = sel.height / newHeight;
sel.height = newHeight;
sel.width = sel.width / ratio;
//var newWidth = docw-deltaX;
//var ratio = sel.width / newWidth;
//sel.width = newWidth; // width is Geometric width, so we need to make it smaller...to accomodate the visible portion.
//sel.height = sel.height / ratio;
}
else
{
var newHeight = doch - deltaY;
var ratio = sel.height / newHeight;
sel.height = newHeight;
sel.width = sel.width / ratio;
}
sel.top = (doch / 2) - (sel.height / 2);
sel.left = (docw / 2) - (sel.width / 2);
app.doScript('Aktion1', 'Satz 3');
app.executeMenuCommand('fitall');
}
else
{
alert("select ONE object before running");
}
}
var userDesktop = Folder.desktop;
var g = new File(userDesktop+'/Satz 4.aia'); // make a file object first, using a string
app.loadAction (g); // the argument here is a file object
g = new File(userDesktop+'/Satz 3.aia'); // make a file object first, using a string
app.loadAction (g); // the argument here is a file object
// Create progress bar
var win = new Window("palette", "ProgressBar", [300, 150, 750, 280]);
win.pnl = win.add("panel", [10, 10, 440, 120], "Script Progress");
win.pnl.progBar = win.pnl.add("progressbar", [20, 35, 410, 60], 0, 100);
win.pnl.progBarLabel = win.pnl.add("statictext", [20, 20, 320, 35], "0%");
win.pnl.fileLabel = win.pnl.add("statictext", [20, 65, 410, 80], "File processed: none");
win.show();
// Increment through the files
for (var i=0; i < filesToProcess.length; i++) {
app.open(filesToProcess);
app.activeDocument.artboards[0].artboardRect = [x, -y, (x + w), -(y + h)];
// Update open file info
win.pnl.fileLabel.text = "File: " + app.activeDocument.name;
// win.pnl.fileLabel = "File: " + doc.path; // Show full path
win.update();
app.doScript ('Aktion3', 'Satz 4');
app.activeDocument.close();
// Update progress bar
win.pnl.progBar.value = parseInt( (i/filesToProcess.length)*100 );
win.pnl.progBarLabel.text = win.pnl.progBar.value+"%";
win.update();
}
win.pnl.progBar.value = 100;
win.pnl.progBarLabel.text = win.pnl.progBar.value+"%";
win.update();
alert('Done!');
// Close progress bar
win.close();
// Update progress bar
win.pnl.progBar.value = parseInt( (i/filesToProcess.length)*100 );
win.pnl.progBarLabel.text = win.pnl.progBar.value+"%";
win.update();
win.pnl.progBar.value = 100;
win.pnl.progBarLabel.text = win.pnl.progBar.value+"%";
win.update();
alert('Done!');
// Close progress bar
win.close();
}
container();
1 Correct answer
10
Replies
AdChoices