Hi @dublove the variable is out of scope. Roughly speaking, a variable declared in a Function 1 cannot be accessed from Function 2 unless (a) the variable is declared as a global—not good practice as a rule, or (b) the Function 2 is declared inside Function 1, or (c) the variable is passed to Function 2 as a parameter.
To fix your code, I just moved several functions up into the myDisplayDialog function like option (b) above.
There are cleaner ways to do it, but this was quick. If you are keen to learn my preferred approach, see my other scripts where I use a `settings` variable and a `ui` function. This structure allows me to easily run the script without the UI, for example.
- Mark
/* CropMarks.jsx
Draws crop and/or registration marks around the selected object or objects.
For more on InDesign scripting, go to http://www.adobe.com/products/indesign/scripting.html
or visit the InDesign Scripting User to User forum at http://www.adobeforums.com
Modified by dublove
*/
function main() {
if (app.documents.length === 0)
return alert("Ple请打开一个文档,选择一个物体再试,呵呵");
if (app.selection.length == 0)
return alert("请选择一个物体再试,呵呵.");
switch (app.selection[0].constructor.name) {
case "Rectangle":
case "Oval":
case "Polygon":
case "GraphicLine":
case "Group":
case "TextFrame":
case "Button":
myDisplayDialog();
break;
default:
alert("选择一个页面消息再试.");
break;
}
function myDisplayDialog() {
var myDialog = app.dialogs.add({ name: "DrawCropMarks" });
with (myDialog) {
with (dialogColumns.add()) {
var myCropMarksGroup = enablingGroups.add({ staticLabel: "CropMarks", checkedState: true });
with (myCropMarksGroup) {
with (borderPanels.add()) {
staticTexts.add({ staticLabel: "Option:" });
with (dialogColumns.add()) {
staticTexts.add({ staticLabel: "lengths:" });
staticTexts.add({ staticLabel: "offset:" });
staticTexts.add({ staticLabel: "Thickness:" });
staticTexts.add({ staticLabel: "Spine:" });
staticTexts.add({ staticLabel: "Mouth:" });
}
with (dialogColumns.add()) {
//看到的界面单位是毫米，运算前的值为点，所以要奖毫米折算为点（即，毫米值乘于2.8345）进行
var myCropMarkLengthField = measurementEditboxes.add({ editValue: (2.8345 * 3), editUnits: MeasurementUnits.millimeters });
var myCropMarkOffsetField = measurementEditboxes.add({ editValue: (2.8345 * 3), editUnits: MeasurementUnits.millimeters });
var myCropMarkWidthField = measurementEditboxes.add({ editValue: (2.8345 * 0.1), editUnits: MeasurementUnits.millimeters });
//新增 书脊 勒口
var mySpineWidthField = measurementEditboxes.add({ editValue: (2.8345 * 20), editUnits: MeasurementUnits.millimeters });
var myMouthWidthField = measurementEditboxes.add({ editValue: (2.8345 * 83), editUnits: MeasurementUnits.millimeters });
}
}
}
var myRegMarksGroup = enablingGroups.add({ staticLabel: "alignment mark", checkedState: true });
with (myRegMarksGroup) {
with (borderPanels.add()) {
staticTexts.add({ staticLabel: "Option:" });
with (dialogColumns.add()) {
staticTexts.add({ staticLabel: "inner radius:" });
staticTexts.add({ staticLabel: "outer radius:" });
staticTexts.add({ staticLabel: "offset:" });
}
with (dialogColumns.add()) {
var myRegMarkInnerRadiusField = measurementEditboxes.add({ editValue: (2.8345 * 1), editUnits: MeasurementUnits.millimeters });
var myRegMarkOuterRadiusField = measurementEditboxes.add({ editValue: (2.8345 * 1.5), editUnits: MeasurementUnits.millimeters });
var myRegMarkOffsetField = measurementEditboxes.add({ editValue: 0, editUnits: MeasurementUnits.millimeters });
}
}
}
with (borderPanels.add()) {
staticTexts.add({ staticLabel: "Range for drawing:" });
var myRangeButtons = radiobuttonGroups.add();
with (myRangeButtons) {
radiobuttonControls.add({ staticLabel: "Every object", checkedState: true });
radiobuttonControls.add({ staticLabel: "whole selection" });
}
}
}
}
var myReturn = myDialog.show();
//Get the values from the dialog box.从对话框获取
var myDoCropMarks = myCropMarksGroup.checkedState;
var myDoRegMarks = myRegMarksGroup.checkedState;
var myCropMarkLength = myCropMarkLengthField.editValue;
var myCropMarkOffset = myCropMarkOffsetField.editValue;
var myCropMarkWidth = myCropMarkWidthField.editValue;
var myRegMarkInnerRadius = myRegMarkInnerRadiusField.editValue;
var myRegMarkOuterRadius = myRegMarkOuterRadiusField.editValue;
var myRegMarkOffset = myRegMarkOffsetField.editValue;
//书脊和勒口
var mySpineWidth = mySpineWidthField.editValue;
var myMouthWidth = myMouthWidthField.editValue;
var myRange = myRangeButtons.selectedButton;
myDialog.destroy();
if (!myReturn)
return;
//"||" is logical OR in JavaScript.
if (!myDoCropMarks && !myDoRegMarks)
return alert("No printers marks were selected.");
myDrawPrintersMarks(myRange, myDoCropMarks, myDoRegMarks, myCropMarkLength, myCropMarkOffset, myCropMarkWidth, myRegMarkInnerRadius, myRegMarkOuterRadius, myRegMarkOffset);
// dublove, keep all these functions in the same scope (inside the myDisplayDialog function):
function myDrawPrintersMarks(myRange, myDoCropMarks, myDoRegMarks, myCropMarkLength, myCropMarkOffset, myCropMarkWidth, myRegMarkInnerRadius, myRegMarkOuterRadius, myRegMarkOffset) {
var myBounds, myX1, myY1, myX2, myY2, myObject;
var myDocument = app.activeDocument;
var myOldRulerOrigin = myDocument.viewPreferences.rulerOrigin;
myDocument.viewPreferences.rulerOrigin = RulerOrigin.spreadOrigin;
//Save the current measurement units.
//var oldMeasurementUnits=myDocument.viewPreferences.horizontalMeasurementUnits
//因有些函数默认计算单位为点，所以运算前要改为点，运算完成后可改回习惯毫米
var oldMeasurementUnits = myDocument.viewPreferences.horizontalMeasurementUnits
myDocument.viewPreferences.horizontalMeasurementUnits = MeasurementUnits.points;
myDocument.viewPreferences.verticalMeasurementUnits = MeasurementUnits.points;
//Create a layer to hold the printers marks (if it does not already exist).
var myLayer = myDocument.layers.item("myCropMarks");
try {
myLayerName = myLayer.name;
}
catch (myError) {
var myLayer = myDocument.layers.add({ name: "myCropMarks" });
}
//Get references to the Registration color and the None swatch.
var myRegistrationColor = myDocument.colors.item("Registration");
var myNoneSwatch = myDocument.swatches.item("None");
//Process the objects in the selection.
myBounds = myDocument.selection[0].visibleBounds;
for (var myCounter = 0; myCounter < myDocument.selection.length; myCounter++) {
myObject = myDocument.selection[myCounter];
myBounds = myObject.visibleBounds;
//Set up some initial bounding box values.
if ((myRange != 0) && (myCounter == 0)) {
myX1 = myBounds[1];
myY1 = myBounds[0];
myX2 = myBounds[3];
myY2 = myBounds[2];
}
if (myRange == 0) {
if (myDoCropMarks == true) {
myDrawCropMarks(myBounds[1], myBounds[0], myBounds[3], myBounds[2], myCropMarkLength, myCropMarkOffset, myCropMarkWidth, myRegistrationColor, myNoneSwatch, myLayer);
}
if (myDoRegMarks == true) {
myDrawRegMarks(myBounds[1], myBounds[0], myBounds[3], myBounds[2], myRegMarkOffset, myRegMarkInnerRadius, myRegMarkOuterRadius, myCropMarkWidth, myRegistrationColor, myNoneSwatch, myLayer);
}
}
else {
//Compare the bounds values to the stored bounds.
//If a given bounds value is less than (for x1 and y1) or
//greater than (for x2 and y2) the stored value,
//then replace the stored value with the bounds value.
if (myBounds[0] < myY1) {
myY1 = myBounds[0];
}
if (myBounds[1] < myX1) {
myX1 = myBounds[1];
}
if (myBounds[2] > myY2) {
myY2 = myBounds[2];
}
if (myBounds[3] > myX2) {
myX2 = myBounds[3];
}
}
}
if (myRange != 0) {
if (myDoCropMarks == true) {
myDrawCropMarks(myX1, myY1, myX2, myY2, myCropMarkLength, myCropMarkOffset, myCropMarkWidth, myRegistrationColor, myNoneSwatch, myLayer);
}
if (myDoRegMarks == true) {
myDrawRegMarks(myX1, myY1, myX2, myY2, myRegMarkOffset, myRegMarkInnerRadius, myRegMarkOuterRadius, myCropMarkWidth, myRegistrationColor, myNoneSwatch, myLayer);
}
}
myDocument.viewPreferences.rulerOrigin = myOldRulerOrigin;
//Set the measurement units back to their original state.
//运算完成，将标尺单位改为习惯毫米
myDocument.viewPreferences.horizontalMeasurementUnits = oldMeasurementUnits;
myDocument.viewPreferences.verticalMeasurementUnits = oldMeasurementUnits;
}
function myDrawCropMarks(myX1, myY1, myX2, myY2, myCropMarkLength, myCropMarkOffset, myCropMarkWidth, myRegistrationColor, myNoneSwatch, myLayer) {
var myXCenterA = myX1 + ((myX2 - myX1) / 2);
var myYCenterA = myY1 + ((myY2 - myY1) / 2);
var mySpineLeft = myXCenterA - (20 / 2);
var mySpineRight = myXCenterA + (20 / 2);
//Drawspinee画书脊线 Test--------,Temporarily replace it with a constant
//myDrawLine([myY1, myXCenterA -(20/2), myY1-(myCropMarkLength), myXCenterA -(20/2)], myCropMarkWidth, myRegistrationColor, myNoneSwatch, myLayer);
//myDrawLine([myY1, myXCenterA +(20/2), myY1-(myCropMarkLength), myXCenterA +(20/2)], myCropMarkWidth, myRegistrationColor, myNoneSwatch, myLayer);
//myDrawLine([myY2, myXCenterA -(20/2), myY2+(myCropMarkLength), myXCenterA -(20/2)], myCropMarkWidth, myRegistrationColor, myNoneSwatch, myLayer);
//myDrawLine([myY2, myXCenterA +(20/2), myY2+(myCropMarkLength), myXCenterA +(20/2)], myCropMarkWidth, myRegistrationColor, myNoneSwatch, myLayer);
//Drawmouth 画勒口线
myDrawLine([myY1, myX1 + (myMouthWidth), myY1 - (myCropMarkLength), myX1 + (myMouthWidth)], myCropMarkWidth, myRegistrationColor, myNoneSwatch, myLayer);
myDrawLine([myY1, myXCenterA + (20 / 2), myY1 - (myCropMarkLength), myXCenterA + (20 / 2)], myCropMarkWidth, myRegistrationColor, myNoneSwatch, myLayer);
//Upper left crop mark pair.左上角
myDrawLine([myY1, myX1, myY1, myX1 - (myCropMarkLength)], myCropMarkWidth, myRegistrationColor, myNoneSwatch, myLayer);
myDrawLine([myY1 + myCropMarkOffset, myX1, myY1 + myCropMarkOffset, myX1 - (myCropMarkLength)], myCropMarkWidth, myRegistrationColor, myNoneSwatch, myLayer);
myDrawLine([myY1, myX1, myY1 - (myCropMarkLength), myX1], myCropMarkWidth, myRegistrationColor, myNoneSwatch, myLayer);
myDrawLine([myY1, myX1 + myCropMarkOffset, myY1 - (myCropMarkLength), myX1 + myCropMarkOffset], myCropMarkWidth, myRegistrationColor, myNoneSwatch, myLayer);
//Lower left crop mark pair.左下角
myDrawLine([myY2, myX1, myY2, myX1 - (myCropMarkLength)], myCropMarkWidth, myRegistrationColor, myNoneSwatch, myLayer);
myDrawLine([myY2 - myCropMarkOffset, myX1, myY2 - myCropMarkOffset, myX1 - (myCropMarkLength)], myCropMarkWidth, myRegistrationColor, myNoneSwatch, myLayer);
myDrawLine([myY2, myX1, myY2 + myCropMarkLength, myX1], myCropMarkWidth, myRegistrationColor, myNoneSwatch, myLayer);
myDrawLine([myY2, myX1 + myCropMarkOffset, myY2 + myCropMarkLength, myX1 + myCropMarkOffset], myCropMarkWidth, myRegistrationColor, myNoneSwatch, myLayer);
//Upper right crop mark pair.右上角
myDrawLine([myY1, myX2, myY1, myX2 + myCropMarkLength], myCropMarkWidth, myRegistrationColor, myNoneSwatch, myLayer);
myDrawLine([myY1 + myCropMarkOffset, myX2 - myCropMarkOffset + myCropMarkOffset, myY1 + myCropMarkOffset, myX2 - myCropMarkOffset + myCropMarkOffset + myCropMarkLength], myCropMarkWidth, myRegistrationColor, myNoneSwatch, myLayer);
myDrawLine([myY1, myX2, myY1 - (myCropMarkLength), myX2], myCropMarkWidth, myRegistrationColor, myNoneSwatch, myLayer);
myDrawLine([myY1, myX2 - myCropMarkOffset, myY1 - (myCropMarkLength), myX2 - myCropMarkOffset], myCropMarkWidth, myRegistrationColor, myNoneSwatch, myLayer);
//Lower rigth crop mark pair.右下角
myDrawLine([myY2, myX2, myY2, myX2 + myCropMarkLength], myCropMarkWidth, myRegistrationColor, myNoneSwatch, myLayer);
myDrawLine([myY2 - myCropMarkOffset, myX2, myY2 - myCropMarkOffset, myX2 + myCropMarkLength], myCropMarkWidth, myRegistrationColor, myNoneSwatch, myLayer);
myDrawLine([myY2, myX2, myY2 + myCropMarkLength, myX2], myCropMarkWidth, myRegistrationColor, myNoneSwatch, myLayer);
myDrawLine([myY2, myX2 - myCropMarkOffset, myY2 + myCropMarkLength, myX2 - myCropMarkOffset], myCropMarkWidth, myRegistrationColor, myNoneSwatch, myLayer);
}
//画圆十字
function myDrawRegMarks(myX1, myY1, myX2, myY2, myRegMarkOffset, myRegMarkInnerRadius, myRegMarkOuterRadius, myCropMarkWidth, myRegistrationColor, myNoneSwatch, myLayer) {
var myBounds
var myXCenter = myX1 + ((myX2 - myX1) / 2);
var myYCenter = myY1 + ((myY2 - myY1) / 2);
var myTargetCenter = myRegMarkOffset + (myRegMarkOuterRadius);
//Top registration target.上方圆
myBounds = [myY1 - (myTargetCenter + myRegMarkInnerRadius), myXCenter - myRegMarkInnerRadius, (myY1 - myTargetCenter) + myRegMarkInnerRadius, myXCenter + myRegMarkInnerRadius];
myDrawTarget(myBounds, myCropMarkWidth, myRegistrationColor, myNoneSwatch, myLayer);
myBounds = [myY1 - (myTargetCenter + myRegMarkOuterRadius), myXCenter, (myY1 - myTargetCenter) + myRegMarkOuterRadius, myXCenter]
myDrawLine(myBounds, myCropMarkWidth, myRegistrationColor, myNoneSwatch, myLayer);
myBounds = [myY1 - myTargetCenter, myXCenter - myRegMarkOuterRadius, myY1 - myTargetCenter, myXCenter + myRegMarkOuterRadius]
myDrawLine(myBounds, myCropMarkWidth, myRegistrationColor, myNoneSwatch, myLayer);
//Left registration target.左侧圆
myBounds = [myYCenter - myRegMarkInnerRadius, myX1 - (myTargetCenter + myRegMarkInnerRadius), myYCenter + myRegMarkInnerRadius, (myX1 - myTargetCenter) + myRegMarkInnerRadius];
myDrawTarget(myBounds, myCropMarkWidth, myRegistrationColor, myNoneSwatch, myLayer);
myBounds = [myYCenter, myX1 - (myTargetCenter + myRegMarkOuterRadius), myYCenter, myX1 - myRegMarkOffset]
myDrawLine(myBounds, myCropMarkWidth, myRegistrationColor, myNoneSwatch, myLayer);
myBounds = [myYCenter - myRegMarkOuterRadius, myX1 - myTargetCenter, myYCenter + myRegMarkOuterRadius, myX1 - myTargetCenter]
myDrawLine(myBounds, myCropMarkWidth, myRegistrationColor, myNoneSwatch, myLayer);
//Bottom registration target.下方圆
myBounds = [myY2 + (myTargetCenter - myRegMarkInnerRadius), myXCenter - myRegMarkInnerRadius, myY2 + myTargetCenter + myRegMarkInnerRadius, myXCenter + myRegMarkInnerRadius];
myDrawTarget(myBounds, myCropMarkWidth, myRegistrationColor, myNoneSwatch, myLayer);
myBounds = [myY2 + myRegMarkOffset, myXCenter, myY2 + myTargetCenter + myRegMarkOuterRadius, myXCenter]
myDrawLine(myBounds, myCropMarkWidth, myRegistrationColor, myNoneSwatch, myLayer);
myBounds = [myY2 + myTargetCenter, myXCenter - myRegMarkOuterRadius, myY2 + myTargetCenter, myXCenter + myRegMarkOuterRadius]
myDrawLine(myBounds, myCropMarkWidth, myRegistrationColor, myNoneSwatch, myLayer);
//Right registration target.右侧圆
myBounds = [myYCenter - myRegMarkInnerRadius, myX2 + (myTargetCenter - myRegMarkInnerRadius), myYCenter + myRegMarkInnerRadius, myX2 + myTargetCenter + myRegMarkInnerRadius];
myDrawTarget(myBounds, myCropMarkWidth, myRegistrationColor, myNoneSwatch, myLayer);
myBounds = [myYCenter, myX2 + myRegMarkOffset, myYCenter, myX2 + myTargetCenter + myRegMarkOuterRadius]
myDrawLine(myBounds, myCropMarkWidth, myRegistrationColor, myNoneSwatch, myLayer);
myBounds = [myYCenter - myRegMarkOuterRadius, myX2 + myTargetCenter, myYCenter + myRegMarkOuterRadius, myX2 + myTargetCenter]
myDrawLine(myBounds, myCropMarkWidth, myRegistrationColor, myNoneSwatch, myLayer);
}
function myDrawLine(myBounds, myStrokeWeight, myRegistrationColor, myNoneSwatch, myLayer) {
app.activeWindow.activeSpread.graphicLines.add(myLayer, undefined, undefined, { strokeWeight: myStrokeWeight, fillColor: myNoneSwatch, strokeColor: myRegistrationColor, geometricBounds: myBounds })
}
function myDrawTarget(myBounds, myStrokeWeight, myRegistrationColor, myNoneSwatch, myLayer) {
app.activeWindow.activeSpread.ovals.add(myLayer, undefined, undefined, { strokeWeight: myStrokeWeight, fillColor: myNoneSwatch, strokeColor: myRegistrationColor, geometricBounds: myBounds })
}
}
};
app.doScript(main, ScriptLanguage.JAVASCRIPT, undefined, UndoModes.ENTIRE_SCRIPT, 'Add Cropmarks');
Edit 2025-03-28: typo (removed erroneous reference to `settings`)
2 Correct answers
10
Replies
AdChoices