1 Correct answer
One way:
app.runMenuItem(stringIDToTypeID('placedLayerEditContents'));
Explore related tutorials & articles
55
Replies
The function is complete. A function is not a complete script. And your one line has problems it will work only if the active layer is a smart object layer and the object is supported by photoshop. It will fail in all other cases. Here no active layer and also with an active layer that is a smar object layer with an object that photoshop does not support. In the case vector smart object. That object opened in Chrome on my machine. It an SVG file create by Adobe AI.
The code does not open open a smart object layer's object. The code test a smart object layer to see if you use open smart object layer object to open the object into Photoshop. If you pass your smart object layer that has a PSB object it would return true you can. Your line of code edits Photoshop active document active layers smart object.
app.runMenuItem(stringIDToTypeID('placedLayerEditContents'));
There are problems with that if not user properly. If the active layers is not a smart object layers the lines will through a script error. If the active layers is a smart object layers and the object is not a Photoshop supported object it will not fail. However, the script will lose control and not be able to edit the object for it will not open in Photoshop. An other Application like AI or a Plug-In like ACR will be what open the object not Photoshop. If you know active layer is a smart object layer and the layer's object is a Photoshop object your code will work. I your not sure of what kind of object the smart object is you need r-bin code or your script will fail its Murphy's law.
Your one line should be a if statement. With or without the else.
if (objectIsPsObject(activeDocument.activeLayer)) app.runMenuItem(stringIDToTypeID('placedLayerEditContents'));
else alert(activeDocument.activeLayer.name + " Object can not be edited using Photoshop its unchanged.");
I do not know JavaScript or Photoshop Scripting. I do have a programming background so I hack at code. You are learning you need to read more code to get a better understanding of what is what. It should not be hard for you read that function to see all it does is return True or False.
Thanks, for the semi reply.
I know how most of it works, the issue is not related to what your explaining though. My issue is that i run an edit command and then after that it should place an image into that smartobject file. I already know the scale so i added that to the place command. Im thinking of either making a dialog for that. But i also got a function which get the bounds of the document i then get the bound of the placed file, with those two i can figure out the proper scaling i need.
The issue is that photoshop runs all the code before that smartobject is actually opened. I need photoshop to wait until that document is open. I feels like its running asynchronous, if i named it correct. Its running multiple actions before 1 is finished.
here's an image from a Medium article as an example and to clearify what i think is happening
My work around for now is have that smartobject open already, then i simply use a switch command and save in between. This works, i let it run a couple times and each time i got the proper exports.
Im just going insane of why i had it working at one point andcant seem to replicate that code. I used scriptlistener and scriptfix to get most parts i need to edit the files. Than added some extras for functionality.
thanks once more for taking the time to look at it. I also had the same idea what you did with the while loop, but its goes into never ending loop. The script simply runs to fast for the GUI to even do anything. I tried a couple variations like if doc lenght isnt 2 then rerun the same function. That also goes into this never ending loop and i need to escape running script and in some cases even need force end photoshop because i cant get the script to stop.
PS i forgot to mention it earlier, your open smartobject function also throws this error. There i something not correct in the code, perhaps its missing curly brackets. I do see these one line if states before and sometimes they work. However i think its "throw" which is causing this error. Is this perhaps because i use the extension JSX vs JS?!
Ive started a fresh new file with some test code in there to check if the editcontent works. PS it will always work if you an alert in there, somehow when i use that the GUI does update properly. But running file without will not run the script properly.
In this current state, your function throws a script error which we see in the image above.
The way i run this is have the mockup, so the PSD with the phone. I select the layer which is red (smartobject). I run the script, it will prompt you to select images, For a test i made those screen image in that zip file. Select one or a couple. It will then prompt for an export folder. For now ive turned of the save function since the main function doesnt even run properly.
#target photoshop
var docRef = app.activeDocument;
var actLayer = docRef.activeLayer;
function cTID(s) {
return app.charIDToTypeID(s);
};
function sTID(s) {
return app.stringIDToTypeID(s);
};
////// open smart object //////
function openSmartObject(theLayer) {
current = app.activeDocument;
alert(theLayer)
if (theLayer.kind == "LayerKind.SMARTOBJECT") {
runMenuItem(stringIDToTypeID('placedLayerEditContents'));
if (current == app.activeDocument) {
try {
var r = new ActionReference();
r.putProperty(stringIDToTypeID("property"), stringIDToTypeID("smartObject"));
r.putIdentifier(stringIDToTypeID("layer"), theLayer.id);
var name = executeActionGet(r).getObjectValue(stringIDToTypeID("smartObject")).getString(stringIDToTypeID("fileReference"));
} catch (e) {
throw theLayer + " Smart Object Did not Open";
}
var workFile = new File(Folder.temp + "/" + name); // May work for both Windows and Mac
if (workFile.exists) app.open(File(workFile));
if (current == app.activeDocument) throw theLayer + " Smart Object Did not Open";
}
} else {
alert(theLayer +" is not a smartobject");
}
return app.activeDocument
};
// Check if object is PS
// R-Bin - JJ Mack
// https://community.adobe.com/t5/photoshop/extendscript-photoshop-edit-contents-smart-layer/m-p/10706542#M273949
function objectIsPsObject(SOlayer) {
//Thanks to r-bin
var ext = smartobject_file_ext(SOlayer);
var rc = true;
switch (ext)
{
case "nef":
case "cr3":
case "cr2":
case "crw":
case "raf":
case "orf":
case "mrw":
case "dcr":
case "mos":
case "raw":
case "pef":
case "srf":
case "dng":
case "x3f":
case "erf":
case "sr2":
case "kdc":
case "mfw":
case "mef":
case "arw":
case "nrw":
case "rw2":
case "rwl":
case "iiq":
case "3fr":
case "fff":
case "srw":
case "ai":
case "svg":
case "pdf":
case "esp":
rc = false;
break;
case "error":
rc = false;
break;
default:
rc = true;
break;
}
return rc;
}
function smartobject_file_ext(layer) {
try {
var r = new ActionReference();
r.putProperty(stringIDToTypeID("property"), stringIDToTypeID("smartObject"));
r.putIdentifier(stringIDToTypeID("layer"), layer.id);
var name = executeActionGet(r).getObjectValue(stringIDToTypeID("smartObject")).getString(stringIDToTypeID("fileReference"));
var n = name.lastIndexOf(".");
if (n < 0) return "";
return name.substr(n+1).toLowerCase();
}
catch (e) { return "error"; }
}
function placeImage(newFile){
// app.refresh(); // doesnt work
// app.redraw();// doesnt work
// waitMoment();
// $.sleep(500)
// Switch document
// var desc111 = new ActionDescriptor();
// var ref13 = new ActionReference();
// ref13.putOffset( cTID('Dcmn'), 1 );
// desc111.putReference( cTID('null'), ref13 );
// desc111.putInteger( cTID('DocI'), 344 );
// executeAction( cTID('slct'), desc111, DialogModes.NO );
// Place images
// alert(newFile)
var desc174 = new ActionDescriptor();
desc174.putInteger( cTID('Idnt'), 885 );
desc174.putPath( cTID('null'), new File(newFile));
desc174.putBoolean( cTID('Lnkd'), true );
desc174.putEnumerated( cTID('FTcs'), cTID('QCSt'), cTID('Qcsa') );
var desc175 = new ActionDescriptor();
desc175.putUnitDouble( cTID('Hrzn'), cTID('#Pxl'), 0.000000 );
desc175.putUnitDouble( cTID('Vrtc'), cTID('#Pxl'), 0.000000 );
desc174.putObject( cTID('Ofst'), cTID('Ofst'), desc175 );
desc174.putUnitDouble( cTID('Wdth'), cTID('#Prc'), 234.782609 ); // i know the scale > this will make the image fit the SO file
desc174.putUnitDouble( cTID('Hght'), cTID('#Prc'), 234.697509 ); // i know the scale > this will make the image fit the SO file
executeAction( cTID('Plc '), desc174, DialogModes.NO );
}
function exportMockupDesigns() {
// Get OS
// fromt "_LastLogEntry.jsx"
isWindows = function() {
return $.os.match(/windows/i);
};
isMac = function() {
return !isWindows();
};
var osPath = (isMac() ? '/' : "/"); // resolve windows vs osx paths
// alert(isMac())
if (app.documents.length > 0) {
var myDocument = app.activeDocument;
var theName = myDocument.name.match(/(.*)\.[^\.]+$/)[1];
var thePath = myDocument.path;
var theLayer = myDocument.activeLayer;
// jpg options;
var jpgopts = new JPEGSaveOptions();
jpgopts.embedProfile = true;
jpgopts.formatOptions = FormatOptions.STANDARDBASELINE;
jpgopts.matte = MatteType.NONE;
jpgopts.quality = 8;
// check if layer is smart object;
if (theLayer.kind != "LayerKind.SMARTOBJECT") {
alert("selected layer is not a smart object")
} else if (objectIsPsObject(actLayer) != true) {
alert("The SmartOjbect is not a PSB or PSD file")
return 'cancel'; // quit, returning 'cancel' (dont localize) makes the actions palette not record our script
} else {
// select files;
if ($.os.search(/windows/i) != -1) {
var theFiles = File.openDialog("please select files", "*.psd;*.tif;*.jpg;*.jpeg;", true)
} else {
var theFiles = File.openDialog("please select files", getFiles, true)
};
// select Folder;
// var theFolder = Folder.selectDialog("select folder");
if (theFiles) {
// var theFiles = theFolder.getFiles(/\.(jpg|tif|eps|psd|png)$/i);
// Select destination folder
var destinationFolder = Folder.selectDialog("Please select a destination folder");
// work through the array;
for (var m = 0; m < theFiles.length; m++) {
// replace smart object;
openSmartObject(theLayer);
// app.refresh()
// alert(editSO)
// waitMoment()
// $.sleep(500)
// waitForRedraw();// notworking
placeImage(theFiles[m]);
// var theNewName = theFiles[m].name.match(/(.*)\.[^\.]+$/)[1];
//save jpg;
// myDocument.saveAs((new File(destinationFolder.toString() + "/" + theName + "_" + theNewName + ".jpg")), jpgopts, true);
// }
}
};
}
};
////// get psds, tifs and jpgs from files //////
function getFiles(theFile) {
if (theFile.name.match(/\.(psd|tif|png|jpg|jpeg)$/i) != null || theFile.constructor.name == "Folder") {
return true
};
};
};
exportMockupDesigns();
AdChoices