1 Correct answer
After removing the line
descriptor.putObject( s2t( "replaceLayer" ), s2t( "placeEvent" ), descriptor );everything worked perfectly!
That is strange, I get the same results with or without that line... However, you are correct that it doesn't appear to be required. I trimmed away a lot of unnecessary code that was recorded by the ScriptingListener plugin but missed that one.
...I also have an additional question that I hope you could help with. Is there a way to determine if a layer is o
Explore related tutorials & articles
28
Replies
After removing the line
descriptor.putObject( s2t( "replaceLayer" ), s2t( "placeEvent" ), descriptor );everything worked perfectly!
That is strange, I get the same results with or without that line... However, you are correct that it doesn't appear to be required. I trimmed away a lot of unnecessary code that was recorded by the ScriptingListener plugin but missed that one.
I also have an additional question that I hope you could help with. Is there a way to determine if a layer is of the type 'frame'? I'm looking to further refine my script and this piece of information would be incredibly helpful.
By @Adi1231234
Yes, I can help you there.
I know that you are new to scripting, so let me try to explain... In the legacy ExtendScript used by Photoshop before the new UXP scripting, there were two types of code:
* ExtendScript Document Object Model code (DOM)
* ExtendScript Action Manager code (AM)
DOM code is high-level, more "user friendly" and legible than AM code, which is low-level, more like "machine language". Unfortunately, DOM code doesn't cover many areas of Photoshop, so we have to use AM code. AM code can sometimes provide performance benefits over DOM code, it doesn't matter that the code is more verbose than DOM.
The previous code that I provided to place an image is AM code, which has been greatly simplified from the source and placed into a JavaScript Function.
Now that I have given you some background context, it's time to answer your question regarding checking/testing that the active layer is a Frame.
In the standard DOM code, Adobe shares the same entry for Layer Groups, Artboards and Frames. This is the
if (app.activeDocument.activeLayer.typename == "LayerSet") {
placeInSelectedFrame(File.openDialog("Select the file to place into the Frame:"), false);
} else {
alert("The layer '" + app.activeDocument.activeLayer.name + "' isn't a Frame layer...");
}
function placeInSelectedFrame(theFile, linked) {
function s2t(s) {
return app.stringIDToTypeID(s);
}
var descriptor = new ActionDescriptor();
descriptor.putPath(s2t("null"), theFile); // File path
descriptor.putBoolean(s2t("linked"), linked); // Linked/embedded boolean
descriptor.putEnumerated(s2t("freeTransformCenterState"), s2t("quadCenterState"), s2t("QCSAverage")); // Place and fit
executeAction(s2t("placeEvent"), descriptor, DialogModes.NO);
}
However, if you need the script to be able to differentiate between a Frame and not a Layer Group, then you need more complex AM code:
if (isFrame()) {
placeInSelectedFrame(File.openDialog("Select the file to place into the Frame:"), false);
} else {
alert("The layer '" + app.activeDocument.activeLayer.name + "' isn't a Frame layer...");
}
function placeInSelectedFrame(theFile, linked) {
function s2t(s) {
return app.stringIDToTypeID(s);
}
var descriptor = new ActionDescriptor();
descriptor.putPath(s2t("null"), theFile); // File path
descriptor.putBoolean(s2t("linked"), linked); // Linked/embedded boolean
descriptor.putEnumerated(s2t("freeTransformCenterState"), s2t("quadCenterState"), s2t("QCSAverage")); // Place and fit
executeAction(s2t("placeEvent"), descriptor, DialogModes.NO);
}
function isFrame() {
// modified from a script by greless with hints from jazz-y!
try {
var r = new ActionReference();
r.putEnumerated(stringIDToTypeID('layer'), stringIDToTypeID('ordinal'), stringIDToTypeID('targetEnum'));
var options = executeActionGet(r);
return options.hasKey(stringIDToTypeID('framedGroup')); // test for the required key, returns true or false
} catch (e) {}
}
Before I send over these examples, I’m curious—have you had the opportunity to test the function on your end with similar frame layers? And if so, did it perform correctly for you?
By @Adi1231234
Yes, I tested the original 3 scripts to check/test that an active layer is either a group, frame or artboard and have not encountered a situation where they return a false result.
@Adi1231234 – Apparently it depends on whether the frame or image has focus:
So, I believe that an additional step is required to ensure that the frame and not the image are targeted.
Looking at the AM code recorded when either the frame or the image is selected:
var idselect = stringIDToTypeID( "select" );
var desc300 = new ActionDescriptor();
var idnull = stringIDToTypeID( "null" );
var ref22 = new ActionReference();
var idlayer = stringIDToTypeID( "layer" );
ref22.putName( idlayer, "11 Frame" ); // selected by name
desc300.putReference( idnull, ref22 );
var idmakeVisible = stringIDToTypeID( "makeVisible" );
desc300.putBoolean( idmakeVisible, false );
var idlayerID = stringIDToTypeID( "layerID" );
executeAction( idselect, desc300, DialogModes.NO );
// =======================================================
var idselect = stringIDToTypeID( "select" );
var desc301 = new ActionDescriptor();
var idnull = stringIDToTypeID( "null" );
var ref23 = new ActionReference();
var idlayer = stringIDToTypeID( "layer" );
ref23.putName( idlayer, "11" ); // selected by name
desc301.putReference( idnull, ref23 );
var idmakeVisible = stringIDToTypeID( "makeVisible" );
desc301.putBoolean( idmakeVisible, false );
var idlayerID = stringIDToTypeID( "layerID" );
executeAction(idselect, desc301, DialogModes.NO);
The challenge will be in finding the frame layer name and not the image name in the targeted layer to use with the putName string. Unless there is another way using the layer ID or Index.
Further clues:
This could be a good hack:
app.activeDocument.activeLayer = app.activeDocument.activeLayer.parent;
Quite peculiarly, after running the code you shared on the PSD I forwarded previously, it resulted in an alert stating all the layers are not frames. Are you certain this worked for you?
If it worked for you, how is it possible that it doesn't work for me? Could there be differences in the Photoshop versions? Or discrepancies in the execution method? @Stephen_A_Marsh
v2024, File > Scripts > Browse
AdChoices