Looping with threads - java.lang.NoSuchMethodException: coldfusion.runtime.CFDummyComponent.<init>()

I may have found an important piece of puzzle. There appears to be a trend that the error occurs when a service object is passed into the thread attributes. The thread service is wired into other services, which also have their own dependent services. There are cases where a service that calls threadService.runAll() passes one of its dependencies into a thread's data for the thread's closure to use. I initially thought the error was saying that the java level thread object couldn't be instantiated but closer examination of the stack trace has me rethinking that. I see it goes through duplicate, which suggests to me that the exception happened when the thread attributes were being duplicated to pass into the thread, and the services being passed in actually don't have an init method defined. Still, I'm not sure how to explain why the application can be fine for several weeks then all of a sudden get stuck on this error. I also don't know how to verify my analysis because I still haven't been able to get this error to come up running controlled test cases.

I see two possible inconsistencies:

1.  closure = variables.factory() = doForItem. Yet doForItem is a function, whereas factory is the result of an invoked function. Unless, of course, factory() returns a closure, which may work as a function.
   In any case, factory and data are in variables scope. So you could simplify the code logic by keeping their interaction out of the thread scope. Something like:
    

   public void function run() {
   		var threadName = createUUID();
   		var closure = variables.factory();
                   var threadResult = local.closure(variables.data);
   
   		thread name=local.threadName threadResult=local.threadResult { 
   			try {
   				thread.result = threadResult ;
   			}
   			catch (any ex) {
   				variables.error = ex;
   			}
   		}
   
   		variables.thread = cfthread[local.threadName];
   }​

2. The current line of code
   
   threadJoin();
   
   joins the main execution thread to the currently running thread, if there is one. This goes against the expectation in runAll(). A natural assumption is that all the threads coming in as the function's argument will be joined. 
   That is, something like:
   

   public struct function runAll(required array threads) {
   		var threadResults = {};
   		var runnableThreads = [];
   		var listOfThreadNames = "";
   
   		for (var threadDefinition in threads) {
   			arrayAppend(runnableThreads, variables.beanFactory.injectProperties("ThreadBean", {
   					data: threadDefinition.attributes,
   					factory: threadDefinition.closure,
   					name: threadDefinition.name
   				})
   			);
   			
   			listOfThreadNames = listAppend(listOfThreadNames, threadDefinition.name);
   		}
   		
   		for (var thread in runnableThreads) {
   			thread.run();
   		}
   		
   		threadJoin(listOfThreadNames);
   		
   		for (var thread in runnableThreads) {
   			structInsert(threadResults, thread.getName(), thread.getResult());
   		}
   		
   		return threadResults;
   }
   ​

   
    

I recommend you convert this from CFSCRIPT to regular CFML and see if you have the same problem. My personal experience has been that there isn't a one-to-one correlation between them when it comes to error handling. This kind of sucks as a recommendation, but maybe this will be addressed in future CF releases.

Dave Watts, Eidolon LLC