Let's clean up!

Hi @Patof, the main problem with your script was a couple of places where you were looping over an array or collection, eg. TextFrames, but then forgot to refer to the particular object by the loop's index, eg. myTextFrames.strokeWeight throws an error because a single `TextFrames` object does not have `strokeWeight` property. You meant to do myTextFrames[i].strokeWeight.

Aside from that mistake appearing a few times, there were just some little things. As a learning exercise, I've restructured your script a little (and got it to the point where it successfully runs using your test .indd). The big change I made was to create functions for a couple of things you do very often: check if something is empty, and remove it if it is empty. Functions a little sub-programs that perform the code inside them, ie. function (params) { code in here } whenever they are called. Calling a function is simply typing its name with parenthesis afterwards, and including any parameters inside the parenthesis. You can see this in action below.

I hope that helps a bit and you can move forward with your script.

- Mark

/**
 * Script by Patrick24627968ntbq
 * adjusted by m1b
 * @discussion https://community.adobe.com/t5/indesign-discussions/let-s-clean-up/m-p/14502663
 */
function main() {

    var myDocument = app.activeDocument;
    app.findTextPreferences = app.changeTextPreferences = null;
    // note that removing U+FEFF character from the document
    // may have unwanted consequences, such as removing index markers!
    app.findTextPreferences.findWhat = "<FEFF>";
    app.changeTextPreferences.changeTo = "";
    myDocument.changeText();

    // this returns an array of TextFrame objects for each story (array of arrays)
    var frames = app.activeDocument.stories.everyItem().textContainers;

    // loop over the array of arrays of textFrames
    storyLoop:
    for (var i = frames.length - 1; i >= 0; i--) {

        // loop over the array of textFrames
        textFrameLoop:
        for (var j = frames[i].length - 1; j >= 0; j--) {

            var frame = frames[i][j];

            // check that we have a valid textframe
            if (
                undefined == frame
                || !frame.isValid
            )
                continue textFrameLoop;

            var stroke = frame.strokeWeight;
            var color = frame.fillColor.name;
            var wrap = frame.textWrapPreferences.textWrapMode;
            //alert (color)
            if (
                frame.contents == ""
                && stroke == "0"
                && color == "None"
                && wrap === TextWrapModes.NONE
            ) {
                //alert ("yes")
                frame.remove();
                continue textFrameLoop;
            }

            if (frame.contents === "")
                try {
                    frame.contentType = ContentType.UNASSIGNED;
                } catch (e) { };

        }
    }

    // this function returns true if the item is empty
    function isEmpty(item) {
        var stroke = item.strokeWeight;
        var color = item.fillColor.name;
        var wrap = item.textWrapPreferences.textWrapMode;
        return (
            item.graphics.length < 1
            && stroke == "0"
            && color == "None"
            && wrap === TextWrapModes.NONE
        );
    };

    // this function checks if empty and removes empty items
    function removeItemsIfEmpty(items) {
        for (var i = items.length - 1; i >= 0; i--) {
            if (isEmpty(items[i]))
                items[i].remove();
        }
    };

    removeItemsIfEmpty(app.activeDocument.rectangles);
    removeItemsIfEmpty(app.activeDocument.polygons);
    removeItemsIfEmpty(app.activeDocument.rectangles);
    removeItemsIfEmpty(app.activeDocument.ovals);

};

app.doScript(main, ScriptLanguage.JAVASCRIPT, undefined, UndoModes.ENTIRE_SCRIPT, 'Clean Text');