My event handler is not removing guides as it should

Hi @dane13860245, you cannot make changes to the DOM while a modal dialog is active. The error is:

Here is one approach to get you moving forward. I'm pretty sure it isn't the best way, because it re-creates the dialog each time, rather than re-using the existing dialog. I would like to see a neater way, if you come up with it. The crux is that everytime you click the Apply button it closes, then *does stuff*, then re-creates the dialog with the new values (you must keep the settings object up-to-date).

Anyway, here it is:

function main() {

    var settings = {
        proportionA: '0.2',
    };

    var docWidth = Number(app.activeDocument.documentPreferences.pageWidth);
    var docHeight = Number(app.activeDocument.documentPreferences.pageHeight);

    for (var i = 1; i < 5; ++i) {
        app.activeWindow.activePage.guides.add({ name: "Blah" + i, location: docWidth * i * 0.1, orientation: HorizontalOrVertical.VERTICAL });
    }

    while (makeWindow(settings).show() === 1) {

        // anything here happens every time the apply button is clicked

        // you can access anything you store in settings object
        $.writeln(settings.proportionA);

        var myGuide = app.activeWindow.activePage.guides.itemByName("Blah2");        
        if (myGuide.isValid) {
            alert("guide blah2: " + myGuide);
            app.activeWindow.activePage.guides.itemByName("Blah2").remove();
        }

    }

};

app.doScript(main, ScriptLanguage.JAVASCRIPT, undefined, UndoModes.ENTIRE_SCRIPT, 'Add guides');


function makeWindow(settings) {

    var myWindow = new Window("dialog");

    var ProportionsGroup = myWindow.add("group");
    ProportionsGroup.orientation = "column";
    ProportionsGroup.alignment = "left";
    ProportionsGroup.add("statictext", undefined, "Proportions (enter values between 0 and 1)");

    var ProportionEntries = ProportionsGroup.add("group");
    ProportionEntries.alignment = "left";

    var ProportionA = ProportionEntries.add("edittext", undefined, "");
    ProportionA.characters = 6;
    ProportionA.active = true;
    ProportionA.text = settings.proportionA || '0.2';

    var buttons = myWindow.add('group');
    var cancelButton = buttons.add("Button { text:'Cancel', enabled: true, properties: { name:'cancel' } }");
    var applyButton = buttons.add("Button { text:'Apply', enabled: true, properties: { name:'ok' } }");
    applyButton.onClick = function () { myWindow.close(1) };

    ProportionA.addEventListener('change', function () { settings.proportionA = parseFloat(this.text) });

    return myWindow;

};

See what you think.

 - Mark