When selecting multiple objects to call a function, is an inner loop better or an outer loop better?

Hi ​@dublove , In the first example I don’t think you need a function or the item and sel variables—it could simply be:

var items = app.activeDocument.selection;
// 00001     outer loop
for (var i = 0; i < items.length; i++) {
    items[i].fit(FitOptions.FRAME_TO_CONTENT);
} 

A function makes more sense if you include the loop, maybe do some error checking, and want to call the function multiple times within a script.

Here I don’t need any variables, I just pass in app.activeDocument.selection, and check if there is a selection, and if there is, does it take the fit method—this would still break with a selection that has groups or nested text frames:

// 00002  internal circulation----
frameFitToContent(app.activeDocument.selection);
function frameFitToContent(sel) {
    if (sel.length > 0) {
        for (var i = 0; i < sel.length; i++) {
            try {
                sel[i].fit(FitOptions.FRAME_TO_CONTENT);
            }catch(e) {alert("No Fit Options")}   
        }
    }else {{alert("No Selection")}}  
}