• Global community
    • Language:
      • Deutsch
      • English
      • Español
      • Français
      • Português
  • 日本語コミュニティ
    Dedicated community for Japanese speakers
  • 한국 커뮤니티
    Dedicated community for Korean speakers
Exit
0

P: Applying preset in plug-in - all panels turned off

Participant ,
Oct 24, 2020 Oct 24, 2020

Copy link to clipboard

Copied

[Here's a test plugin to run in LR 9.4 and 10.0, showing the bug in 10.0. -JRE

https://feedback.photoshop.com/conversations/lightroom-classic/bug-lightroom-classic-10-applying-pre...]

 

When retrieving an existing preset with for example Exposure 0.5, along with this setting all the panels are turned off.

 

Example preset:

   xmlns:crs="http://ns.adobe.com/camera-raw-settings/1.0/"
   crs:PresetType="Normal"
   crs:Cluster=""
   crs:UUID="41AE3A89A1C9A8429C7CE3F3B1A21FCD"
   crs:SupportsAmount="False"
   crs:SupportsColor="True"
   crs:SupportsMonochrome="True"
   crs:SupportsHighDynamicRange="True"
   crs:SupportsNormalDynamicRange="True"
   crs:SupportsSceneReferred="True"
   crs:SupportsOutputReferred="True"
   crs:CameraModelRestriction=""
   crs:Copyright=""
   crs:ContactInfo=""
   crs:Version="13.0"
   crs:ProcessVersion="11.0"
   crs:Exposure2012="+0.50"
   crs:HasSettings="True">
   
Listing the preset with "preset:getSetting()" will result in:

 

{EnableCalibration = false,EnableCircularGradientBasedCorrections = false,EnableColorAdjustments = false,EnableDetail = false,EnableEffects = false,EnableGradientBasedCorrections = false,EnableGrayscaleMix = false,EnableLensCorrections = false,EnablePaintBasedCorrections = false,EnableRedEye = false,EnableRetouch = false,EnableSplitToning = false,EnableToneCurve = false,EnableTransform = false,Exposure2012 = 0.5,ProcessVersion = "11.0",Version = "13.0"}

 

When applying this preset with:

    local preset = LrApplication.addDevelopPresetForPlugin(_PLUGIN, "Apply preset " .. presetName, preset:getSetting())photo:applyDevelopPreset(preset, _PLUGIN)

The real problem is that when applying this preset the user sees in the Develop module all his develop adjustments having  disappeared. Actually the settings are there, but all the panels have been turned off.

I think many user will panic from this behavior!

 

To reproduce I've created a Lightroom sample plug-in here: Sample plug-in

 

Btw, I based the sample plug-in on that of  Chris James: Chris James

Bug Investigating
TOPICS
macOS , Windows

Views

331

Translate

Translate

Report

Report
Community guidelines
Be kind and respectful, give credit to the original source of content, and search for duplicates before posting. Learn more
community guidelines
5 Comments
LEGEND ,
Oct 25, 2020 Oct 25, 2020

Copy link to clipboard

Copied

Have you observed that this is a recent change in LR 10, or was it present in LR 9?

Since the introduction of the "new" .xmp preset format in LR 7.3, the SDK's handling of presets has been a mess.  Adobe changed LR and ACR to use the same presets, which was a good thing. But ACR didn't have a concept of "enable" and "disable" of groups of sliders in its UI, and whoever implemented the unification didn't carefully think through the implications. This resulted in a number of bugs, both in the UI and in the SDK.  This one is still outstanding and is related to the behavior you're observing here:

https://feedback.photoshop.com/conversations/lightroom-classic/lightroom-classic-presets-no-longer-r... 

Votes

Translate

Translate

Report

Report
Participant ,
Oct 25, 2020 Oct 25, 2020

Copy link to clipboard

Copied

I tested with version 9.4 and this version had not this issue.

An easy way to test the difference is using the Preset viewer plug-in.

In version 9.4 and before all the enablexxxx settings where not present when one had a preset with only exposure=0.5

There was a similar bug in version 7.3. At that time not only exposure=0.5 but all settings listed with their default settings, see Lightroom SDK: issue with preset:getSetting(). That one was fixed later.

One wonders if Adobe is applying unit testing on the SDK. This error would have come up immediately.

Votes

Translate

Translate

Report

Report
LEGEND ,
Oct 25, 2020 Oct 25, 2020

Copy link to clipboard

Copied

Here's a simple test plugin to be run in LR 9.4 and LR 10, showing the bug:

https://www.dropbox.com/s/3gy5pb3kpa591se/lr10presetbug.lrdevplugin.zip?dl=0   

After installing the plugin, do File > Plug-In Extras > Run Test. Here's the output on 9.4 and 10.0:

 

Untitled-337e7d75-a1a4-4a24-8620-a7e4d9cf1dbb-515118528.png

Votes

Translate

Translate

Report

Report
LEGEND ,
Oct 25, 2020 Oct 25, 2020

Copy link to clipboard

Copied

This bug also affects my most popular plugin, Export LUT, and it probably affects other popular plugins, like The Fader and MIDI2LR.

Votes

Translate

Translate

Report

Report
Adobe Employee ,
Oct 26, 2020 Oct 26, 2020

Copy link to clipboard

Copied

LATEST

I've logged a bug here, John. 

Rikk Flohr: Adobe Photography Org

Votes

Translate

Translate

Report

Report