Hello gang!
I just wanted to share with you my small utility tool for Photoshop called Clean SL that cleans ScriptingListenerJS.log file to make it more readable.
Recently watched Davide_Barranca's Adobe Photoshop HTML Panels Development course and realised how painful it is to work with Action Manager's code and how unreadable it is right off the box. I know there are quite a few other tools that cleans log file, however it doesn't hurt to have an option to choose.
Interested? Grab it here: rendertom / Clean SL / source / — Bitbucket
Script performs multiple actions such as cleaning-up variable names and hoisting them to the top, wraps code block into function, converts charID to string ID for better readability and such. Resulting code is clean and maintains better readability.
Features:
- Load entire ScriptingListenerJS.log content
- Load only last entry in ScriptingListenerJS.log
- Enter ScriptingListenerJS code manually
Options:
- Hoist variable declaration to the top
- Consolidate variables
- Give descriptive variable names
- Convert charID to stringID for better readability
- Replace stringIDToTypeID() to s2t() function
- Wrap to function block.
Example:
From this:
var idHStr = charIDToTypeID( "HStr" );
var desc21 = new ActionDescriptor();
var idpresetKind = stringIDToTypeID( "presetKind" );
var idpresetKindType = stringIDToTypeID( "presetKindType" );
var idpresetKindCustom = stringIDToTypeID( "presetKindCustom" );
desc21.putEnumerated( idpresetKind, idpresetKindType, idpresetKindCustom );
var idClrz = charIDToTypeID( "Clrz" );
desc21.putBoolean( idClrz, false );
var idAdjs = charIDToTypeID( "Adjs" );
var list1 = new ActionList();
var desc22 = new ActionDescriptor();
var idH = charIDToTypeID( "H " );
desc22.putInteger( idH, 39 );
var idStrt = charIDToTypeID( "Strt" );
desc22.putInteger( idStrt, 23 );
var idLght = charIDToTypeID( "Lght" );
desc22.putInteger( idLght, -27 );
var idHsttwo = charIDToTypeID( "Hst2" );
list1.putObject( idHsttwo, desc22 );
desc21.putList( idAdjs, list1 );
executeAction( idHStr, desc21, DialogModes.NO );
to this:
hueSaturation();
function hueSaturation() {
var s2t = function (s) {
return app.stringIDToTypeID(s);
};
var descriptor = new ActionDescriptor();
var list = new ActionList();
var descriptor2 = new ActionDescriptor();
descriptor.putEnumerated( s2t( "presetKind" ), s2t( "presetKindType" ), s2t( "presetKindCustom" ));
descriptor.putBoolean( s2t( "colorize" ), false );
descriptor2.putInteger( s2t( "hue" ), 39 );
descriptor2.putInteger( s2t( "saturation" ), 23 );
descriptor2.putInteger( s2t( "lightness" ), -27 );
list.putObject( s2t( "hueSatAdjustmentV2" ), descriptor2 );
descriptor.putList( s2t( "adjustment" ), list );
executeAction( s2t( "hueSaturation" ), descriptor, DialogModes.NO );
}
Installation
Clone or download repository and place Clean SJ.jsx script to Photoshop’s Scripts folder:
Adobe Photoshop CC 20XX -> Presets -> Scripts -> Clean JS.jsx
Restart Photoshop to access Clean JS script from File -> Scripts
------------------------------------------------
Since I am rather new to Photoshop Scripting, I might have missed something of my code brakes. So if you find any bugs or issues, please do not hesitate to let me know so I could fix it.
So, happy cleaning everybody!
Explore related tutorials & articles
131
Replies
I was about to report that. I have problems where the source will evaluate but the cleaned code does not. I think this it has to do with the Convert charID to stringID return in make function were failing. When I un checked the option the function names with sequence numbers may have spaces.
]
Some weird stuff is happening there. Can you see some weird variable name on right side var idPnt4039383736..<more digits> ...?
This shouldn't happen. Can you send me Action Manager code the one you have on the left side?
Are you sure you didn't alter Action Manager code before clicking on "Clean Code"? Maybe something broke in your source code?
This code works for me with no problem:
Action Manager:
var idMk = charIDToTypeID( "Mk " );
var desc4 = new ActionDescriptor();
var idNw = charIDToTypeID( "Nw " );
var desc5 = new ActionDescriptor();
var idartboard = stringIDToTypeID( "artboard" );
desc5.putBoolean( idartboard, false );
var idMd = charIDToTypeID( "Md " );
var idRGBM = charIDToTypeID( "RGBM" );
desc5.putClass( idMd, idRGBM );
var idWdth = charIDToTypeID( "Wdth" );
var idRlt = charIDToTypeID( "#Rlt" );
desc5.putUnitDouble( idWdth, idRlt, 700.000000 );
var idHght = charIDToTypeID( "Hght" );
var idRlt = charIDToTypeID( "#Rlt" );
desc5.putUnitDouble( idHght, idRlt, 500.000000 );
var idRslt = charIDToTypeID( "Rslt" );
var idRsl = charIDToTypeID( "#Rsl" );
desc5.putUnitDouble( idRslt, idRsl, 72.000000 );
var idpixelScaleFactor = stringIDToTypeID( "pixelScaleFactor" );
desc5.putDouble( idpixelScaleFactor, 1.000000 );
var idFl = charIDToTypeID( "Fl " );
var idFl = charIDToTypeID( "Fl " );
var idWht = charIDToTypeID( "Wht " );
desc5.putEnumerated( idFl, idFl, idWht );
var idDpth = charIDToTypeID( "Dpth" );
desc5.putInteger( idDpth, 8 );
var idprofile = stringIDToTypeID( "profile" );
desc5.putString( idprofile, """none""" );
var idGdes = charIDToTypeID( "Gdes" );
var list1 = new ActionList();
desc5.putList( idGdes, list1 );
var idDcmn = charIDToTypeID( "Dcmn" );
desc4.putObject( idNw, idDcmn, desc5 );
var idDocI = charIDToTypeID( "DocI" );
desc4.putInteger( idDocI, 195 );
executeAction( idMk, desc4, DialogModes.NO );
Clean Code:
Mk();
function Mk() {
var s2t = function (s) {
return app.stringIDToTypeID(s);
};
var descriptor = new ActionDescriptor();
var descriptor2 = new ActionDescriptor();
var list = new ActionList();
descriptor2.putBoolean( s2t( "artboard" ), false );
descriptor2.putClass( charIDToTypeID( "Md " ), charIDToTypeID( "RGBM" ));
descriptor2.putUnitDouble( charIDToTypeID( "Wdth" ), charIDToTypeID( "#Rlt" ), 700.000000 );
descriptor2.putUnitDouble( charIDToTypeID( "Hght" ), charIDToTypeID( "#Rlt" ), 500.000000 );
descriptor2.putUnitDouble( charIDToTypeID( "Rslt" ), charIDToTypeID( "#Rsl" ), 72.000000 );
descriptor2.putDouble( s2t( "pixelScaleFactor" ), 1.000000 );
descriptor2.putEnumerated( charIDToTypeID( "Fl " ), charIDToTypeID( "Fl " ), charIDToTypeID( "Wht " ));
descriptor2.putInteger( charIDToTypeID( "Dpth" ), 8 );
descriptor2.putString( s2t( "profile" ), "none" );
descriptor2.putList( charIDToTypeID( "Gdes" ), list );
descriptor.putObject( charIDToTypeID( "Nw " ), charIDToTypeID( "Dcmn" ), descriptor2 );
descriptor.putInteger( charIDToTypeID( "DocI" ), 195 );
executeAction( charIDToTypeID( "Mk " ), descriptor, DialogModes.NO );
}
And here's the screenshot of settings:
JJMack apparently you found the limitation of Clean SL. Let he explain what's happening.
I opened your ScriptingListenerJS.log file you provided in the link and found one code block (starts at line 621) with an issue. Apparently there are two variable declarations that are braking my script.
var idPnt = charIDToTypeID( "Pnt " ); on line 659 and
var idPnt = charIDToTypeID( "#Pnt" ); on line 676.
From these two line you can see that same variable has 2 different values. This is where Clean SL brakes. My script reads code from top to bottom and it finds var idPnt = charIDToTypeID( "Pnt " ); and does some magic with it:
- removes this code line from it's original position in the code and pushes it to the top, (hoisting)
- replaces each instance of idPnt in the code with charIDToTypeID( "Pnt " ); (concatenation)
- and removes variable declaration
- boom, this is where we get issues, because var idPnt = charIDToTypeID( "#Pnt" ); never get's "fixed".
This is the limitation of my build, apparently. I didn't realise that same variable can have different values. And I assumed wrong. In order to fix this, I would need to rebuild entire logic of the code, witch I don't really want to do right now
So, to sum it up - if there are save variable declarations with different values - Clean SL will brake. Sorry.
-----------------------------
I was able to evaluate that code block by fixing it manually: renaming var idPnt = charIDToTypeID( "Pnt " ) to var idPntUniq = charIDToTypeID( "Pnt " ) and replacing idPnt to idPntUniq on the next line, where that variable was used. Had to do this 3 times, since same variable was declared 3 times in that block. Then tried Cleaning up the code (had all checkboxes enabled in the UI) and got error - aparentry there was a case xbytor2 and Davide_Barranca mentioned about charID string can have different values: " ... two different stringIDs map to the same charID". So went and disabled Convert charID to stringID in the UI and code evaluated with no problem.
Again, not a perfect solution, but still, it's possible to make it work.
Nice I like!!! Added to todo list 
I think it's a great idea. I wont be able to test it though, as I only love JavaScript:)
I noticed you are looping the array with for (var o in sData) - why? You know it's a bad practise, right? javascript - Why is using "for...in" with array iteration a bad idea? - Stack Overflow
Don't mean to step on your toes or anything, but it's better to say it now rather hold my peace forever 
I don't know what ScriptingSupport.8li is (I'm on Mac), but I do know that Adobe uses extended version of old ECMA3 Javascript. That's why it's called ExtendScript
Why do you ask?
AdChoices