1 Correct answer
Okay guys, was able to play around a bit with what I learned between the two of you and others and came up with this:
1) function main() {
2)
3) var __indexOf = [].indexOf || function(item) { for (var i = 0, l = this.length; i < l; i++) { if (i in this && this === item) return i; } return -1; };
4)
5) var makeNewLayer = function() {
6) var newLayer = doc.artLayers.add();
7) newLayer.name = 'magic layer1'
...
Explore related tutorials & articles
12
Replies
Hi DBarranca,
yes, the logic written by the TO darkie1973 is a little bit confusing.
I did not tested your code.
But are you really sure, that your code a correct PS-scripting syntax is? (because in Illu layers.add() works – but in PS IMHO should be artLayers.add() )
And why to loop through all the names of layers ( with indexOf … magic … ) ? IMHO to complicated.
Please try this part instead:
var aDoc = app.activeDocument;
var checkName = /magic\slayer\s[1-4]/;
var pass = aDoc.activeLayer.name.match (checkName);
if ( pass == null ) {
newLayer = aDoc.artLayers.add(); // or your own function in the next line
//makeNewLayer();
} else {
alert ("vorhanden und aktiv: " + pass);
}
Furthermore it's never a good idea to use a style without previous check if this style already exists. (e.g. with a try catch clause)
Greetings (and sorry or my bad english)
Hi pixxxel schubser,
you're right, I wrote the code as it came to my mind without any further testing, so it's very possible that I run into layers/artLayers mistakes 
As for the RegExp I thought that providing an array of names is preferable since darkie1973 is not bound to the "magic layer #" pattern and he can easily add other ones without messing with RegExp (ok, this is the official reply - the true one is that I use RegExp very often but I've never been able to like them so when possible I use different code).
Little magic in the __indexOf(), it's just a polyfill because ExtendScript doesn't know Array.prototype.indexOf() (see http://feedback.photoshop.com/photoshop_family/topics/-ps-scripting-extendscript-support-for-ecmascr...) - mostly, I write in Coffeescript then compile to JS, and __indexOf is a nice addition that I get for free in the compiled code.
Cheers,
Davide
Hi Davide or DBarranca,
don't worry. I like your code. And I see the same problems when using Regex. But I like Regex (and/or Grep in ID). It is an extremely efficient and a very quickly way – if you use the correct Regex (no problem for me, but mostly for the others).
Here in this thread my greatest problem is to understand, what the TO darkie1973 really want to do. Perhaps the barricade between our languages is to high for me, perhaps the explanation is not exactly enough for me. There are to much possibilities remain to find the right code for the TO.
And I go in the next days in holidays.
Edit:
I wrote this at the same time as your post #7
And I also like your new code.
Hi pixxxel schubser,
in fact it's not that I don't like RegExp! I admit they are incredibly powerful: but nothing of their rules sticks in my brain after I've used them - each time I need to seek through documentation like the first time. It reminds me when I teach my mother how to use her computer 
Have some nice holidays! I'll wait just a couple of weeks and then it'll be my turn.
Best,
-Davide
If you need one day a special Regex, than ask.
And thx for the wishes.
AdChoices