Dear All,
I've been looking for a Photoshop script for a long time, that could help me batch replace images in a smart object (essentially just trying to batch convert flat 1125x750px images to 3D images).
As I'm quite the Photoshop beginner, I had someone create a mockup file and he found an existing script to work with on these forums.
So here's what I have:
- a mockup file of an image set as a transformed smart object
- a folder of images resized to fit said smart object
This is what I would like the script to do:
- for every image in said folder
- replace smart object with images
Your man sent me a video how to execute the script and it worked just fine on his computer (Windows 7). Problem is that it doesn't work on mine (Windows 7 and Windows 10). I've tried on several computers (some had better specs than his), but unfortunately to no avail. He used a legal version of Photoshop CC 2018 and so did I, so it wouldn't have to do with that. We both can't find the issue.
The error message that I get: ''executeAction(idplacedLayerReplaceContents, desc3, DialogModes.NO''. I use the following script:
// Replace SmartObject’s Content and Save as JPG
// 2017, use it at your own risk
// Via @circle B: https://graphicdesign.stackexchange.com/questions/92796/replacing-a-smart-object-in-bulk-with-photos...
// JPG code from here: https://forums.adobe.com/thread/737789
#target photoshop
if (app.documents.length > 0) {
var myDocument = app.activeDocument;
var theName = myDocument.name.match(/(.*)\.[^\.]+$/)[1];
var thePath = myDocument.path;
var theLayer = myDocument.activeLayer;
// JPG Options;
jpgSaveOptions = new JPEGSaveOptions();
jpgSaveOptions.embedColorProfile = true;
jpgSaveOptions.formatOptions = FormatOptions.STANDARDBASELINE;
jpgSaveOptions.matte = MatteType.NONE;
jpgSaveOptions.quality = 8;
// Check if layer is SmartObject;
if (theLayer.kind != "LayerKind.SMARTOBJECT") {
alert("selected layer is not a smart object")
} else {
// Select Files;
if ($.os.search(/windows/i) != -1) {
var theFiles = File.openDialog("please select files", "*.psd;*.tif;*.jpg", true)
} else {
var theFiles = File.openDialog("please select files", getFiles, true)
};
if (theFiles) {
for (var m = 0; m < theFiles.length; m++) {
// Replace SmartObject
theLayer = replaceContents(theFiles
var theNewName = theFiles
// Save JPG
myDocument.saveAs((new File(thePath + "/" + theName + "_" + theNewName + ".jpg")), jpgSaveOptions, true,Extension.LOWERCASE);
}
}
}
};
// Get PSDs, TIFs and JPGs from files
function getFiles(theFile) {
if (theFile.name.match(/\.(psd|tif|jpg)$/i) != null || theFile.constructor.name == "Folder") {
return true
};
};
// Replace SmartObject Contents
function replaceContents(newFile, theSO) {
app.activeDocument.activeLayer = theSO;
// =======================================================
var idplacedLayerReplaceContents = stringIDToTypeID("placedLayerReplaceContents");
var desc3 = new ActionDescriptor();
var idnull = charIDToTypeID("null");
desc3.putPath(idnull, new File(newFile));
var idPgNm = charIDToTypeID("PgNm");
desc3.putInteger(idPgNm, 1);
executeAction(idplacedLayerReplaceContents, desc3, DialogModes.NO);
return app.activeDocument.activeLayer
};
Please find screenshots attached of the error message that I get + layers and channels at the moment the script fails. Please note that I've blurred out the smart object design as I paid for it - would like to keep it private and not for all to view.
If someone could help me out I'd really REALLY appreciate it. I've literally been caving myself into my apartment for the past 4 days trying to resolve this.
1 Correct answer
Your problem is replacement object files need to be exactly the same size as the object in the mockup template. Same Aspect Ratio, Same number Of pixels and the same Print Resolution like I wrote. All I needed to do was to change your two images that had a print resolution of 72DPI to have a 300DPI pint resolution setting then your script worked fine. What was happening was Photoshop Place was resizing one of your images and in the process used all you machine resources. My script had the
...
Explore related tutorials & articles
14
Replies
JJMack - thank you for your detailed response. Your man who provided me with the mockup template, said that if I'd use all 1250x750px images with the script, it should work just fine. He actually demonstrated it step by step in a video. I followed his every step and still get the errors so we can't comprehend. If the image files are all in the same image format, the aspect ratios and print resolutions would be too, right? I checked the smart object pixels and it matches 1250x750 pixels exactly.
I got the advice from another forum member today to use the script with a different mockup, so I downloaded one and to my surprise it worked flawlessly. It's just not the one I outsourced and desperately would like to use. I tried using your script ''BatchMockupTemplates.jsx'' script with it, but am getting an I/O error after about 10 mins of processing (for one image). Sometimes no image comes out, sometimes the attached comes out (while it obviously should have come out in 3D).
Upload your mockup so I can download and try populating it. I used that script to process 41 images into 84 Templates producing 3,444 jped files. Three times I ran the Test Photoshop messes up one of the 84 templates and it failed. The test takes about 1.5 hours and Does not always fails and when it does fail it fails on the same template but not with the same image. If fails in the Replace Content Path. I have never has a failure when I used the Edit option where the Smart object is opened an replaced by editing the image. You could try checking the edit option see if it runs when replace content is not used.
Please upload your Mockup Template I would like to see if its a solid failure with that template.
Also give me some idea as to your Machine specs. Photoshop is a resource hungry application and users report when processing thousands of images files Photoshop stops working for it wants more and it use all available resources.
That script can run a long time before I add suspend history it ran very slow and consumed all my machines resources.
AdChoices