1 Correct answer
Then try to replace this line:
var str = '<meta name="SN Effectivity 1" content="' + dashFrames.join (", ") + '">\r';
With this:
var str = '<meta name="SN Effectivity 1" content="' + dashFrames.join (",").replace(/,/g, ", ") + '">\r';
Explore related tutorials & articles
16
Replies
NAILED IT! Silly-V THANK YOU SO MUCH!!!
Here is the output....
<meta name="SN Effectivity 1" content="LNB1-UP, LZB1-UP, L8D1-UP, LXK1-UP, CE51-UP, LNA1-UP, LZA1-UP, L8B1-UP, LXJ1-UP, CE31-UP, NH31-UP, DH41-UP, NH41-UP">
Here is the final code:
#target illustrator
var doc = app.activeDocument;
var allText = doc.textFrames;
var allLayers = doc.layers;
var count = 0;
var dashFrames = new Array();
for (z = 0; z < allLayers.length; z++) {
if (allLayers
.name == "Single Line" || allLayers .name == "Two Line" || allLayers .name == "Three Line" || allLayers .name == "Four Line") { //alert("Found single two three four layer");
for (i = 0; i < allText.length; i++) {
if (allText.typename == "TextFrame") {
//alert(allText.layer);
if (allText.layer != "[Layer Single Line]") {
//skip it
} else {
if (allText.contents.match("-")) {
if (allText.contents.substr(0, 4) == "UENR" || allText.contents.substr(0, 4) == "RENR" || allText.contents.substr(0, 4) == "SENR" || allText.contents.substr(0, 4) == "KENR") {
//skip it
} else {
dashFrames[count] = allText.contents.replace(/^.[^\n\r]+/, "").replace(/^[\r\n]/,"").split(/[\n\r]/);
count++;
}
}
}
}
}
}
}
var str = '<meta name="SN Effectivity 1" content="' + dashFrames.join (",").replace(/,/g, ", ") + '">\r';
var f = File("~/Desktop/" + "SN Info.txt");
f.open('w');
f.write(str);
f.close();
So could you maybe explain this part of line 18 to me? I am not a programmer....I get by (with some help) 
replace(/^.[^\n\r]+/, "").replace(/^[\r\n]/,"").split(/[\n\r]/);
I understand the replace function and \n = new line? \r = carriage return? But what about the /^. and +/
Thank you again for your help and time!
Hey, I'm not too fancy with the regexps myself, as you can tell from my 1st attempt for removing the 1st line.
You can use this awesome site to test your regexps: Regex Tester - Javascript, PCRE, PHP
Here is my explanation:
/
^When a ^ caret is used in regexp, it tells to match the beginning of the subject string
.the dot is supposed to match 'all characters, expect for newline
[the stuff inside the parentheses are a 'character set' - match any character in the set.
^If the caret symbol (^) is inside the [] character set 1st, it says to match characters except what's in this set.
\nThe next-line character
\rThe return character
]Closing of the character set
+Match one or more of the character preceding this + symbol
/
I mostly just go to that site and test the matchings and then make a quick test inside the ESTK to make sure they work, which I didn't do until you said my 1st answer was not working
??? Hmmh?
Be very very carefully! The following part: allText.contents.replace(/^.[^\n\r]+/, "").replace(/^[\r\n]/,"") … in line#21 could be a very dangerous part!
And is cumbersome!
This code will always remove the first line of your text frame. If the contents of this first line is a „dash line“ and not „LetterDigitDigit:\r“ (e.g. A15:) this line get lost in every case!
Also I have a question too:
Why do you re-replace this line (of my own code):
if (!allText.contents.match (/^[URSK]ENR/) && allText.contents.match ("-")) {
with this cumbersome lines:
if (allText.contents.match("-")) {
if (allText.contents.substr(0, 4) == "UENR" || allText.contents.substr(0, 4) == "RENR" || allText.contents.substr(0, 4) == "SENR" || allText.contents.substr(0, 4) == "KENR") {
I wonder.
Silly-V schrieb:
… then you have to follow the advice of the mighty pixxxel !
And now …
silence …
the mighty 
pixxxel speaks:
#target illustrator
var doc = app.activeDocument;
var allText = doc.textFrames;
var allLayers = doc.layers;
var count = 0;
var dashFrames = new Array();
for (z = 0; z < allLayers.length; z++) {
// This line#10 makes in combination with line#12 no sense for me - but I don't know the real document
if (allLayers
.name == "Single Line" || allLayers .name == "Two Line" || allLayers .name == "Three Line" || allLayers .name == "Four Line") { for (i = 0; i < allText.length; i++) {
if (allText.layer == "[Layer Single Line]" && allText.typename == "TextFrame") {
if (!allText.contents.match (/^[URSK]ENR/) && allText.contents.match ("-")) {
dashFrames[count] = allText.contents.replace(/^[A-Z\d]+:[\n\r]/,"").split (/[\n\r]/).join(", ");
count++;
}
}
}
}
}
var str = '<meta name="SN Effectivity 1" content="' + dashFrames.join (", ") + '">\r';
var f = File("~/Desktop/" + "SN Info.txt");
f.open('w');
f.write(str);
f.close();
Sorry, if I misunderstood, but IHMO too much loops and wrong (or better: ) to complicated way.
Perhaps this is a little bit easier for you:
#target illustrator
var doc = app.activeDocument;
var allText = doc.textFrames;
var allLayers = doc.layers;
var count = 0;
var dashFrames = new Array();
for (z = 0; z < allLayers.length; z++) {
if (allLayers
.name == "Single Line" || allLayers .name == "Two Line" || allLayers .name == "Three Line" || allLayers .name == "Four Line") { //alert("Found single two three four layer");
for (i = 0; i < allText.length; i++) {
if (allText.typename == "TextFrame") {
//alert(allText.layer);
if (allText.layer != "[Layer Single Line]") {
//skip it
} else {
if (!tF.contents.match (/^[URSK]ENR/) && tF.contents.match ("-")) {
/* ---------------------------------> THIS is not needed
if (allText.contents.match("-")) {
if (allText.contents.substr(0, 4) == "UENR" || allText.contents.substr(0, 4) == "RENR" || allText.contents.substr(0, 4) == "SENR" || allText.contents.substr(0, 4) == "KENR") {
//skip it
} else {*/
dashFrames[count] = allText.contents;
count++;
//}
}
}
}
}
}
}
/* ---------------------------------> THIS is not needed
var formatSerials = "";
var advanceNum = 1;
for (var i = 0; i < dashFrames.length; i++) {
if (advanceNum < dashFrames.length) {
formatSerials += dashFrames + ", ";
advanceNum++;
} else {
formatSerials += dashFrames;
}
}
*/
//var str = '<meta name="SN Effectivity 1" content="' + formatSerials + '">\r'
var str = '<meta name="SN Effectivity 1" content="' + dashFrames.join (", ") + '">\r';
var f = File("~/Desktop/" + "SN Info.txt");
f.open('w');
f.write(str);
f.close();
alert ("final:\r"+dashFrames.join ("\r"));
Have fun
AdChoices