1 Correct answer
Hi @Red-Temujin , just to follow up on the Photoshop trim command, not sure if this works for you, but the script below will open the document links in Photoshop, and trim away the white pixels. My example opens all of the links, which you might not want, but it could also specify the links on a targeted layer, or the single link as you place:
Edited Code:
//#targetengine "session";
//opens document links in Photoshop and trims
app.scriptPreferences.measurementUnit = MeasurementUnits.P
34
Replies
Hi Rob,
did some tests with your TrimLink.jsx script.
I see three things that could be or actually are an issue:
[ 1 ] The frame fitting options should be reset before the image is trimmed and the link is updated.
Had some tests without resetting the frame fitting options.
Before the script run where I selected the image at the top:
The result:
After adding some code that also addresses two other issues I had this correct result:
[ 2 ] textWrapOffset does NOT WORK when defined inside properties object.
At least with InDesign 16.4 on my Windows machine. So I added the code for textWrapOffset outside of the property properties.
[ 3 ] app.displayDialogs = DialogModes.NO ; added to PhotoShop script code.
My color management settings in PhotoShop would detect a missing or not matching color profile and will ask what to do if the image is opened in PhotoShop. So I reset the app.displayDialogs to show no dialogs.
Changed code for TrimLink.jsx script below where I added a global undo ( not for the trimming of the image in PhotoShop! ) and did a bit restructuring. And I added your pad for the text wrap only on the left of the frame:
/**
* @@@BUILDINFO@@@ TrimLink-EDITED-BY-UL.jsx !Version! Sun Apr 24 2022 17:48:15 GMT+0200
*/
/*
Script by Rob Day.
EDITED BY UWE LAUBENDER
ISSUES RESOLVED:
[ 1 ] The frame fitting options should be reset before the image is trimmed and the link is updated.
[ 2 ] textWrapOffset does NOT WORK when defined inside properties object.
[ 3 ] app.displayDialogs = DialogModes.NO ; added to PhotoShop script.
*/
( function()
{
app.scriptPreferences.userInteractionLevel = UserInteractionLevels.INTERACT_WITH_ALL;
app.doScript
(
trimImageOfSelectedImage,
ScriptLanguage.JAVASCRIPT,
[],
UndoModes.ENTIRE_SCRIPT,
"Trim Image of Selected Image | SCRIPT"
);
function trimImageOfSelectedImage()
{
if( app.selection.length != 1 ){ return };
if( app.selection[0].constructor.name != "Image" )
{
alert("Please Direct Select an Image and Try Again.") ;
return;
};
var doc = app.activeDocument ;
var prefs = doc.viewPreferences.properties;
var imagePrefs = app.imagePreferences.properties;
app.imagePreferences.preserveBounds = false
doc.viewPreferences.horizontalMeasurementUnits = MeasurementUnits.POINTS ;
doc.viewPreferences.verticalMeasurementUnits = MeasurementUnits.POINTS ;
var s=app.activeDocument.selection[0];
var leftPad = 4;
var lnk, img, fr, x;
// [ 220424-1 ] EDIT UWE LAUBENDER
//RESET FRAME FITTING OPTIONS
s.parent.frameFittingOptions.properties =
{
autoFit : false ,
fittingOnEmptyFrame : EmptyFrameFittingOptions.NONE ,
leftCrop : 0 ,
rightCrop : 0 ,
topCrop : 0 ,
bottomCrop : 0
};
lnk = s.itemLink;
trimLink(lnk.filePath);
while (lnk.status != LinkStatus.NORMAL) { lnk.update() };
img = lnk.parent ;
fr = img.parent ;
x = fr.geometricBounds[3]-img.geometricBounds[3] ;
img.move([0,0], [x,0]);
img.fit(FitOptions.FRAME_TO_CONTENT);
// [ 220424-1 ] ANNOTION UWE LAUBENDER
// textWrapOffset DOES NOT WORK:
// fr.textWrapPreferences.properties = {textWrapMode:TextWrapModes.BOUNDING_BOX_TEXT_WRAP, textWrapOffset:[0,pad,0,pad] };
fr.textWrapPreferences.properties =
{
applyToMasterPageOnly : false ,
inverse : false ,
textWrapMode : TextWrapModes.BOUNDING_BOX_TEXT_WRAP ,
};
fr.textWrapPreferences.textWrapOffset =
[
0,
leftPad,
0,
0
];
doc.viewPreferences.properties = prefs ;
/**
* A function to run in Photoshop
* @ param file path
* return file path
*/
function trimLink(pa)
{
var bt = new BridgeTalk();
bt.target = "photoshop";
bt.body = psScript.toString() + "\rpsScript('"+pa+"');";
bt.onResult = function(resObj) {} ;
bt.onError = function( inBT ) { alert(inBT.body); };
bt.send(8);
//opens the link, trims white pixels and saves
function psScript(pa)
{
// [ 220424-1 ] EDIT UWE LAUBENDER
var startWithDialogs = app.displayDialogs ;
app.displayDialogs = DialogModes.NO ;
app.bringToFront();
open(File(pa));
var d = app.activeDocument;
d.trim(TrimType.TOPLEFT);
d.save();
d.close();
// [ 220424-1 ] EDIT UWE LAUBENDER
app.displayDialogs = startWithDialogs;
};
};
};
}() )
Regards,
Uwe Laubender
( ACP )
textWrapOffset does NOT WORK when defined inside properties object.
At least with InDesign 16.4 on my Windows machine. So I added the code for textWrapOffset outside of the property properties.
Thanks Uwe, I wonder if the textWrapOffset problem is a scripting bug or something specific to the document we are testing. In general it seems to be working for me with 16.4 on Mojave:
app.scriptPreferences.measurementUnit = MeasurementUnits.POINTS;
var s=app.activeDocument.selection[0];
s.textWrapPreferences.properties = {textWrapMode:TextWrapModes.BOUNDING_BOX_TEXT_WRAP, textWrapOffset:[0,50,0,50] };
Also I wonder if a BridgeTalk script that adjusts an existing layout is over complicating things for @Red-Temujin , maybe all that’s needed is a Photoshop action or script to batch the Trim before the layout is constructed:
//Photoshop script to batch trimming
var startWithDialogs = app.displayDialogs ;
var f = Folder.selectDialog("Select the folder containing the images");
if(f != null){
fa = f.getFiles(/\.(jpg|jpeg|png|tif|psd)$/i);
}
for (var i = 0; i < fa.length; i++){
open(File(fa[i]));
var d = app.activeDocument;
d.trim(TrimType.TOPLEFT);
d.save();
d.close();
};
app.displayDialogs = startWithDialogs;
AdChoices
