P: Point Color doesn't clear when syncing

I tested both recipes above, syncing and creating a preset, and they now work correctly.

I have an issue with syncing the Point Color tool. I applied one shift in color toa single image then synced that change across all my images in the catolgue. But then I had a change of heart and wanted to remove the color shift. Even with Auto Sync engaged, deleteing the swatch would not work across all selected images so what I did was double click each slider to reset it back to 0. That change would take affect across all selected photos. So it's a workable compromise for the time being.

@johnrellis preset creation is vastly lacklustre and there are some "forbidden presets".

For instance Color Grading we can't preset only the Luminances without the other settings...why is that only god knows.

For Color Grading I wish we could we could copy/sync or Preset

[ ] Color Grading - 3 Ways

[ ] Global

[ ] Balance & Blending (these can be preset individually manually, I already have done it)

[ ]  Luminances.

But I digress.

.

"Yes but that preset when applied will change the settings of any existing Category that was also checked alongside Point Color so is simpler to check Process Version that will not likely mess with any other existing setting."

Agreed. I was just calling out that the bug isn't particular to Process Version needing to be checked, and thus more likely a bug in the preset-creation logic.

@johnrellis we must also remember that in LrC we can still "Check none" and yet create a "settings-less" Preset that though will appear in the Settings folder but not appear in LrC, in our Preset list.

Yet another bug I filed internally years ago that was never fixed.

"It's sufficient to check any other additional setting, e.g. Exposure or Manual Vignetting"

Yes but that preset when applied will change the settings of any existing Category that was also checked alongside Point Color so is simpler to check Process Version that will not likely mess with any other existing setting.

"You must also check Process Version and the Preset will be created"

It's sufficient to check any other additional setting, e.g. Exposure or Manual Vignetting.

"I reported this bug already internally: RD-4213967"

That's very good, because there's a good chance that the two symptoms, failing to sync no point color settings and failing to create a preset, in fact have different underlying causes with different lines of code needing correcting.  In the past, developers often miss additional symptoms merged into long bug threads here.

When no point colors have been selected, the internal representation is:

    PointColors = nil

It's a common programming mistake (which I've made many times) to forget that in some contexts "nil" should be treated the same as the empty array "{}".  The Sync/Copy-Paste code is clearly making that mistake, as did my Copy Settings plugin until I fixed it.

But when a point color has been selected but no sliders changed, the internal representation is much different:

    PointColors = {--table: 6
        [1] = {--table: 7
            HueRange = {--table: 8
                LowerFull = 0.333333, 
                LowerNone = 0, 
                UpperFull = 0.666667, 
                UpperNone = 1}, 
            HueShift = 0, 
            LumRange = {--table: 9
                LowerFull = 0.745889, 
                LowerNone = 0.195889, 
                UpperFull = 1, 
                UpperNone = 1}, 
            LumScale = 0, 
            RangeAmount = 0.5, 
            SatRange = {--table: 10
                LowerFull = 0.740754, 
                LowerNone = 0.190754, 
                UpperFull = 1, 
                UpperNone = 1}, 
            SatScale = 0, 
            SrcHue = 4.12705, 
            SrcLum = 0.839618, 
            SrcSat = 0.920754}}, 

 So it's very likely that fixing Sync to recognize PointColors = nil won't fix the preset code that gets confused by a valid non-empty representation of Point Color settings.

@johnrellis 

You must also check Process Version and the Preset will be created even if the HSL shifts or HSL Ranges are at the default.

@Rikk Flohr: Photography I reported this bug already internally: RD-4213967

.

LR chokes trying to create a preset with just Point Color checked, with a color selected in the Point Color panel, but no Point Color sliders changed.

To reproduce on LR 13.0.1 / Mac OS:

1. In the Point Color tab of the Color Mixer panel, use the dropper to select a color.

2. Create a preset named Test with just Point Color checked.

3. Observe that Test doesn't appear under User Presets in the Presets panel.

4. Do Preferences > Presets > Show Lightroom Develop Presets, and observe that Test.xmp is in the folder.

5. Restart LR and observe that Test still doesn't appear in the Presets panel.

6. In the Point Color panel, change Hue Shift to 1.

7. Create a preset named Test2, and observe that Test2 appears in the Presets panel.