New Participant

Answered

ExtendScript Photoshop Edit Contents Smart Layer

Forum|Forum|6 years ago
October 31, 2019
6 replies
17589 views

I have a psd file with an embedded psd file. Using photoshop normally, I double on the layer icon to edit the contents (or choose "edit contents" from the dropdown). I can not seem to find out how to open/edit it with extendscript/javascript. It is a legend that we use on our plans and would like to add content via scripting but need to find out how to edit the contents first. Note: this is not a linked file externally, it is embedded.

Thanks in advance.

This topic has been closed for replies.

Correct answer Stephen Marsh

One way:

app.runMenuItem(stringIDToTypeID('placedLayerEditContents'));

https://community.adobe.com/t5/Photoshop/Script-to-Export-Contents-of-all-Smart-Objects-in-a-Photoshop/m-p/10644877

JJMack

Adobe Expert

yes you fixed it

JJMack

pixxxelschubser

Adobe Expert

@schroef wrote:
"… Sorry my message didnt post a couple times, then i got some kind of ban and needed to wait a hour. Kinda stupid dumb it does a page refresh and not post the message. Twice did i made a long new post, both times lost
:(

This forum still isnt working really well i guess. …"

test

schroef

Inspiring

@pixxxelschubser

thanks for trying, i just posted my experience above and added some comments about what happened.

Sadly i didnt screengrab every error i got. Only the "wrong/bad HTML" code error

Sil.C

Community Manager

test

schroef

Inspiring

This issue happened when i was posting message quite fast within the hour. Thats also why i got the "wait 3600 second" warning/error.

I also see a lot of errors when i post code which have comments in them from either community links or other website. It then shows an error about "faulty html" code or so. I did make a screengrab of that error i get a lot when pasting script as Javascript. Sometimes when i checked the pasted script, i noticed parts where missing. But also i noticed sometimes parts where added. I looked like it grabbed text of the forum link i pasted in the script as a comment.

What i did see a lot was that when i pressed post, the page would reload and nothing showed. No error not hint of bad embed text nothing, my complete message was gone. This happened quite a lot of times. Then eventually after witing a day i still could reply to a post made by JJMack. I could only reply to the main question on top.

Could it be that threads have some kind of limit of responses? Because i was posting quite a lot script code each time, perhaps there something like a "max character count", i dont know. You would need to ask the developers of the forum.

The fact that you think its posting and it doesnt is nasty. You cant go back and you basically lost your complete message.

Hope this helps to understand what i was experiencing and perhaps can help to backtrack the issue.

PS there was actually another weird error i got. Its an error where it also stated that "invalid HTML" is used and that its being highlighted, yet nothing is highlighted then?!

schroef

Inspiring

@JJMack

Sorry my message didnt post a couple times, then i got some kind of ban and needed to wait a hour. Kinda stupid dumb it does a page refresh and not post the message. Twice did i made a long new post, both times lost 😞 This forum still isnt working really well i guess.

Anyways here's the link. https://we.tl/t-amPqhIM4pC

I had it ready forgot about, but than it also got delete twice because of the prior post issue

I finally got it working again. I now open the smartobject between the 2 dialogs. Somehow the GUI does update then properly. I than use command to switch documents. I also delete the prior delete file to keep smaller when saving. I thought this part of the code would make the script run longer. But it actually faster then. Sometimes its about 1 sec faster running it with 6 designs.

It was quite weird actually, because at one point i already had it working. Then for extra check i saved the main template closed photoshop opened it again and then suddenly it would run. So this time i did save the script file into a new version from the point it was working and then started fine tuning.

I notice that when functions are below in the script this can cause issues. Now i make sure the functions are earlier in the lines. Im not sure im 100% cirrect on this, but it seems this does influence the script sometimes.

Im also suspending the history, i believe this also speeds things up since they dont neet to be written to the log and the GUI.

Below version works, ive tested it multiple times now while opening and closing the main file and restarting Phososhop a couple times. It works just a bit nicer now then the other version i had yesterday, there i opened the smartobject from the start manually.

after i waited a day now it still wont allow me to post a comment here?!? Im trying this with a linked version of the script. I also had to reply to the first comment. I cant reply to your latest comment, it will refresh and nothing is posted. Therefor i tagged you using your name, that way im sure you are notified

http://www.filedropper.com/exportmockupdesigns10

JJMack

Adobe Expert

The problem is strange and does not always fail the same way. The Problem seems to be related to some smart object layer and the way the are crated. For example the only template I had where the smart object did open right away with

		runMenuItem(stringIDToTypeID('placedLayerEditContents'));

was one I download from the web. When I replicated the Template on my Windows machine it did open right away. However, if I ran the same batch job sever time in a row occasionally the object would fail to open right away in the middle of a batch but the code I added to wait for it to open or to add a open would solve the problem most of the time. Waiting always seem to work however occasionally other problems would happen if I added the open command. Perhaps I open and update the object then the opened again open again and missed up my script because it was the processing the wrong document.

Now the Template you posted only one smart object layer needs to be updated but the template has several smart object layers on the top of the stack. My mockup scripts are design to only update the top of the layers stack smart object layers. It is easy to convert Mockup templates to be compatible with my scripts design. So I modified your template. I simply grouped all the layer above the Background into a group named Mockup. I the used Ctrl+J to dupe the smart object layer that needs to be updated and move the copy out of the mockup group to the top of the layer stack and I removed the masks changed opacity and fill to 0 and turn off its visibility.

Right away the Smart Object fail to open but my script had not problem populating the template. I then replicated your template. I saved the smart object work file as a PSD File. I them placed the PSD file into the replicated template above the smart object layer that needs the replacement. and did a Ctrl+J to dupe it and moved the dupe to the top of the stack set fill and opacity to 0 and turn off its visibility. and deleted the old top of the stack smart object layer.. I then moved the vector layer mask off of the smart object layer to the placed psd smart object layer and the deleted the smart object layer that needed to be replaced. I clipped the Smart object layer to the Phone case layer at the sized the object with a transform to cover the phone case and Saved the Template. On my machine this template object open right away. Running many batches occasionally it may fails to open. This is a strange problem. I have not test in PS 2020 just 2021.

Here is a link to a zip file the has my text templates and scripts Mockups.zip

JJMack

Adobe Expert

I have now tested with CS6, CC 2014, CC 2018, CC 2019, PS 2020 and PS 2021. All seen to fail to open the Smart Object Layer's object that your Mac created right away like the one I had downloaded. Where in PS 2021 version 22.1 if I wait using a wait till message the object will open. In prior Photoshop the object never opens I have to add the open for the temp work file that was created by Photoshop for placeLeyerEditContents but did not open.

So the scripts in my toolkit work in Photoshop version prior to PS 2021 on windows machines. I'm not positive they will on Mac for I'm not sure of where Photoshop created the temp work file on a mac. This is what I use for Windows it may be the same for Mac. depends on Forder.temp beint the place the file is created

var workFile = new File(Folder.temp + "/" +  name);  // May work for both Windows and Mac

PS 22.1 can occasionally have problem if I add the Open Command. However, adding the open performs faster than waiting for the object to eventually open So I will not be changing my scripts for waiting requires human interaction which is not appropriate for a batch process.

I look at you script its seem to work on my machine but has issues with Place scaling images and it leave the object open. I particularly do not like templates that have smart object layer where the object is layered and to populate the template you have to edits late within the object. Templates like that are too hard to use and requite a custom script for automation. It is far easier to create templates that simply need the smart object replaced. So I simplified your Template or the one you purchased or downloaded. I rasterized some layers and moved the tool bar layers into the template from the object and added a camera layer. This template can be batch processed with my script and if you use its edit option replacement images can be any size. The phone screen will be filled with image content. If replacement images are Phone size my scripts default isuse Replace content not edit here the template. samsung-s20-mockup-xxx.psd

http://www.mouseprints.net/old/dpr/samsung-s20-mockup-xxx.psd

JJMack

Adobe Expert

A PSD Object will open in Photoshop and your script will still be in cintrol of Photoshop and can edit the opened object. However, you need to be careful opening Smart Object Layers contents using A Photoshop script. There are many ways smart object layers are created. All smart Object Layers's Object are not Photoshop Objects. If you open them in a Photoshop script they will open in other applications or a Photoshop ACR Plug-in. The Photoshop script that opened the object will lose control till the Application or pug-in execution finishes The script can not edit such objects. R-bin posted code you can use to test the type object a smart object contains. To determine if the object will open in Photoshop or not. I use that code in my Batch Photoshop Mockups scripts when the user want toe edit object rather than replace smart object layer object using replace content. My scripts can not handle editing Mockup templates smart object layers that have none Photoshop object. Only replace content is supported for none when Smart Object layer have none Photoshop Objects.


function objectIsPsObject(SOlayer) {
	//Thanks to r-bin
	var ext = smartobject_file_ext(SOlayer);  
    var rc = true;
	switch (ext)  
		{  
		case "nef":  
		case "cr2":  
		case "crw":  
		case "raf":  
		case "orf":  
		case "mrw":  
		case "dcr":  
		case "mos":  
		case "raw":  
		case "pef":  
		case "srf":  
		case "dng":  
		case "x3f":  
		case "erf":  
		case "sr2":  
		case "kdc":  
		case "mfw":  
		case "mef":  
		case "arw":  
		case "nrw":  
		case "rw2":  
		case "rwl":  
		case "iiq":  
		case "3fr":  
		case "fff":  
		case "srw":  
		case "ai":
		case "svg":
		case "pdf":
		case "esp":
			rc = false.	
			break;  
		case "error":  
			rc = false;
			break;         
  		default:  
			rc = true;
			break;  
    }  
	return rc;
}

r-bin code

JJMack

Stephen Marsh

Adobe Expert

JJMack, the code as posted does not work...

When I add:

objectIsPsObject();

An error is returned from your posted code:

Runtime Error: Error Code# 24: smartobject_file_ext is not a function on the following code entry:

var ext = smartobject_file_ext(SOlayer);

J

jefbr

Inspiring

I have no desire to look at your code. If you are using Photoshop Place you need to understand hop Photoshop Place feature works. Its implementation is very strange, and it will scale the replacement object if the two documents resolution are not the same and also scale the layer to fit on canvas if the object layer created scaled to a layer that is larger than canvas. In my mockup scripts Edit object function I do not use Photoshop Place I Open replacement and use copy and paste. So at some point the are three Document open in Photoshop. The Mockup Template, The Smart Object Work document and the Replacement image document. After I use copy in the replacement image document I close the replacement document and paste the resize image into the Objects Work document then save and closet the the Object work Document so Photoshop will update the Templates document smart object layer.

It may be that the Object work file may not be opening in your case because of how the template Smart object works. So Place placed the replacement into your template not your object. I had to change my code a few weeks ago because of that. Someone Posted a Template that had a Smart Object that did not Open in Photoshop when Open smart object is used on the template's smart object layer. It Also did not throw are error sof my script destroyed the template.. Using the script listener on that template I saw the Photoshop did create the temp work file but added an Open after the Open smart object smart to open the object work file. I had to add code to text if the open Smart Object opened the work file into a photoshop document and if not open use file open to open the work file Photoshop created but failed to open.

The code I posted for you hads a function that opened the smar object that I had to update to insure the work document opens. here is that code.

////// open smart object //////
function openSmartObject (theLayer) {
	current = app.activeDocument;
	if (theLayer.kind == "LayerKind.SMARTOBJECT") {
		runMenuItem(stringIDToTypeID('placedLayerEditContents'));
		if ( current == app.activeDocument) {
			try {         
				var r = new ActionReference();     
				r.putProperty(stringIDToTypeID("property"), stringIDToTypeID("smartObject"));  
				r.putIdentifier(stringIDToTypeID("layer"), theLayer.id);  
				var name = executeActionGet(r).getObjectValue(stringIDToTypeID("smartObject")).getString(stringIDToTypeID("fileReference"));         
				}  
			catch (e) { throw theLayer + " Smart Object Did not Open"; }  
			var workFile = new File(Folder.temp + "/" +  name);  // May work for both Windows and Mac
			if (workFile.exists) app.open(File(workFile));
			if ( current == app.activeDocument) throw theLayer + " Smart Object Did not Open";
		}
	}
	return app.activeDocument
};

Not adding much to the conversation, but thank you for the good laugh!

"I have no desire to look at your code."

I almost died laughing at the office. 😄

Stephen MarshCorrect answer

Adobe Expert

One way:

app.runMenuItem(stringIDToTypeID('placedLayerEditContents'));

https://community.adobe.com/t5/Photoshop/Script-to-Export-Contents-of-all-Smart-Objects-in-a-Photoshop/m-p/10644877

J

jacksons96833643Author

New Participant

Thanks Stephen & JJmack, answer was right in front of me in the code but couldn't see it through the forest.

Sign up

To post, reply, or follow discussions, please sign in with your Adobe ID.

Sign in to Adobe Community

To post, reply, or follow discussions, please sign in with your Adobe ID.

Scanning file for viruses.

This file cannot be downloaded