Explore related tutorials & articles
18
Replies
Here are a couple photos. The color sampler points did not show up in the photos when inserted, so I've marked them on the top photo. The goal is ultimately to blend the sky of the darker photo in the brighter exposure. And the best way to do this is actually to use the color sampler points from both layers and take the average of them, and set the average as the output (not swap the values as I indicated in my initial post). I didn't think this extra step of figuring out the average would require much effort once I figured out how to do the heavy lifting, so please excuse me if that confused things. For the photos below, I would load the photos as layers. Then using the sampler point on the left, I would look at the RGB values of it and then hide that layer and look at the RGB sampler values of the same point on the photo below it. Then I would take the average of the R value for the top and bottom and use as the output for the curve layers I create, one for each photo. (the input is obtained by shift+clicking on the color sampler on each layer). I would repeat the process for the right most color sampler point, so that each curve now has two anchor points on each RGB channel.
That sounds long winded, but I hope it makes sense. And again, I apologize for any inconvenience.
Hi c.pfaffenbichler,
I have had some computer issues the last few days and am just now able to work on this in earnest.
First, I tried to run the Michael's code in the script editor, but it returned an error. I believe this is because of the conditions set, which required layers to be active, etc. I'm nost sure then, what use the script editor will be in this particular case. Next I then ran it in CS5, and separately ran your code in CS5 as well.
Michael's code created a new curves layer, and if I understand it correctly, set the groundwork for me to be able to add in curves points using the color sampler variables he created.
Your code returned a curves layer with anchor points in the R,G,B channels, the input and output values are not entirely clear to me upon trying to parse the code. The B channel for some reason was assigned two anchor points with output values. The net effect of the curves adjustment was to make the photo much more red in appearance. I realize I need to learn a lot more code to really understand these scripts that have been writtenn
I'm reattaching the photos with a 3rd, which is the result of the adjustment. I have removed the painted circles around the color sampler points. The top most photo below is the adjusted photo, the second is the darker sky exposure and the lowest photo is a brighter exposure for the hills and river. The brightness of the sky in the top photo is kind of mid-way between the brighter and darker photos. The main thing is that it, and the background hills retains detail, which can be adjusted later in photoshop. 
The function I had provided was an example into which you would need to feed the values you got with Mike’s code.
The code below would create a Curves Layer as shown in the screenshot, but I’m not sure it would work reasonably for all cases.
// with code by mike hale;
// 2012, use it at your own risk;
// call the function to run the script
#target photoshop
createCurveAdjustmetFromColorSamplers();
// create a function fo hold most of the code
function createCurveAdjustmetFromColorSamplers(){
// first add some condition checks
// needs an open document in a color mode that supports layers
if(app.documents.length == 0 || ( app.activeDocument.mode == DocumentMode.BITMAP || app.activeDocument.mode == DocumentMode.INDEXEDCOLOR ) ){
alert('This script requires a document in Greyscale, RGB, CMYK, or Lab mode.');
return;
}
// check for at least two colorSamplers
if(app.activeDocument.colorSamplers.length < 2 ){
alert('This script requires at least two colorSamplers.');
return;
}
// last check for at least two layers - assume they will be on same level( not in layerSet )
if(app.activeDocument.layers.length < 2 ){
alert('This script requires at least two layers.');
return;
}
// create varaibles to hold the colorSampler's color property for each layer
// for the bottom layer
var outputArray = new Array();
// for top layer - array could also be created this way
var inputArray = [];
// store the number of samples because it will be needed in more than one place
var numberOfSamples = app.activeDocument.colorSamplers.length;
// hide the top layer
app.activeDocument.layers[0].visible = false;
// collect the samples from the bottom layer
for(var sampleIndex = 0; sampleIndex < numberOfSamples; sampleIndex++ ){
outputArray.push(app.activeDocument.colorSamplers[sampleIndex].color);
}
// turn the top layer back on
app.activeDocument.layers[0].visible = true;
// collect those samples
for(var sampleIndex = 0; sampleIndex < numberOfSamples; sampleIndex++ ){
inputArray.push(app.activeDocument.colorSamplers[sampleIndex].color);
}
// make sure the top layer is the activeLayer
app.activeDocument.activeLayer = app.activeDocument.layers[0];
// create arrays of the color values:
var theArray = [[0, 0, 0, 0, 0, 0]];
for (var m = 0; m < inputArray.length; m++) {
theArray.push([inputArray
.rgb.red, outputArray .rgb.red, inputArray .rgb.green, outputArray .rgb.green, inputArray .rgb.blue, outputArray .rgb.blue]); };
theArray.push([255, 255, 255, 255, 255, 255]);
// sort;
theArray.sort(sortArrayByIndexedItem);
// makeCurveAdjustmentLayer();
rgbCurvesLayer (theArray)
};
////// make rgb curves layer //////
function rgbCurvesLayer (theArray) {
// =======================================================
var idMk = charIDToTypeID( "Mk " );
var desc5 = new ActionDescriptor();
var idnull = charIDToTypeID( "null" );
var ref2 = new ActionReference();
var idAdjL = charIDToTypeID( "AdjL" );
ref2.putClass( idAdjL );
desc5.putReference( idnull, ref2 );
var idUsng = charIDToTypeID( "Usng" );
var desc6 = new ActionDescriptor();
var idType = charIDToTypeID( "Type" );
var desc7 = new ActionDescriptor();
var idpresetKind = stringIDToTypeID( "presetKind" );
var idpresetKindType = stringIDToTypeID( "presetKindType" );
var idpresetKindDefault = stringIDToTypeID( "presetKindDefault" );
desc7.putEnumerated( idpresetKind, idpresetKindType, idpresetKindDefault );
var idCrvs = charIDToTypeID( "Crvs" );
desc6.putObject( idType, idCrvs, desc7 );
var idAdjL = charIDToTypeID( "AdjL" );
desc5.putObject( idUsng, idAdjL, desc6 );
executeAction( idMk, desc5, DialogModes.NO );
// =======================================================
var idsetd = charIDToTypeID( "setd" );
var desc8 = new ActionDescriptor();
var idnull = charIDToTypeID( "null" );
var ref3 = new ActionReference();
var idAdjL = charIDToTypeID( "AdjL" );
var idOrdn = charIDToTypeID( "Ordn" );
var idTrgt = charIDToTypeID( "Trgt" );
ref3.putEnumerated( idAdjL, idOrdn, idTrgt );
desc8.putReference( idnull, ref3 );
var idT = charIDToTypeID( "T " );
var desc9 = new ActionDescriptor();
var idpresetKind = stringIDToTypeID( "presetKind" );
var idpresetKindType = stringIDToTypeID( "presetKindType" );
var idpresetKindCustom = stringIDToTypeID( "presetKindCustom" );
desc9.putEnumerated( idpresetKind, idpresetKindType, idpresetKindCustom );
var idAdjs = charIDToTypeID( "Adjs" );
var list1 = new ActionList();
var desc10 = new ActionDescriptor();
var idChnl = charIDToTypeID( "Chnl" );
var ref4 = new ActionReference();
var idChnl = charIDToTypeID( "Chnl" );
var idChnl = charIDToTypeID( "Chnl" );
var idRd = charIDToTypeID( "Rd " );
ref4.putEnumerated( idChnl, idChnl, idRd );
desc10.putReference( idChnl, ref4 );
var idCrv = charIDToTypeID( "Crv " );
var list2 = new ActionList();
// add r points;
for (var m = 0; m < theArray.length; m++) {
addCurvePoint (list2, theArray
, 0) };
desc10.putList( idCrv, list2 );
var idCrvA = charIDToTypeID( "CrvA" );
list1.putObject( idCrvA, desc10 );
var desc15 = new ActionDescriptor();
var idChnl = charIDToTypeID( "Chnl" );
var ref5 = new ActionReference();
var idChnl = charIDToTypeID( "Chnl" );
var idChnl = charIDToTypeID( "Chnl" );
var idGrn = charIDToTypeID( "Grn " );
ref5.putEnumerated( idChnl, idChnl, idGrn );
desc15.putReference( idChnl, ref5 );
var idCrv = charIDToTypeID( "Crv " );
var list3 = new ActionList();
// add g points;
for (var m = 0; m < theArray.length; m++) {
addCurvePoint (list3, theArray
, 2) };
desc15.putList( idCrv, list3 );
var idCrvA = charIDToTypeID( "CrvA" );
list1.putObject( idCrvA, desc15 );
var desc20 = new ActionDescriptor();
var idChnl = charIDToTypeID( "Chnl" );
var ref6 = new ActionReference();
var idChnl = charIDToTypeID( "Chnl" );
var idChnl = charIDToTypeID( "Chnl" );
var idBl = charIDToTypeID( "Bl " );
ref6.putEnumerated( idChnl, idChnl, idBl );
desc20.putReference( idChnl, ref6 );
var idCrv = charIDToTypeID( "Crv " );
var list4 = new ActionList();
// add b points;
for (var m = 0; m < theArray.length; m++) {
addCurvePoint (list4, theArray
, 4) };
desc20.putList( idCrv, list4 );
var idCrvA = charIDToTypeID( "CrvA" );
list1.putObject( idCrvA, desc20 );
desc9.putList( idAdjs, list1 );
var idCrvs = charIDToTypeID( "Crvs" );
desc8.putObject( idT, idCrvs, desc9 );
executeAction( idsetd, desc8, DialogModes.NO );
//
return app.activeDocument.activeLayer;
////// add curve point //////
function addCurvePoint (theList, valueHor, theNumber) {
var desc11 = new ActionDescriptor();
var idHrzn = charIDToTypeID( "Hrzn" );
desc11.putDouble( idHrzn, valueHor[theNumber] );
var idVrtc = charIDToTypeID( "Vrtc" );
desc11.putDouble( idVrtc, valueHor[theNumber+1] );
var idPnt = charIDToTypeID( "Pnt " );
theList.putObject( idPnt, desc11 );
};
};
////// sort a double array, thanks to sam, http://www.rhinocerus.net/forum/lang-javascript/ //////
function sortArrayByIndexedItem(a,b) {
var theIndex = 0;
if (a[theIndex]<b[theIndex]) return -1;
if (a[theIndex]>b[theIndex]) return 1;
return 0;
};
AdChoices